FailedChanges

Summary

  1. [X86][AVX] Add i686 avx splat tests
  2. Make most clangd unittests pass on Windows The Windows triple currently turns on delayed template parsing, which confuses several unit tests that use templates. For now, just explicitly disable delayed template parsing. This isn't ideal, but: - the Windows triple will soon no longer use delayed template parsing by default - there's precedent for this in the clangd unit tests already - let's get the clangd tests pass on Windows first before making behavioral changes Part of PR43592.
  3. BlockInCriticalSectionChecker - silence static analyzer dyn_cast null dereference warning. NFCI. The static analyzer is warning about a potential null dereference, but we should be able to use cast<> directly and if not assert will fire for us.
  4. IRTranslator - silence static analyzer null dereference warnings. NFCI. The CmpInst::getType() calls can be replaced by just using User::getType() that it was dyn_cast from, and we then need to assert that any default predicate cases came from the CmpInst.
  5. [clang-tidy] bugprone-not-null-terminated-result: checker adjustments 4
  6. [clang-tidy] bugprone-not-null-terminated-result: checker adjustments 3 On Windows the signed/unsigned int conversions of APInt seems broken, so that two of the test files marked as unsupported on Windows, as a hotfix.
Revision 374719 by rksimon:
[X86][AVX] Add i686 avx splat tests
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/CodeGen/X86/avx-splat.ll (diff)llvm.src/test/CodeGen/X86/avx-splat.ll
Revision 374718 by nico:
Make most clangd unittests pass on Windows

The Windows triple currently turns on delayed template parsing, which
confuses several unit tests that use templates.

For now, just explicitly disable delayed template parsing. This isn't
ideal, but:

- the Windows triple will soon no longer use delayed template parsing
  by default

- there's precedent for this in the clangd unit tests already

- let's get the clangd tests pass on Windows first before making
  behavioral changes

Part of PR43592.
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/unittests/FindTargetTests.cpp (diff)clang-tools-extra.src/clangd/unittests/FindTargetTests.cpp
The file was modified/clang-tools-extra/trunk/clangd/unittests/ParsedASTTests.cpp (diff)clang-tools-extra.src/clangd/unittests/ParsedASTTests.cpp
The file was modified/clang-tools-extra/trunk/clangd/unittests/SelectionTests.cpp (diff)clang-tools-extra.src/clangd/unittests/SelectionTests.cpp
The file was modified/clang-tools-extra/trunk/clangd/unittests/SemanticHighlightingTests.cpp (diff)clang-tools-extra.src/clangd/unittests/SemanticHighlightingTests.cpp
The file was modified/clang-tools-extra/trunk/clangd/unittests/TweakTesting.cpp (diff)clang-tools-extra.src/clangd/unittests/TweakTesting.cpp
The file was modified/clang-tools-extra/trunk/clangd/unittests/TweakTesting.h (diff)clang-tools-extra.src/clangd/unittests/TweakTesting.h
The file was modified/clang-tools-extra/trunk/clangd/unittests/TweakTests.cpp (diff)clang-tools-extra.src/clangd/unittests/TweakTests.cpp
The file was modified/clang-tools-extra/trunk/clangd/unittests/XRefsTests.cpp (diff)clang-tools-extra.src/clangd/unittests/XRefsTests.cpp
Revision 374717 by rksimon:
BlockInCriticalSectionChecker - silence static analyzer dyn_cast null dereference warning. NFCI.

The static analyzer is warning about a potential null dereference, but we should be able to use cast<> directly and if not assert will fire for us.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/StaticAnalyzer/Checkers/BlockInCriticalSectionChecker.cpp (diff)clang.src/lib/StaticAnalyzer/Checkers/BlockInCriticalSectionChecker.cpp
Revision 374716 by rksimon:
IRTranslator - silence static analyzer null dereference warnings. NFCI.

The CmpInst::getType() calls can be replaced by just using User::getType() that it was dyn_cast from, and we then need to assert that any default predicate cases came from the CmpInst.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/GlobalISel/IRTranslator.cpp (diff)llvm.src/lib/CodeGen/GlobalISel/IRTranslator.cpp
Revision 374715 by charusso:
[clang-tidy] bugprone-not-null-terminated-result: checker adjustments 4
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/test/clang-tidy/Inputs/bugprone-not-null-terminated-result/not-null-terminated-result-c.h (diff)clang-tools-extra.src/test/clang-tidy/Inputs/bugprone-not-null-terminated-result/not-null-terminated-result-c.h
Revision 374713 by charusso:
[clang-tidy] bugprone-not-null-terminated-result: checker adjustments 3

On Windows the signed/unsigned int conversions of APInt seems broken, so that
two of the test files marked as unsupported on Windows, as a hotfix.
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/test/clang-tidy/bugprone-not-null-terminated-result-strlen.c (diff)clang-tools-extra.src/test/clang-tidy/bugprone-not-null-terminated-result-strlen.c
The file was modified/clang-tools-extra/trunk/test/clang-tidy/bugprone-not-null-terminated-result-wcslen.cpp (diff)clang-tools-extra.src/test/clang-tidy/bugprone-not-null-terminated-result-wcslen.cpp