SuccessChanges

Summary

  1. [SystemZ] Fix typo (details)
  2. Fix compilation warning. NFC. (details)
  3. [IR] adjust assert when replacing undef elements in vector constant (details)
  4. [ARM] Use isFMAFasterThanFMulAndFAdd for MVE (details)
  5. [OpenCL] Fix FileCheck pattern (details)
  6. [X86] Regenerate known-signbits-vector.ll tests. (details)
  7. SanitizerMask::bitPosToMask - fix operator precedence warnings. NFCI. (details)
  8. [MachineVerifier]  Improve verification of live-in lists. (details)
  9. [SystemZ]  Use LivePhysRegs instead of isCCLiveOut() in (details)
  10. [test] Use system locale for mri-utf8.test (details)
  11. [Diagnostics] Improve some error messages related to bad use of (details)
Commit d4a7855b68d4d53f121209333d5f2796731ab1f5 by ulrich.weigand
[SystemZ] Fix typo
Typo in comment.  NFC.
The file was modifiedllvm/lib/Target/SystemZ/SystemZISelLowering.h
Commit d142ec6fef9a053c9fd9edb5a388203cdb121e65 by michael.hliao
Fix compilation warning. NFC.
The file was modifiedclang/lib/Driver/ToolChains/Darwin.cpp
Commit b556ce3992709e1f6302ca1d4c296f57e83cd6a7 by spatel
[IR] adjust assert when replacing undef elements in vector constant
As noted in follow-up to: rGa1e8ad4f2fa7
It's not safe to assume that an element of the constant is always
non-null. It's definitely not an expected case for the current
instcombine user, but that may not hold if this function is eventually
called from arbitrary places.
The file was modifiedllvm/lib/IR/Constants.cpp
Commit 91b0cad8132997060182146b2734065bc807e9fa by david.green
[ARM] Use isFMAFasterThanFMulAndFAdd for MVE
The Arm backend will usually return false for
isFMAFasterThanFMulAndFAdd, where both the fused VFMA.f32 and a
non-fused VMLA.f32 are usually available for scalar code. For MVE we
don't have the non-fused version though. It makes more sense for
isFMAFasterThanFMulAndFAdd to return true, allowing us to simplify some
of the existing ISel patterns.
The tests here are that non of the existing tests failed, and so we are
still selecting VFMA and VFMS. The one test that changed shows we can
now select from fast math flags, as opposed to just relying on the
isFMADLegalForFAddFSub option.
Differential Revision: https://reviews.llvm.org/D69115
The file was modifiedllvm/lib/Target/ARM/ARMInstrMVE.td
The file was modifiedllvm/lib/Target/ARM/ARMISelLowering.cpp
The file was modifiedllvm/lib/Target/ARM/ARMISelLowering.h
The file was modifiedllvm/test/CodeGen/Thumb2/LowOverheadLoops/fast-fp-loops.ll
Commit 6c5827975cf921563315de54ac7c6053d3995f40 by sven.vanhaastregt
[OpenCL] Fix FileCheck pattern
For this test, FileCheck is not run with the CHECK prefix; it seems
COMMON was intended here.
The file was modifiedclang/test/CodeGenOpenCLCXX/addrspace-of-this.cl
Commit 03cde3a7ccd2025baa497cbcf6e825862429f1bd by llvm-dev
[X86] Regenerate known-signbits-vector.ll tests.
Use X86 instead of X32 and add a common CHECK prefix
The file was modifiedllvm/test/CodeGen/X86/known-signbits-vector.ll
Commit a0324e911374441151903ed0d828e0fc1994c167 by llvm-dev
SanitizerMask::bitPosToMask - fix operator precedence warnings. NFCI.
Fix static analyzer operator precedence warnings with suitable
bracketing. Pull out the mask generation code so clang-format doesn't
make such a mess of it.
The file was modifiedclang/include/clang/Basic/Sanitizers.h
Commit b7b170c9b46ab4c0a10ecf1d9d5832e70ca992d5 by paulsson
[MachineVerifier]  Improve verification of live-in lists.
MachineVerifier::visitMachineFunctionAfter() is extended to check the
live-through case for live-in lists. This is only done for registers
without aliases and that are neither allocatable or reserved, such as
the SystemZ::CC register.
The MachineVerifier earlier only catched the case of a live-in use
without an entry in the live-in list (as "using an undefined physical
register").
A comment in LivePhysRegs.h has been added stating a guarantee that
addLiveOuts() can be trusted for a full register both before and after
register allocation.
Review: Quentin Colombet https://reviews.llvm.org/D68267
The file was addedllvm/test/MachineVerifier/live-ins-01.mir
The file was addedllvm/test/MachineVerifier/live-ins-03.mir
The file was modifiedllvm/lib/CodeGen/MachineVerifier.cpp
The file was modifiedllvm/include/llvm/CodeGen/LivePhysRegs.h
The file was addedllvm/test/MachineVerifier/live-ins-02.mir
Commit bf6744dfb244dbd2a4abe635f57e45218292743f by paulsson
[SystemZ]  Use LivePhysRegs instead of isCCLiveOut() in
SystemZElimCompare.cpp
Review: Ulrich Weigand https://reviews.llvm.org/D68267
The file was modifiedllvm/lib/Target/SystemZ/SystemZElimCompare.cpp
Commit 0bab0538d8cc0de242ed2936a4766930cfc934d2 by thomasp
[test] Use system locale for mri-utf8.test
Summary: llvm-ar's mri-utf8.test test relies on the en_US.UTF-8 locale
to be installed for its last RUN line to work. If not installed, the
unicode string gets encoded (interpreted) as ascii which fails since the
most significant byte is non zero. This commit changes the test to only
rely on the system being able to encode the pound sign in its default
encoding (e.g. UTF-16 for Microsoft Windows) by always opening the file
via input/output redirection. This avoids forcing a given locale to be
present and supported. A Byte Order Mark is also added to help
recognizing the encoding of the file and its endianness. Finally the
XFAIL on system-darwin is removed since the test actually passes fine on
Mac OS X and XFAIL was only added because it failed before.
Reviewers: gbreynoo, MaskRay, rupprecht, JamesNagurne, jfb
Subscribers: dexonsmith, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D68472
The file was removedllvm/test/tools/llvm-ar/mri-utf8.test
The file was addedllvm/test/tools/llvm-ar/mri-nonascii.test
Commit 55507110b988c27cfb9ff4c2231fa38171692545 by Dávid Bolvanský
[Diagnostics] Improve some error messages related to bad use of
dynamic_cast
The file was modifiedclang/test/SemaTemplate/instantiate-cast.cpp
The file was modifiedclang/lib/Sema/SemaCast.cpp
The file was modifiedclang/test/SemaCXX/dynamic-cast.cpp
The file was modifiedclang/include/clang/Basic/DiagnosticSemaKinds.td