SuccessChanges

Summary

  1. [clangd] Delete default arguments while moving functions out-of-line (details)
  2. [clangd] Delete ctor initializers while moving functions out-of-line (details)
  3. [lldb] Clean up accidentally passing TestDeadStrip.py (details)
  4. Reland 198fbcb8, "Driver: Don't look for libc++ headers in the install (details)
  5. scudo: Add a basic malloc/free benchmark. (details)
  6. Magic number checker shouldn't warn on user defined string literals (details)
  7. [clangd] also filter out another possible diag from MS ASM syntax (details)
Commit 898d7a0695c577b8cfe3b86b974b71f1ecb3e6c2 by kadircet
[clangd] Delete default arguments while moving functions out-of-line
Summary: Only function declarations should have the default arguments.
This patch makes sure we don't propogate those arguments to out-of-line
definitions.
Fixes https://github.com/clangd/clangd/issues/221
Reviewers: hokein
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95,
cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71187
The file was modifiedclang-tools-extra/clangd/unittests/TweakTests.cpp
The file was modifiedclang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp
Commit a209a8000e17ef3560598a44825747aab2f7914d by kadircet
[clangd] Delete ctor initializers while moving functions out-of-line
Summary: Currently we only delete function body from declaration, in
addition to that we should also drop ctor initializers.
Unfortunately CXXConstructorDecl doesn't store the location of `:`
before initializers, therefore we make use of token buffer to figure out
where to start deletion.
Fixes https://github.com/clangd/clangd/issues/220
Reviewers: hokein, ilya-biryukov
Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71188
The file was modifiedclang-tools-extra/clangd/unittests/TweakTests.cpp
The file was modifiedclang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp
Commit be05633e28949139093278d5ce57a194756bfb83 by pavel
[lldb] Clean up accidentally passing TestDeadStrip.py
This test was accidentally passing on non-darwin OS because it was
explicitly setting the CFLAGS make variable. This meant that (in the
default config) it was building with absolutely no debug info, and so
setting a breakpoint on a stripped symbol failed, because there was
really no trace of it remaining. In other configurations, we were
generating the debug info (-gsplit-dwarf implies -g) and the test failed
because we did not treat the zeroed out debug info address specially.
The test was also xfailed in pretty much every non-standard
configuration.
This patch fixes the makefile to avoid messing with CFLAGS (use
CFLAGS_EXTRAS instead). This causes it to fail in all configurations
(except darwin), and so I replace the various decorators with a simple
os!=darwin check.
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/dead-strip/TestDeadStrip.py
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/dead-strip/Makefile
Commit bab9849963eb9b9f1fa03900e8c48a7c7d6fc305 by peter
Reland 198fbcb8, "Driver: Don't look for libc++ headers in the install
directory on Android.", which was reverted in b3249027.
Fixed the test case to set --sysroot, which lets it succeed in the case
where a directory named "/usr/include/c++/v1" or
"/usr/local/include/c++/v1" exists.
Original commit message:
> The NDK uses a separate set of libc++ headers in the sysroot. Any
headers
> in the installation directory are not going to work on Android, not
least
> because they use a different name for the inline namespace (std::__1
instead
> of std::__ndk1).
>
> This effectively makes it impossible to produce a single toolchain
that is
> capable of targeting both Android and another platform that expects
libc++
> headers to be installed in the installation directory, such as Mac.
>
> In order to allow this scenario to work, stop looking for headers in
the
> install directory on Android.
Differential Revision: https://reviews.llvm.org/D71154
The file was modifiedclang/lib/Driver/ToolChains/Linux.cpp
The file was modifiedclang/test/Driver/stdlibxx-isystem.cpp
The file was addedclang/test/Driver/android-no-installed-libcxx.cpp
Commit 29f0a65671e2be3a5529b7429f6d6b5c5988b79e by peter
scudo: Add a basic malloc/free benchmark.
Differential Revision: https://reviews.llvm.org/D71104
The file was addedcompiler-rt/lib/scudo/standalone/benchmarks/CMakeLists.txt
The file was modifiedcompiler-rt/lib/scudo/standalone/CMakeLists.txt
The file was modifiedcompiler-rt/lib/scudo/standalone/tsd_shared.h
The file was addedcompiler-rt/lib/scudo/standalone/benchmarks/malloc_benchmark.cpp
The file was addedllvm/utils/gn/secondary/compiler-rt/lib/scudo/standalone/benchmarks/BUILD.gn
The file was modifiedllvm/utils/gn/secondary/compiler-rt/lib/scudo/BUILD.gn
The file was modifiedcompiler-rt/lib/scudo/standalone/allocator_config.h
The file was addedllvm/utils/gn/secondary/llvm/utils/benchmark/BUILD.gn
Commit be7d633a6fa6ddae6b7f455f5f336555d088c62d by aaron
Magic number checker shouldn't warn on user defined string literals
Fixes a false positive brought up by PR40633.
The file was addedclang-tools-extra/test/clang-tidy/readability-magic-numbers-userliteral.cpp
The file was modifiedclang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp
Commit d0ccd55151f52992912dbc12d04a027cf5e06d2f by sam.mccall
[clangd] also filter out another possible diag from MS ASM syntax
The file was modifiedclang-tools-extra/clangd/Diagnostics.cpp