FailedChanges

Summary

  1. [X86] Move negateFMAOpcode helper earlier to help future patch. NFCI.
  2. [LV] Update test case after r371768.
  3. [SCEV] Support SCEVUMinExpr in getRangeRef. This patch adds support for SCEVUMinExpr to getRangeRef, similar to the support for SCEVUMaxExpr. Reviewers: sanjoy.google, efriedma, reames, nikic Reviewed By: sanjoy.google Differential Revision: https://reviews.llvm.org/D67177
  4. Improve code generation for thread_local variables: Summary: * Don't bother using a thread wrapper when the variable is known to have constant initialization. * Emit the thread wrapper as discardable-if-unused in TUs that don't contain a definition of the thread_local variable. * Don't emit the thread wrapper at all if the thread_local variable is unused and discardable; it will be emitted by all TUs that need it. Reviewers: rjmccall, jdoerfert Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D67429
  5. [Clang][CodeGen] support alias attribute w/ gnu_inline Summary: r369705 did not consider the addition of gnu_inline on function declarations of alias attributed functions. This resulted in a reported regression in the clang-9-rc4 release from the Zig developers building glibc, which was observable as a failed assertion: llvm-project/clang/lib/AST/Decl.cpp:3336: bool clang::FunctionDecl::isInlineDefinitionExternallyVisible() const: Assertion `(doesThisDeclarationHaveABody() || willHaveBody()) && "Must be a function definition"' failed. Alias function declarations do not have bodies, so allow us to proceed if we have the alias function attribute but no body/definition, and add a test case. The emitted symbols and their linkage matches GCC for the added test case. Link: https://bugs.llvm.org/show_bug.cgi?id=43268 Reviewers: aaron.ballman, rsmith, erichkeane, andrewrk Reviewed By: andrewrk Subscribers: cfe-commits, andrewrk, hans, srhines Tags: #clang Differential Revision: https://reviews.llvm.org/D67455
  6. [CFG] Add dumps for CFGElement and CFGElementRef Seems like we never had these, so here we go! I also did some refactoring as I was chasing a bug unrelated to this revision. Differential Revision: https://reviews.llvm.org/D66715
  7. llvm-reduce: For now, mark these tests as requiring a shell (since they execute shell scripts/that's the only entry point at the moment)
  8. [libc++] Mark issue 2587 resolved by issue 2567 Updates status. NFC.
Revision 371770 by rksimon:
[X86] Move negateFMAOpcode helper earlier to help future patch. NFCI.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (diff)llvm.src/lib/Target/X86/X86ISelLowering.cpp
Revision 371769 by fhahn:
[LV] Update test case after r371768.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Transforms/LoopVectorize/X86/load-deref-pred.ll (diff)llvm.src/test/Transforms/LoopVectorize/X86/load-deref-pred.ll
Revision 371768 by fhahn:
[SCEV] Support SCEVUMinExpr in getRangeRef.

This patch adds support for SCEVUMinExpr to getRangeRef,
similar to the support for SCEVUMaxExpr.

Reviewers: sanjoy.google, efriedma, reames, nikic

Reviewed By: sanjoy.google

Differential Revision: https://reviews.llvm.org/D67177
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Analysis/ScalarEvolution.cpp (diff)llvm.src/lib/Analysis/ScalarEvolution.cpp
The file was modified/llvm/trunk/test/Analysis/ScalarEvolution/max-expr-cache.ll (diff)llvm.src/test/Analysis/ScalarEvolution/max-expr-cache.ll
The file was modified/llvm/trunk/test/Analysis/ScalarEvolution/trip-count15.ll (diff)llvm.src/test/Analysis/ScalarEvolution/trip-count15.ll
Revision 371767 by rsmith:
Improve code generation for thread_local variables:

Summary:
* Don't bother using a thread wrapper when the variable is known to
   have constant initialization.
* Emit the thread wrapper as discardable-if-unused in TUs that don't
   contain a definition of the thread_local variable.
* Don't emit the thread wrapper at all if the thread_local variable
   is unused and discardable; it will be emitted by all TUs that need
   it.

Reviewers: rjmccall, jdoerfert

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D67429
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Basic/Linkage.h (diff)clang.src/include/clang/Basic/Linkage.h
The file was modified/cfe/trunk/lib/CodeGen/CGCXXABI.h (diff)clang.src/lib/CodeGen/CGCXXABI.h
The file was modified/cfe/trunk/lib/CodeGen/CGExpr.cpp (diff)clang.src/lib/CodeGen/CGExpr.cpp
The file was modified/cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp (diff)clang.src/lib/CodeGen/ItaniumCXXABI.cpp
The file was modified/cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp (diff)clang.src/lib/CodeGen/MicrosoftCXXABI.cpp
The file was removed/cfe/trunk/test/CodeGen/windows-on-arm-itanium-thread-local.cclang.src/test/CodeGen/windows-on-arm-itanium-thread-local.c
The file was modified/cfe/trunk/test/CodeGenCXX/cxx11-thread-local.cpp (diff)clang.src/test/CodeGenCXX/cxx11-thread-local.cpp
The file was added/cfe/trunk/test/CodeGenCXX/cxx2a-thread-local-constinit.cppclang.src/test/CodeGenCXX/cxx2a-thread-local-constinit.cpp
The file was modified/cfe/trunk/test/CodeGenCXX/tls-init-funcs.cpp (diff)clang.src/test/CodeGenCXX/tls-init-funcs.cpp
The file was added/cfe/trunk/test/CodeGenCXX/windows-on-arm-itanium-thread-local.cppclang.src/test/CodeGenCXX/windows-on-arm-itanium-thread-local.cpp
The file was modified/cfe/trunk/test/OpenMP/parallel_copyin_codegen.cpp (diff)clang.src/test/OpenMP/parallel_copyin_codegen.cpp
Revision 371766 by nickdesaulniers:
[Clang][CodeGen] support alias attribute w/ gnu_inline

Summary:
r369705 did not consider the addition of gnu_inline on function
declarations of alias attributed functions. This resulted in a reported
regression in the clang-9-rc4 release from the Zig developers building
glibc, which was observable as a failed assertion:

llvm-project/clang/lib/AST/Decl.cpp:3336: bool
clang::FunctionDecl::isInlineDefinitionExternallyVisible() const:
Assertion `(doesThisDeclarationHaveABody() || willHaveBody()) && "Must
be a function definition"' failed.

Alias function declarations do not have bodies, so allow us to proceed
if we have the alias function attribute but no body/definition, and add
a test case.  The emitted symbols and their linkage matches GCC for the
added test case.

Link: https://bugs.llvm.org/show_bug.cgi?id=43268

Reviewers: aaron.ballman, rsmith, erichkeane, andrewrk

Reviewed By: andrewrk

Subscribers: cfe-commits, andrewrk, hans, srhines

Tags: #clang

Differential Revision: https://reviews.llvm.org/D67455
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/AST/Decl.cpp (diff)clang.src/lib/AST/Decl.cpp
The file was modified/cfe/trunk/test/CodeGen/alias.c (diff)clang.src/test/CodeGen/alias.c
Revision 371765 by szelethus:
[CFG] Add dumps for CFGElement and CFGElementRef

Seems like we never had these, so here we go! I also did some refactoring as I
was chasing a bug unrelated to this revision.

Differential Revision: https://reviews.llvm.org/D66715
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Analysis/CFG.h (diff)clang.src/include/clang/Analysis/CFG.h
The file was modified/cfe/trunk/lib/Analysis/CFG.cpp (diff)clang.src/lib/Analysis/CFG.cpp
Revision 371764 by dblaikie:
llvm-reduce: For now, mark these tests as requiring a shell

(since they execute shell scripts/that's the only entry point at the
moment)
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Reduce/remove-args.ll (diff)llvm.src/test/Reduce/remove-args.ll
The file was modified/llvm/trunk/test/Reduce/remove-funcs.ll (diff)llvm.src/test/Reduce/remove-funcs.ll
The file was modified/llvm/trunk/test/Reduce/remove-global-vars.ll (diff)llvm.src/test/Reduce/remove-global-vars.ll
The file was modified/llvm/trunk/test/Reduce/remove-metadata.ll (diff)llvm.src/test/Reduce/remove-metadata.ll
Revision 371763 by zoecarver:
[libc++] Mark issue 2587 resolved by issue 2567

Updates status. NFC.
Change TypePath in RepositoryPath in Workspace
The file was modified/libcxx/trunk/www/cxx1z_status.html (diff)libcxx.src/www/cxx1z_status.html