FailedChanges

Summary

  1. InterleavedLoadCombine - merge isa<> and dyn_cast<> duplicates. NFCI. Silence static analyzer null dereference warning of *dyn_cast<BinaryOperator> by merging with the isa<BinaryOperator> above.
  2. [OpenMP] Fix OMPClauseReader::readClause() uninitialized variable warning. NFCI. Fixes static analyzer uninitialized variable warning for the OMPClause - the function appears to cover all cases, but I've added an assertion to make sure.
  3. [DebugInfo] Don't dereference a dyn_cast<PDBSymbolData> result. NFCI. The static analyzer is warning about a potential null dereference - but as we're in DataMemberLayoutItem we should be able to guarantee that the Symbol is a PDBSymbolData type, allowing us to use cast<PDBSymbolData> - and if not assert will fire for us.
Revision 371935 by rksimon:
InterleavedLoadCombine - merge isa<> and dyn_cast<> duplicates. NFCI.

Silence static analyzer null dereference warning of *dyn_cast<BinaryOperator> by merging with the isa<BinaryOperator> above.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/InterleavedLoadCombinePass.cpp (diff)llvm.src/lib/CodeGen/InterleavedLoadCombinePass.cpp
Revision 371934 by rksimon:
[OpenMP] Fix OMPClauseReader::readClause() uninitialized variable warning. NFCI.

Fixes static analyzer uninitialized variable warning for the OMPClause - the function appears to cover all cases, but I've added an assertion to make sure.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Serialization/ASTReader.cpp (diff)clang.src/lib/Serialization/ASTReader.cpp
Revision 371933 by rksimon:
[DebugInfo] Don't dereference a dyn_cast<PDBSymbolData> result. NFCI.

The static analyzer is warning about a potential null dereference - but as we're in DataMemberLayoutItem we should be able to guarantee that the Symbol is a PDBSymbolData type, allowing us to use cast<PDBSymbolData> - and if not assert will fire for us.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/DebugInfo/PDB/UDTLayout.cpp (diff)llvm.src/lib/DebugInfo/PDB/UDTLayout.cpp