FailedChanges

Summary

  1. gn build: Merge r371976
  2. Implement semantic selections. Summary: For a given cursor position, it returns ranges that are interesting to the user. Currently the semantic ranges correspond to the nodes of the syntax trees. Subscribers: mgorny, jkorous, arphaman, kadircet, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D67358
  3. [VPlanSLP] Don't dereference a cast_or_null<VPInstruction> result. NFCI. The static analyzer is warning about a potential null dereference of the cast_or_null result, I've split the cast_or_null check from the ->getUnderlyingInstr() call to avoid this, but it appears that we weren't seeing any null pointers in the dumped bundles in the first place.
  4. [SLPVectorizer] Assert that we find a LastInst to silence analyzer null dereference warning. NFCI.
  5. [SLPVectorizer] Don't dereference a dyn_cast result. NFCI. The static analyzer is warning about potential null dereferences of dyn_cast<> results - in these cases we can safely use cast<> directly as we know that these cases should all be the correct type, which is why its working atm and anyway cast<> will assert if they aren't.
  6. Added return statement to fix compile and build warning: llvm-rtdyld.cpp:966:7: warning: variable ‘Result’ set but not used
  7. [clangd] Fix a crash when renaming operator. Summary: The renamelib uses a tricky way to calculate the end location by relying on decl name, this is incorrect for the overloaded operator (the name is "operator++" instead of "++"), which will cause out-of-file offset. We also disable renaming operator symbol, this case is tricky, and renamelib doesnt handle it properly. Reviewers: ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D67607
Revision 371977 by nico:
gn build: Merge r371976
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/gn/secondary/clang-tools-extra/clangd/BUILD.gn (diff)llvm.src/utils/gn/secondary/clang-tools-extra/clangd/BUILD.gn
The file was modified/llvm/trunk/utils/gn/secondary/clang-tools-extra/clangd/unittests/BUILD.gn (diff)llvm.src/utils/gn/secondary/clang-tools-extra/clangd/unittests/BUILD.gn
Revision 371976 by usaxena95:
Implement semantic selections.

Summary:
For a given cursor position, it returns ranges that are interesting to the user.
Currently the semantic ranges correspond to the nodes of the syntax trees.

Subscribers: mgorny, jkorous, arphaman, kadircet, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D67358
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/CMakeLists.txt (diff)clang-tools-extra.src/clangd/CMakeLists.txt
The file was added/clang-tools-extra/trunk/clangd/SemanticSelection.cppclang-tools-extra.src/clangd/SemanticSelection.cpp
The file was added/clang-tools-extra/trunk/clangd/SemanticSelection.hclang-tools-extra.src/clangd/SemanticSelection.h
The file was modified/clang-tools-extra/trunk/clangd/unittests/CMakeLists.txt (diff)clang-tools-extra.src/clangd/unittests/CMakeLists.txt
The file was added/clang-tools-extra/trunk/clangd/unittests/SemanticSelectionTests.cppclang-tools-extra.src/clangd/unittests/SemanticSelectionTests.cpp
Revision 371975 by rksimon:
[VPlanSLP] Don't dereference a cast_or_null<VPInstruction> result. NFCI.

The static analyzer is warning about a potential null dereference of the cast_or_null result, I've split the cast_or_null check from the ->getUnderlyingInstr() call to avoid this, but it appears that we weren't seeing any null pointers in the dumped bundles in the first place.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Vectorize/VPlanSLP.cpp (diff)llvm.src/lib/Transforms/Vectorize/VPlanSLP.cpp
Revision 371974 by rksimon:
[SLPVectorizer] Assert that we find a LastInst to silence analyzer null dereference warning. NFCI.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp (diff)llvm.src/lib/Transforms/Vectorize/SLPVectorizer.cpp
Revision 371973 by rksimon:
[SLPVectorizer] Don't dereference a dyn_cast result. NFCI.

The static analyzer is warning about potential null dereferences of dyn_cast<> results - in these cases we can safely use cast<> directly as we know that these cases should all be the correct type, which is why its working atm and anyway cast<> will assert if they aren't.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp (diff)llvm.src/lib/Transforms/Vectorize/SLPVectorizer.cpp
Revision 371972 by sjoerdmeijer:
Added return statement to fix compile and build warning:

llvm-rtdyld.cpp:966:7: warning: variable ‘Result’ set but not used
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/tools/llvm-rtdyld/llvm-rtdyld.cpp (diff)llvm.src/tools/llvm-rtdyld/llvm-rtdyld.cpp
Revision 371971 by hokein:
[clangd] Fix a crash when renaming operator.

Summary:
The renamelib uses a tricky way to calculate the end location by relying
on decl name, this is incorrect for the overloaded operator (the name is
"operator++" instead of "++"), which will cause out-of-file offset.

We also disable renaming operator symbol, this case is tricky, and
renamelib doesnt handle it properly.

Reviewers: ilya-biryukov

Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D67607
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Tooling/Refactoring/RecursiveSymbolVisitor.h (diff)clang.src/include/clang/Tooling/Refactoring/RecursiveSymbolVisitor.h
The file was modified/clang-tools-extra/trunk/clangd/refactor/Rename.cpp (diff)clang-tools-extra.src/clangd/refactor/Rename.cpp
The file was modified/clang-tools-extra/trunk/clangd/unittests/RenameTests.cpp (diff)clang-tools-extra.src/clangd/unittests/RenameTests.cpp