FailedChanges

Summary

  1. Open fstream files in O_CLOEXEC mode when possible. Reviewers: EricWF, mclow.lists, ldionne Reviewed By: ldionne Subscribers: smeenai, dexonsmith, christof, ldionne, libcxx-commits Tags: #libc Differential Revision: https://reviews.llvm.org/D59839
  2. do not emit -Wunused-macros warnings in -frewrite-includes mode (PR15614) -frewrite-includes calls PP.SetMacroExpansionOnlyInDirectives() to avoid macro expansions that are useless in that mode, but this can lead to -Wunused-macros false positives. As -frewrite-includes does not emit normal warnings, block -Wunused-macros too. Differential Revision: https://reviews.llvm.org/D65371
  3. [Coverage] Speed up file-based queries for coverage info, NFC Speed up queries for coverage info in a file by reducing the amount of time spent determining whether a function record corresponds to a file. This gives a 36% speedup when generating a coverage report for `llc`. The reduction is entirely in user time. rdar://54758110 Differential Revision: https://reviews.llvm.org/D67575
  4. [Coverage] Assert that filenames in a TU are unique, NFC
Revision 372027 by danalbert:
Open fstream files in O_CLOEXEC mode when possible.

Reviewers: EricWF, mclow.lists, ldionne

Reviewed By: ldionne

Subscribers: smeenai, dexonsmith, christof, ldionne, libcxx-commits

Tags: #libc

Differential Revision: https://reviews.llvm.org/D59839
Change TypePath in RepositoryPath in Workspace
The file was modified/libcxx/trunk/include/__config (diff)libcxx.src/include/__config
The file was modified/libcxx/trunk/include/fstream (diff)libcxx.src/include/fstream
Revision 372026 by llunak:
do not emit -Wunused-macros warnings in -frewrite-includes mode (PR15614)

-frewrite-includes calls PP.SetMacroExpansionOnlyInDirectives() to avoid
macro expansions that are useless in that mode, but this can lead
to -Wunused-macros false positives. As -frewrite-includes does not emit
normal warnings, block -Wunused-macros too.

Differential Revision: https://reviews.llvm.org/D65371
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Lex/PPDirectives.cpp (diff)clang.src/lib/Lex/PPDirectives.cpp
The file was modified/cfe/trunk/test/Frontend/rewrite-includes-warnings.c (diff)clang.src/test/Frontend/rewrite-includes-warnings.c
Revision 372025 by Vedant Kumar:
[Coverage] Speed up file-based queries for coverage info, NFC

Speed up queries for coverage info in a file by reducing the amount of
time spent determining whether a function record corresponds to a file.

This gives a 36% speedup when generating a coverage report for `llc`.
The reduction is entirely in user time.

rdar://54758110

Differential Revision: https://reviews.llvm.org/D67575
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/ProfileData/Coverage/CoverageMapping.h (diff)llvm.src/include/llvm/ProfileData/Coverage/CoverageMapping.h
The file was modified/llvm/trunk/lib/ProfileData/Coverage/CoverageMapping.cpp (diff)llvm.src/lib/ProfileData/Coverage/CoverageMapping.cpp
Revision 372024 by Vedant Kumar:
[Coverage] Assert that filenames in a TU are unique, NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/ProfileData/Coverage/CoverageMappingWriter.h (diff)llvm.src/include/llvm/ProfileData/Coverage/CoverageMappingWriter.h
The file was modified/llvm/trunk/lib/ProfileData/Coverage/CoverageMappingWriter.cpp (diff)llvm.src/lib/ProfileData/Coverage/CoverageMappingWriter.cpp