FailedChanges

Summary

  1. [lit] Make internal diff work in pipelines When using lit's internal shell, RUN lines like the following accidentally execute an external `diff` instead of lit's internal `diff`: ``` # RUN: program | diff file - # RUN: not diff file1 file2 | FileCheck %s ``` Such cases exist now, in `clang/test/Analysis` for example. We are preparing patches to ensure lit's internal `diff` is called in such cases, which will then fail because lit's internal `diff` cannot currently be used in pipelines and doesn't recognize `-` as a command-line option. To enable pipelines, this patch moves lit's `diff` implementation into an out-of-process script, similar to lit's `cat` implementation. A follow-up patch will implement `-` to mean stdin. Reviewed By: probinson, stella.stamenova Differential Revision: https://reviews.llvm.org/D66574
Revision 372035 by jdenny:
[lit] Make internal diff work in pipelines

When using lit's internal shell, RUN lines like the following
accidentally execute an external `diff` instead of lit's internal
`diff`:

```
# RUN: program | diff file -
# RUN: not diff file1 file2 | FileCheck %s
```

Such cases exist now, in `clang/test/Analysis` for example.  We are
preparing patches to ensure lit's internal `diff` is called in such
cases, which will then fail because lit's internal `diff` cannot
currently be used in pipelines and doesn't recognize `-` as a
command-line option.

To enable pipelines, this patch moves lit's `diff` implementation into
an out-of-process script, similar to lit's `cat` implementation.  A
follow-up patch will implement `-` to mean stdin.

Reviewed By: probinson, stella.stamenova

Differential Revision: https://reviews.llvm.org/D66574
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/TestRunner.py (diff)llvm.src/utils/lit/lit/TestRunner.py
The file was added/llvm/trunk/utils/lit/lit/builtin_commands/diff.pyllvm.src/utils/lit/lit/builtin_commands/diff.py
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-error-0.txtllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-error-0.txt
The file was added/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txtllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txt
The file was modified/llvm/trunk/utils/lit/tests/shtest-shell.py (diff)llvm.src/utils/lit/tests/shtest-shell.py