SuccessChanges

Summary

  1. [Analysis] Allow -scalar-evolution-max-iterations more than once At present, `-scalar-evolution-max-iterations` is a `cl::Optional` option, which means it demands to be passed exactly zero or one times. Our build system makes it pretty tricky to guarantee this. We often accidentally pass the flag more than once (but always with the same value) which results in an error, after which compilation fails: ``` clang (LLVM option parsing): for the -scalar-evolution-max-iterations option: may only occur zero or one times! ``` It seems reasonable to allow -scalar-evolution-max-iterations to be passed more than once. Quoting the [[ http://llvm.org/docs/CommandLine.html#controlling-the-number-of-occurrences-required-and-allowed | documentation ]]: > The cl::ZeroOrMore modifier ... indicates that your program will allow the option to be specified zero or more times. > ... > If an option is specified multiple times for an option of the cl::opt class, only the last value will be retained. Original patch by: Enrico Bern Hardy Tanuwidjaja <etanuwid@fb.com> Differential Revision: https://reviews.llvm.org/D67512
  2. [NFC][PowerPC] Fast-isel VSX support test We have fixed most of the VSX limitation in Fast-isel, so we can remove the -mattr=-vsx for most testcases now.
Revision 372346 by smeenai:
[Analysis] Allow -scalar-evolution-max-iterations more than once

At present, `-scalar-evolution-max-iterations` is a `cl::Optional`
option, which means it demands to be passed exactly zero or one times.
Our build system makes it pretty tricky to guarantee this. We often
accidentally pass the flag more than once (but always with the same
value) which results in an error, after which compilation fails:

```
clang (LLVM option parsing): for the -scalar-evolution-max-iterations option: may only occur zero or one times!
```

It seems reasonable to allow -scalar-evolution-max-iterations to be
passed more than once. Quoting the [[ http://llvm.org/docs/CommandLine.html#controlling-the-number-of-occurrences-required-and-allowed | documentation ]]:

> The cl::ZeroOrMore modifier ... indicates that your program will allow the option to be specified zero or more times.
> ...
> If an option is specified multiple times for an option of the cl::opt class, only the last value will be retained.

Original patch by: Enrico Bern Hardy Tanuwidjaja <etanuwid@fb.com>

Differential Revision: https://reviews.llvm.org/D67512
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Analysis/ScalarEvolution.cpp (diff)llvm.src/lib/Analysis/ScalarEvolution.cpp
The file was added/llvm/trunk/test/Analysis/ScalarEvolution/multiple-max-iterations.llllvm.src/test/Analysis/ScalarEvolution/multiple-max-iterations.ll
Revision 372345 by jsji:
[NFC][PowerPC] Fast-isel VSX support test

We have fixed most of the VSX limitation in Fast-isel,
so we can remove the -mattr=-vsx for most testcases now.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/CodeGen/PowerPC/fast-isel-call.ll (diff)llvm.src/test/CodeGen/PowerPC/fast-isel-call.ll
The file was modified/llvm/trunk/test/CodeGen/PowerPC/fast-isel-const.ll (diff)llvm.src/test/CodeGen/PowerPC/fast-isel-const.ll
The file was modified/llvm/trunk/test/CodeGen/PowerPC/fast-isel-load-store.ll (diff)llvm.src/test/CodeGen/PowerPC/fast-isel-load-store.ll
The file was modified/llvm/trunk/test/CodeGen/PowerPC/fast-isel-ret.ll (diff)llvm.src/test/CodeGen/PowerPC/fast-isel-ret.ll