SuccessChanges

Summary

  1. [OPENMP]Call __kmpc_push_tripcount in task context. Runtime function __kmpc_push_tripcount better to call inside of the task context for target regions. Otherwise, the libomptarget is unable to link the provided tripcount value for nowait target regions and completely looses this information.
  2. Added a test for agreement between paths used in ClangTidy's diagnostics and header filter This test would have been broken by r372388.
  3. [x86] fix assert with horizontal math + broadcast of vector (PR43402) https://bugs.llvm.org/show_bug.cgi?id=43402
  4. [libTooling] Add `access` and `ifBound` combinators to Stencil library. Summary: This revision add the `access` and `ifBound` combinators to the Stencil library: * `access` -- constructs an idiomatic expression for accessing a member (a `MemberExpr`). * `ifBound` -- chooses between two `StencilParts` based on the whether an id is bound in the match (corresponds to the combinator of the same name in RangeSelector). Reviewers: gribozavr Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D67633
  5. [ValueTracking] Remove unused matchSelectPattern optional argument. NFCI. The matchSelectPattern const wrapper is never explicitly called with the optional Instruction::CastOps argument, and it turns out that it wasn't being forwarded to matchSelectPattern anyway! Noticed while investigating clang static analyzer warnings.
  6. [ValueTracking] Fix uninitialized variable warnings in matchSelectPattern const wrapper. NFCI. Static analyzer complains about const_cast uninitialized variables, we should explicitly set these to null. Ideally that const wrapper would go away though.......
  7. llvm-undname: Add support for demangling typeinfo names typeinfo names aren't symbols but string constant contents stored in compiler-generated typeinfo objects, but llvm-cxxfilt can demangle these for Itanium names. In the MSVC ABI, these are just a '.' followed by a mangled type -- this means they don't start with '?' like all MS-mangled symbols do. Differential Revision: https://reviews.llvm.org/D67851
  8. Revert "[clang-tidy] Fix relative path in header-filter." This reverts commit r372388. It made '-header-filter' inconsistent with paths printed in diagnostics.
  9. [Diagnostics] Avoid -Wsizeof-array-div when dividing the size of a nested array by the size of the deepest base type
  10. Cosmetic; don't use the magic constant 35 when HASH is more readable. This matches other MCK__<THING>_* usage better. Summary: No functional change. This fixes a magic constant in MCK__*_... macros only. Reviewers: ostannard Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D67840
  11. Function::BuildLazyArguments() - fix "variable used but never read" analyzer warning. NFCI. Simplify the code by separating the masking of the SDC variable from using it.
  12. gn build: Merge r372595
  13. [Alignment][NFC] DataLayout migration to llvm::Align Summary: This is patch is part of a series to introduce an Alignment type. See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html See this patch for the introduction of the type: https://reviews.llvm.org/D64790 Reviewers: courbet Subscribers: jholewinski, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D67914
  14. [libTooling] Introduce new library of source-code builders. Summary: Introduces facilities for easily building source-code strings, including idiomatic use of parentheses and the address-of, dereference and member-access operators (dot and arrow) and queries about need for parentheses. Reviewers: gribozavr Subscribers: mgorny, cfe-commits, ilya-biryukov Tags: #clang Differential Revision: https://reviews.llvm.org/D67632
Revision 372609 by abataev:
[OPENMP]Call __kmpc_push_tripcount in task context.

Runtime function __kmpc_push_tripcount better to call inside of the task
context for target regions. Otherwise, the libomptarget is unable to
link the provided tripcount value for nowait target regions and
completely looses this information.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp (diff)clang.src/lib/CodeGen/CGOpenMPRuntime.cpp
The file was modified/cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h (diff)clang.src/lib/CodeGen/CGOpenMPRuntime.h
The file was modified/cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp (diff)clang.src/lib/CodeGen/CGStmtOpenMP.cpp
The file was modified/cfe/trunk/test/OpenMP/target_teams_distribute_parallel_for_codegen.cpp (diff)clang.src/test/OpenMP/target_teams_distribute_parallel_for_codegen.cpp
The file was modified/cfe/trunk/test/OpenMP/target_teams_distribute_parallel_for_simd_codegen.cpp (diff)clang.src/test/OpenMP/target_teams_distribute_parallel_for_simd_codegen.cpp
The file was modified/cfe/trunk/test/OpenMP/teams_distribute_codegen.cpp (diff)clang.src/test/OpenMP/teams_distribute_codegen.cpp
The file was modified/cfe/trunk/test/OpenMP/teams_distribute_parallel_for_codegen.cpp (diff)clang.src/test/OpenMP/teams_distribute_parallel_for_codegen.cpp
The file was modified/cfe/trunk/test/OpenMP/teams_distribute_parallel_for_simd_codegen.cpp (diff)clang.src/test/OpenMP/teams_distribute_parallel_for_simd_codegen.cpp
The file was modified/cfe/trunk/test/OpenMP/teams_distribute_simd_codegen.cpp (diff)clang.src/test/OpenMP/teams_distribute_simd_codegen.cpp
Revision 372607 by gribozavr:
Added a test for agreement between paths used in ClangTidy's diagnostics and header filter

This test would have been broken by r372388.
Change TypePath in RepositoryPath in Workspace
The file was added/clang-tools-extra/trunk/test/clang-tidy/file-filter-symlinks.cppclang-tools-extra.src/test/clang-tidy/file-filter-symlinks.cpp
Revision 372606 by spatel:
[x86] fix assert with horizontal math + broadcast of vector (PR43402)

https://bugs.llvm.org/show_bug.cgi?id=43402
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (diff)llvm.src/lib/Target/X86/X86ISelLowering.cpp
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.h (diff)llvm.src/lib/Target/X86/X86ISelLowering.h
The file was added/llvm/trunk/test/CodeGen/X86/haddsub-broadcast.llllvm.src/test/CodeGen/X86/haddsub-broadcast.ll
Revision 372605 by ymandel:
[libTooling] Add `access` and `ifBound` combinators to Stencil library.

Summary:
This revision add the `access` and `ifBound` combinators to the Stencil library:
* `access` -- constructs an idiomatic expression for accessing a member (a
  `MemberExpr`).
* `ifBound` -- chooses between two `StencilParts` based on the whether an id is
  bound in the match (corresponds to the combinator of the same name in
  RangeSelector).

Reviewers: gribozavr

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D67633
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Tooling/Refactoring/Stencil.h (diff)clang.src/include/clang/Tooling/Refactoring/Stencil.h
The file was modified/cfe/trunk/lib/Tooling/Refactoring/Stencil.cpp (diff)clang.src/lib/Tooling/Refactoring/Stencil.cpp
The file was modified/cfe/trunk/unittests/Tooling/StencilTest.cpp (diff)clang.src/unittests/Tooling/StencilTest.cpp
Revision 372604 by rksimon:
[ValueTracking] Remove unused matchSelectPattern optional argument. NFCI.

The matchSelectPattern const wrapper is never explicitly called with the optional Instruction::CastOps argument, and it turns out that it wasn't being forwarded to matchSelectPattern anyway!

Noticed while investigating clang static analyzer warnings.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Analysis/ValueTracking.h (diff)llvm.src/include/llvm/Analysis/ValueTracking.h
Revision 372603 by rksimon:
[ValueTracking] Fix uninitialized variable warnings in matchSelectPattern const wrapper. NFCI.

Static analyzer complains about const_cast uninitialized variables, we should explicitly set these to null.

Ideally that const wrapper would go away though.......
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Analysis/ValueTracking.cpp (diff)llvm.src/lib/Analysis/ValueTracking.cpp
Revision 372602 by nico:
llvm-undname: Add support for demangling typeinfo names

typeinfo names aren't symbols but string constant contents
stored in compiler-generated typeinfo objects, but llvm-cxxfilt
can demangle these for Itanium names.

In the MSVC ABI, these are just a '.' followed by a mangled
type -- this means they don't start with '?' like all MS-mangled
symbols do.

Differential Revision: https://reviews.llvm.org/D67851
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Demangle/MicrosoftDemangle.h (diff)llvm.src/include/llvm/Demangle/MicrosoftDemangle.h
The file was modified/llvm/trunk/lib/Demangle/MicrosoftDemangle.cpp (diff)llvm.src/lib/Demangle/MicrosoftDemangle.cpp
The file was modified/llvm/trunk/test/Demangle/invalid-manglings.test (diff)llvm.src/test/Demangle/invalid-manglings.test
The file was modified/llvm/trunk/test/Demangle/ms-operators.test (diff)llvm.src/test/Demangle/ms-operators.test
Revision 372601 by gribozavr:
Revert "[clang-tidy] Fix relative path in header-filter."

This reverts commit r372388. It made '-header-filter' inconsistent with
paths printed in diagnostics.
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp (diff)clang-tools-extra.src/clang-tidy/ClangTidyDiagnosticConsumer.cpp
The file was removed/clang-tools-extra/trunk/test/clang-tidy/Inputs/file-filter/subfolder_aclang-tools-extra.src/test/clang-tidy/Inputs/file-filter/subfolder_a
The file was removed/clang-tools-extra/trunk/test/clang-tidy/Inputs/file-filter/subfolder_bclang-tools-extra.src/test/clang-tidy/Inputs/file-filter/subfolder_b
The file was removed/clang-tools-extra/trunk/test/clang-tidy/Inputs/file-filter/subfolder_cclang-tools-extra.src/test/clang-tidy/Inputs/file-filter/subfolder_c
The file was modified/clang-tools-extra/trunk/test/clang-tidy/file-filter.cpp (diff)clang-tools-extra.src/test/clang-tidy/file-filter.cpp
Revision 372600 by xbolva00:
[Diagnostics] Avoid -Wsizeof-array-div when dividing the size of a nested array by the size of the deepest base type
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Sema/SemaExpr.cpp (diff)clang.src/lib/Sema/SemaExpr.cpp
The file was modified/cfe/trunk/test/Sema/div-sizeof-array.cpp (diff)clang.src/test/Sema/div-sizeof-array.cpp
Revision 372599 by markrvmurray:
Cosmetic; don't use the magic constant 35 when HASH is more readable. This matches other MCK__<THING>_* usage better.

Summary: No functional change. This fixes a magic constant in MCK__*_... macros only.

Reviewers: ostannard

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D67840
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp (diff)llvm.src/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
The file was modified/llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp (diff)llvm.src/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
The file was modified/llvm/trunk/utils/TableGen/AsmMatcherEmitter.cpp (diff)llvm.src/utils/TableGen/AsmMatcherEmitter.cpp
Revision 372598 by rksimon:
Function::BuildLazyArguments() - fix "variable used but never read" analyzer warning. NFCI.

Simplify the code by separating the masking of the SDC variable from using it.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/IR/Function.cpp (diff)llvm.src/lib/IR/Function.cpp
Revision 372597 by gnsyncbot:
gn build: Merge r372595
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/gn/secondary/clang/lib/Tooling/Refactoring/BUILD.gn (diff)llvm.src/utils/gn/secondary/clang/lib/Tooling/Refactoring/BUILD.gn
The file was modified/llvm/trunk/utils/gn/secondary/clang/unittests/Tooling/BUILD.gn (diff)llvm.src/utils/gn/secondary/clang/unittests/Tooling/BUILD.gn
Revision 372596 by gchatelet:
[Alignment][NFC] DataLayout migration to llvm::Align

Summary:
This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790

Reviewers: courbet

Subscribers: jholewinski, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D67914
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/IR/DataLayout.h (diff)llvm.src/include/llvm/IR/DataLayout.h
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp (diff)llvm.src/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
The file was modified/llvm/trunk/lib/CodeGen/GlobalISel/IRTranslator.cpp (diff)llvm.src/lib/CodeGen/GlobalISel/IRTranslator.cpp
The file was modified/llvm/trunk/lib/CodeGen/MachineFunction.cpp (diff)llvm.src/lib/CodeGen/MachineFunction.cpp
The file was modified/llvm/trunk/lib/CodeGen/TargetLoweringObjectFileImpl.cpp (diff)llvm.src/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
The file was modified/llvm/trunk/lib/IR/DataLayout.cpp (diff)llvm.src/lib/IR/DataLayout.cpp
The file was modified/llvm/trunk/lib/Target/NVPTX/NVPTXAsmPrinter.cpp (diff)llvm.src/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
Revision 372595 by ymandel:
[libTooling] Introduce new library of source-code builders.

Summary:
Introduces facilities for easily building source-code strings, including
idiomatic use of parentheses and the address-of, dereference and member-access
operators (dot and arrow) and queries about need for parentheses.

Reviewers: gribozavr

Subscribers: mgorny, cfe-commits, ilya-biryukov

Tags: #clang

Differential Revision: https://reviews.llvm.org/D67632
Change TypePath in RepositoryPath in Workspace
The file was added/cfe/trunk/include/clang/Tooling/Refactoring/SourceCodeBuilders.hclang.src/include/clang/Tooling/Refactoring/SourceCodeBuilders.h
The file was modified/cfe/trunk/lib/Tooling/Refactoring/CMakeLists.txt (diff)clang.src/lib/Tooling/Refactoring/CMakeLists.txt
The file was added/cfe/trunk/lib/Tooling/Refactoring/SourceCodeBuilders.cppclang.src/lib/Tooling/Refactoring/SourceCodeBuilders.cpp
The file was modified/cfe/trunk/unittests/Tooling/CMakeLists.txt (diff)clang.src/unittests/Tooling/CMakeLists.txt
The file was added/cfe/trunk/unittests/Tooling/SourceCodeBuildersTest.cppclang.src/unittests/Tooling/SourceCodeBuildersTest.cpp