Changes

[SimplifyLibCalls] fix crash with empty function name (PR43347)
...and improve some variable names while here.
https://bugs.llvm.org/show_bug.cgi?id=43347
llvm-svn: 372227

Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize"
Summary: This reverts commit r372204.
This change causes build bot failures under msan: 
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/35236/steps/check-llvm%20msan/logs/stdio:
``` FAIL: LLVM :: DebugInfo/AArch64/asan-stack-vars.mir (19531 of 33579)
******************** TEST 'LLVM ::
DebugInfo/AArch64/asan-stack-vars.mir' FAILED ******************** 
Script:
--
: 'RUN: at line 1';  
/b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/llc -O0
-start-before=livedebugvalues -filetype=obj -o -
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/DebugInfo/AArch64/asan-stack-vars.mir
|
/b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/llvm-dwarfdump
-v - |
/b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/FileCheck
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/DebugInfo/AArch64/asan-stack-vars.mir
-- Exit Code: 2
Command Output (stderr):
--
==62894==WARNING: MemorySanitizer: use-of-uninitialized-value
   #0 0xdfcafb in
llvm::AArch64FrameLowering::resolveFrameOffsetReference(llvm::MachineFunction
const&, int, bool, unsigned int&, bool, bool) const
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1658:3
   #1 0xdfae8a in resolveFrameIndexReference
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1580:10
   #2 0xdfae8a in
llvm::AArch64FrameLowering::getFrameIndexReference(llvm::MachineFunction
const&, int, unsigned int&) const
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1536
   #3 0x46642c1 in (anonymous
namespace)::LiveDebugValues::extractSpillBaseRegAndOffset(llvm::MachineInstr
const&)
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/LiveDebugValues.cpp:582:21
   #4 0x4647cb3 in transferSpillOrRestoreInst
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/LiveDebugValues.cpp:883:11
   #5 0x4647cb3 in process
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/LiveDebugValues.cpp:1079
   #6 0x4647cb3 in (anonymous
namespace)::LiveDebugValues::ExtendRanges(llvm::MachineFunction&)
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/LiveDebugValues.cpp:1361
   #7 0x463ac0e in (anonymous
namespace)::LiveDebugValues::runOnMachineFunction(llvm::MachineFunction&)
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/LiveDebugValues.cpp:1415:18
   #8 0x4854ef0 in
llvm::MachineFunctionPass::runOnFunction(llvm::Function&)
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/MachineFunctionPass.cpp:73:13
   #9 0x53b0b01 in llvm::FPPassManager::runOnFunction(llvm::Function&)
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1648:27
   #10 0x53b15f6 in llvm::FPPassManager::runOnModule(llvm::Module&)
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1685:16
   #11 0x53b298d in runOnModule
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1750:27
   #12 0x53b298d in llvm::legacy::PassManagerImpl::run(llvm::Module&)
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1863
   #13 0x905f21 in compileModule(char**, llvm::LLVMContext&)
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/tools/llc/llc.cpp:601:8
   #14 0x8fdc4e in main
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/tools/llc/llc.cpp:355:22
   #15 0x7f67673632e0 in __libc_start_main
(/lib/x86_64-linux-gnu/libc.so.6+0x202e0)
   #16 0x882369 in _start
(/b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/llc+0x882369)
MemorySanitizer: use-of-uninitialized-value
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1658:3
in
llvm::AArch64FrameLowering::resolveFrameOffsetReference(llvm::MachineFunction
const&, int, bool, unsigned int&, bool, bool) const Exiting error: -:
The file was not recognized as a valid object file FileCheck error: '-'
is empty. FileCheck command line: 
/b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/FileCheck
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/DebugInfo/AArch64/asan-stack-vars.mir
```
Reviewers: bkramer
Reviewed By: bkramer
Subscribers: sdardis, aprantl, kristof.beyls, jrtc27, atanasyan,
llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67710
llvm-svn: 372228

Recommit -r372180
Commit message below, original caused the sphinx build bot to fail, this 
one should fix it.
Create UsersManual section entitled 'Controlling Floating Point 
Behavior'
Create a new section for documenting the floating point options. Move 
all the floating point options into this section, and add new entries 
for the floating point options that exist but weren't previously 
described in the UsersManual.
Patch By: mibintc Differential Revision: https://reviews.llvm.org/D67517
llvm-svn: 372229

[Alignment][NFC] Use Align::None instead of 1
Summary: This is patch is part of a series to introduce an Alignment
type. See this thread for context:
http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html See this
patch for the introduction of the type: https://reviews.llvm.org/D64790
Reviewers: courbet
Subscribers: sdardis, nemanjai, hiraditya, kbarton, jrtc27, MaskRay,
atanasyan, jsji, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67704
llvm-svn: 372230

[Alignment][NFC] Remove LogAlignment functions
Summary: This is patch is part of a series to introduce an Alignment
type. See this thread for context:
http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html See this
patch for the introduction of the type: https://reviews.llvm.org/D64790
Reviewers: courbet
Subscribers: arsenm, sdardis, nemanjai, jvesely, nhaehnle, hiraditya,
kbarton, jrtc27, MaskRay, atanasyan, jsji, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67620
llvm-svn: 372231

[SampleFDO] Minimize performance impact when profile-sample-accurate is
enabled.
We can save memory and reduce binary size significantly by enabling 
ProfileSampleAccurate. However when ProfileSampleAccurate is true, 
function without sample will be regarded as cold and this could 
potentially cause performance regression.
To minimize the potential negative performance impact, we want to be a
little conservative here saying if a function shows up in the profile, 
no matter as outline instance, inline instance or call targets, treat 
the function as not being cold. This will handle the cases such as most 
callsites of a function are inlined in sampled binary (thus outline copy 
don't get any sample) but not inlined in current build (because of
source code drift, imprecise debug information, or the callsites are all
cold individually but not cold accumulatively...), so that the outline
function showing up as cold in sampled binary will actually not be cold
after current build. After the change, such function will be treated as
not cold even profile-sample-accurate is enabled.
At the same time we lower the hot criteria of callsiteIsHot check when 
profile-sample-accurate is enabled. callsiteIsHot is used to determined 
whether a callsite is hot and qualified for early inlining. When 
profile-sample-accurate is enabled, functions without profile will be 
regarded as cold and much less inlining will happen in CGSCC inlining
pass, so we can worry less about size increase and be aggressive to
allow more early inlining to happen for warm callsites and it is helpful
for performance overall.
Differential Revision: https://reviews.llvm.org/D67561
llvm-svn: 372232

unwind: remove a could of extraneous `else` (NFC)
Simplify `if return else return` by removing the unnecessary `else`.
llvm-svn: 372233

[Alignment][NFC] Align(1) to Align::None() conversions
Summary: This is patch is part of a series to introduce an Alignment
type. See this thread for context:
http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html See this
patch for the introduction of the type: https://reviews.llvm.org/D64790
Reviewers: courbet
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67715
llvm-svn: 372234