FailedChanges

Summary

  1. [llvm-exegesis][NFC] Remove extra `llvm::` qualifications. (details)
  2. [ARM] Add saturating arithmetic tests for MVE. NFC (details)
  3. [CostModel][X86] Add tests for extractelement from non-immediate vector (details)
  4. [CostModel][X86] Add tests for insertelement to non-immediate vector (details)
  5. [llvm-exegesis] Fix r374158 (details)
  6. [clangd] Propagate context into reply handlers (details)
  7. [mips] Split expandLoadImmReal into multiple methods. NFC (details)
  8. [mips] Rename local variable. NFC (details)
  9. [LV] Emitting SCEV checks with OptForSize (details)
  10. [clang-offload-bundler] Support `.cui` and `.d`. (details)
  11. [clangd] Make sure ReplyCallbacks are destroyed before (details)
  12. Add and adjust saturating tests. NFC (details)
  13. [llvm-exegesis] Ensure that ExecutableFunction are aligned. (details)
  14. Fix Wdocumentation unknown parameter warning. NFCI. (details)
  15. [clang-format] Update noexcept reference qualifiers detection (details)
  16. [scudo][standalone] Get statistics in a char buffer (details)
  17. [NFC] Test commit. Testing llvm commit access only. (details)
  18. [NFC] Reverting changes from test commit. llvm commit access test (details)
Commit 50cdd56beb8a260870517f58d2e68f87dfb1e8bd by courbet
[llvm-exegesis][NFC] Remove extra `llvm::` qualifications.
Summary: Second patch: in the lib.
Reviewers: gchatelet
Subscribers: nemanjai, tschuett, MaskRay, mgrang, jsji, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D68692
llvm-svn: 374158
The file was modifiedllvm/tools/llvm-exegesis/lib/RegisterValue.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/LlvmState.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/RegisterAliasing.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/MCInstrDescView.h
The file was modifiedllvm/tools/llvm-exegesis/lib/PowerPC/Target.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/Uops.h
The file was modifiedllvm/tools/llvm-exegesis/lib/Analysis.h
The file was modifiedllvm/tools/llvm-exegesis/lib/BenchmarkRunner.h
The file was modifiedllvm/tools/llvm-exegesis/lib/Clustering.h
The file was modifiedllvm/tools/llvm-exegesis/lib/PerfHelper.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/SchedClassResolution.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/Target.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/Analysis.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/RegisterAliasing.h
The file was modifiedllvm/tools/llvm-exegesis/lib/CodeTemplate.h
The file was modifiedllvm/tools/llvm-exegesis/llvm-exegesis.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/Assembler.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/CodeTemplate.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/Target.h
The file was modifiedllvm/tools/llvm-exegesis/lib/Latency.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/RegisterValue.h
The file was modifiedllvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/LlvmState.h
The file was modifiedllvm/tools/llvm-exegesis/lib/Assembler.h
The file was modifiedllvm/tools/llvm-exegesis/lib/MCInstrDescView.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/SnippetRepetitor.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/PerfHelper.h
The file was modifiedllvm/tools/llvm-exegesis/lib/Uops.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/AArch64/Target.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/X86/Target.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/BenchmarkResult.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/SnippetGenerator.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/Latency.h
The file was modifiedllvm/tools/llvm-exegesis/lib/SchedClassResolution.h
The file was modifiedllvm/tools/llvm-exegesis/lib/Clustering.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/SnippetGenerator.h
The file was modifiedllvm/tools/llvm-exegesis/lib/BenchmarkResult.h
Commit e2c72929c882766e295f5238846e1e5905419f7a by david.green
[ARM] Add saturating arithmetic tests for MVE. NFC
llvm-svn: 374159
The file was addedllvm/test/CodeGen/Thumb2/mve-saturating-arith.ll
Commit a21176ffb1dbe0f716168af909fc96245ab7079c by llvm-dev
[CostModel][X86] Add tests for extractelement from non-immediate vector
element indices
llvm-svn: 374160
The file was modifiedllvm/test/Analysis/CostModel/X86/vector-extract.ll
Commit d7ac2553257fd16341183d55f9f84711815aa7a3 by llvm-dev
[CostModel][X86] Add tests for insertelement to non-immediate vector
element indices
llvm-svn: 374161
The file was modifiedllvm/test/Analysis/CostModel/X86/vector-insert.ll
Commit 64a83bb25335a8fd1d8de22f2895531f34570498 by courbet
[llvm-exegesis] Fix r374158
Some bots complain about missing 'class':
LlvmState.h:70:40: error: declaration of ‘std::unique_ptr<const
llvm::TargetMachine> llvm::exegesis::LLVMState::TargetMachine’
[-fpermissive]
  std::unique_ptr<const TargetMachine> TargetMachine;
llvm-svn: 374162
The file was modifiedllvm/tools/llvm-exegesis/lib/LlvmState.h
The file was modifiedllvm/tools/llvm-exegesis/lib/LlvmState.cpp
Commit 1bb91093e7c372293d7a0bf78e0423ddf5b1747c by kadircet
[clangd] Propagate context into reply handlers
llvm-svn: 374163
The file was modifiedclang-tools-extra/clangd/ClangdLSPServer.h
Commit 83c8853fb373f037dd86708fa6ffd1db201d4df4 by simon
[mips] Split expandLoadImmReal into multiple methods. NFC
The `expandLoadImmReal` handles four different and almost
non-overlapping cases: loading a "single" float immediate into a GPR,
loading a "single" float immediate into a FPR, and the same couple for a
"double" float immediate.
It's better to move each `else if` branch into separate methods.
llvm-svn: 374164
The file was modifiedllvm/lib/Target/Mips/AsmParser/MipsAsmParser.cpp
Commit dde0fe5db528a1dd4cfaab9295741ae99a69d62a by simon
[mips] Rename local variable. NFC
llvm-svn: 374165
The file was modifiedllvm/lib/Target/Mips/AsmParser/MipsAsmParser.cpp
Commit d1170dbe58314fe78cfff36ca8259c35b508b7e4 by sjoerd.meijer
[LV] Emitting SCEV checks with OptForSize
When optimising for size and SCEV runtime checks need to be emitted to
check overflow behaviour, the loop vectorizer can run in this assert:
  LoopVectorize.cpp:2699: void
llvm::InnerLoopVectorizer::emitSCEVChecks(
llvm::Loop *, llvm::BasicBlock *): Assertion
`!BB->getParent()->hasOptSize()
&& "Cannot SCEV check stride or overflow when opt
We should not generate predicates while optimising for size because code
will be generated for predicates such as these SCEV overflow runtime
checks.
This should fix PR43371.
Differential Revision: https://reviews.llvm.org/D68082
llvm-svn: 374166
The file was modifiedllvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp
The file was modifiedllvm/test/Transforms/LoopVectorize/optsize.ll
Commit 2ae54aba03f24bf5047bd0fc4552c4bd7a09a39a by michael.hliao
[clang-offload-bundler] Support `.cui` and `.d`.
Reviewers: tra, yaxunl
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D68663
llvm-svn: 374167
The file was modifiedclang/tools/clang-offload-bundler/ClangOffloadBundler.cpp
Commit 9a3a87d189753b7cea14d109c012ba37671e4adf by kadircet
[clangd] Make sure ReplyCallbacks are destroyed before
RequestCancelersMutex
Summary: After rL374163, replycallbacks might have a cancellable
context, which will try to access RequestCancellers on destruction. See
http://45.33.8.238/mac/1245/step_7.txt for a sample failure.
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95,
cfe-commits, thakis
Tags: #clang
Differential Revision: https://reviews.llvm.org/D68702
llvm-svn: 374168
The file was modifiedclang-tools-extra/clangd/ClangdLSPServer.cpp
Commit fcc9c4627e93f491c2a488af1f20551b9d156b18 by david.green
Add and adjust saturating tests. NFC
This adds some extra testing to the existing [su][add/sub]_sat X86 and
AArch64 tests and adds equivalent tests for ARM.
llvm-svn: 374169
The file was modifiedllvm/test/CodeGen/X86/uadd_sat.ll
The file was modifiedllvm/test/CodeGen/X86/usub_sat.ll
The file was modifiedllvm/test/CodeGen/AArch64/usub_sat.ll
The file was modifiedllvm/test/CodeGen/X86/sadd_sat.ll
The file was modifiedllvm/test/CodeGen/AArch64/ssub_sat.ll
The file was addedllvm/test/CodeGen/ARM/usub_sat.ll
The file was modifiedllvm/test/CodeGen/AArch64/sadd_sat.ll
The file was addedllvm/test/CodeGen/ARM/uadd_sat.ll
The file was modifiedllvm/test/CodeGen/AArch64/uadd_sat.ll
The file was addedllvm/test/CodeGen/ARM/sadd_sat.ll
The file was modifiedllvm/test/CodeGen/X86/ssub_sat.ll
The file was addedllvm/test/CodeGen/ARM/ssub_sat.ll
Commit 04a9a0eb0dd459ee209d001eaaaf6c9a73b76869 by courbet
[llvm-exegesis] Ensure that ExecutableFunction are aligned.
Summary: Experiments show that this is the alignment we get (for
ELF+Linux), but let's ensure that we have it.
Reviewers: gchatelet
Subscribers: tschuett, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D68703
llvm-svn: 374170
The file was modifiedllvm/tools/llvm-exegesis/lib/Assembler.cpp
Commit 604b7c22beb48edb29c605d9c3e75a7d2d1b3c2a by llvm-dev
Fix Wdocumentation unknown parameter warning. NFCI.
llvm-svn: 374171
The file was modifiedllvm/include/llvm-c/DebugInfo.h
Commit ae1b7859cbd61d2284d9690bc53482d0b6a46f63 by krasimir
[clang-format] Update noexcept reference qualifiers detection
Summary: r373165 fixed an issue where a templated noexcept member
function with a reference qualifier would be indented more than
expected:
```
// Formatting produced with LLVM style with
AlwaysBreakTemplateDeclarations: Yes
// before r373165: struct f {
template <class T>
     void bar() && noexcept {}
};
// after: struct f {
template <class T>
void bar() && noexcept {}
};
``` The way this is done is that in the AnnotatingParser in
`lib/FormatTokenAnnotator.cpp` the determination of the usage of a `&`
or `&&`
(the line in determineTokenType
``` Current.Type = determineStarAmpUsage(...
``` is not performed in some cases anymore, combining with a few
additional related checks afterwards. The net effect of these checks
results in the `&` or `&&` token to start being classified as
`TT_Unknown` in cases where before `r373165` it would be classified as
`TT_UnaryOperator` or `TT_PointerOrReference` by
`determineStarAmpUsage`.
This inadvertently caused 2 classes of regressions I'm aware of:
- The address-of `&` after a function assignment would be classified as
`TT_Unknown`, causing spaces to surround it, disregarding style
options:
```
// before r373165: void (*fun_ptr)(void) = &fun;
// after: void (*fun_ptr)(void) = & fun;
```
- In cases where there is a function declaration list -- looking macro
between
a template line and the start of the function declaration, an `&` as
part of
the return type would be classified as `TT_Unknown`, causing spaces to
surround it:
```
// before r373165: template <class T> DEPRECATED("lala") Type& foo();
// after: template <class T> DEPRECATED("lala") Type & foo();
```
In these cases the problems are rooted in the skipping of the
classification of a `&` (and similarly `&&`) by determineStarAmpUsage
which effects the formatting decisions later in the pipeline.
I've looked into the goal of r373165 and noticed that replacing
`noexcept` with
`const` in the given example produces no extra indentation with the old
code:
```
// before r373165: struct f {
template <class T>
int foo() & const {}
};
struct f {
template <class T>
     int foo() & noexcept {}
};
```
I investigated how clang-format annotated these two examples differently
to determine the places where the processing of both diverges in the
pipeline. There were two places where the processing diverges, causing
the extra indent in the `noexcept` case: 1. The `const` is annotated as
a `TT_TrailingAnnotation`, whereas `noexcept`
  is annotated as `TT_Unknown`. I've updated the `determineTokenType`
function
  to account for this by adding a missing `tok:kw_noexcept` to the
clause that
  marks a token as `TT_TrailingAnnotation`. 2. The `&` in the second
example is wrongly identified as `TT_BinaryOperator`
  in `determineStarAmpUsage`. This is the reason for the extra
indentation --
  clang-format gets confused and thinks this is an expression.
  I've updated `determineStarAmpUsage` to check for `tok:kw_noexcept`.
With these two updates in place, the additional parsing introduced by
r373165 becomes unnecessary and all added tests pass (with updates, as
now clang-format respects the style configuration for spaces around the
`&` in the test examples). I've removed these additions and added
regression tests for the cases above.
Reviewers: AndWass, MyDeveloperDay
Reviewed By: MyDeveloperDay
Subscribers: cfe-commits
Tags: #clang, #clang-format
Differential Revision: https://reviews.llvm.org/D68695
llvm-svn: 374172
The file was modifiedclang/lib/Format/TokenAnnotator.cpp
The file was modifiedclang/unittests/Format/FormatTest.cpp
Commit f7b1489ffc5106aff3135b3ed664c99cf9a57481 by kostyak
[scudo][standalone] Get statistics in a char buffer
Summary: Following up on D68471, this CL introduces some `getStats` APIs
to gather statistics in char buffers (`ScopedString` really) instead of
printing them out right away. Ultimately `printStats` will just output
the buffer, but that allows us to potentially do some work on the
intermediate buffer, and can be used for a `mallocz` type of
functionality. This allows us to pretty much get rid of all the
`Printf` calls around, but I am keeping the function in for debugging
purposes.
This changes the existing tests to use the new APIs when required.
I will add new tests as suggested in D68471 in another CL.
Reviewers: morehouse, hctim, vitalybuka, eugenis, cferris
Reviewed By: morehouse
Subscribers: delcypher, #sanitizers, llvm-commits
Tags: #llvm, #sanitizers
Differential Revision: https://reviews.llvm.org/D68653
llvm-svn: 374173
The file was modifiedcompiler-rt/lib/scudo/standalone/size_class_map.h
The file was modifiedcompiler-rt/lib/scudo/standalone/tests/secondary_test.cpp
The file was modifiedcompiler-rt/lib/scudo/standalone/crc32_hw.cpp
The file was modifiedcompiler-rt/lib/scudo/standalone/quarantine.h
The file was modifiedcompiler-rt/lib/scudo/standalone/tests/primary_test.cpp
The file was modifiedcompiler-rt/lib/scudo/standalone/tests/quarantine_test.cpp
The file was modifiedcompiler-rt/lib/scudo/standalone/string_utils.cpp
The file was modifiedcompiler-rt/lib/scudo/standalone/combined.h
The file was modifiedcompiler-rt/lib/scudo/standalone/secondary.h
The file was modifiedcompiler-rt/lib/scudo/standalone/primary64.h
The file was modifiedcompiler-rt/lib/scudo/standalone/secondary.cpp
The file was modifiedcompiler-rt/lib/scudo/standalone/string_utils.h
The file was modifiedcompiler-rt/lib/scudo/standalone/primary32.h
The file was modifiedcompiler-rt/lib/scudo/standalone/tests/combined_test.cpp
Commit 791b0e416016c9ebedd4b0cd95f8aca3a0208689 by mitchell
[NFC] Test commit. Testing llvm commit access only.
llvm-svn: 374174
The file was modifiedclang/docs/ClangFormatStyleOptions.rst
Commit 77c9736ef3e0c95e1dbe5c85ad3c1061ce072b50 by mitchell
[NFC] Reverting changes from test commit. llvm commit access test
succeeded.
llvm-svn: 374175
The file was modifiedclang/docs/ClangFormatStyleOptions.rst

Summary

  1. [test-suite] Add Architecture Detection for RISC-V Summary: The LLVM test suite has its own way of detecting the system architecture. This adds support in that file for detecting RISC-V. This will eventually cause the ARCH variable to be populated. We use ARCH="riscv64" to identify 64-bit RISC-V, and ARCH="riscv32" to identify 32-bit RISC-V, so that attempting to detect "riscv" in the ARCH variable will match any version of RISC-V. Reviewers: asb, luismarques Reviewed By: luismarques Subscribers: mgorny, simoncook, kito-cheng, shiva0217, rogfer01, rkruppe, PkmX, s.egerton, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D68698
Revision 374176 by lenary:
[test-suite] Add Architecture Detection for RISC-V

Summary:
The LLVM test suite has its own way of detecting the system
architecture. This adds support in that file for detecting RISC-V.

This will eventually cause the ARCH variable to be populated.

We use ARCH="riscv64" to identify 64-bit RISC-V, and ARCH="riscv32" to identify 32-bit
RISC-V, so that attempting to detect "riscv" in the ARCH variable will match any version of RISC-V.

Reviewers: asb, luismarques

Reviewed By: luismarques

Subscribers: mgorny, simoncook, kito-cheng, shiva0217, rogfer01, rkruppe, PkmX, s.egerton, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D68698
Change TypePath in RepositoryPath in Workspace
The file was modified/test-suite/trunk/cmake/modules/DetectArchitecture.ccmake/modules/DetectArchitecture.c