FailedChanges

Summary

  1. AMDGPU: Fix clang side null pointer value for private (details)
  2. [lldb] Handle a new clang built-in type (details)
  3. Remove a comment-out llvm::errs debugging code, NFC. (details)
  4. AMDGPU: Fix not using scalar loads for global reads in shaders (details)
  5. [AST][RecoveryExpr] Build RecoveryExpr for "undef_var" cases. (details)
  6. Use Pseudo Instruction to carry stack probing information (details)
  7. [yaml2obj] - Allocate the file space for SHT_NOBITS sections in some cases. (details)
  8. Renamed Lang_C to Lang_C99, Lang_CXX to Lang_CXX03, and 2a to 20 (details)
  9. [OPENMP50]Initial codegen for 'affinity' clauses. (details)
  10. Reinstate the syntax tree test for 'static' in an array subscript (details)
  11. [Dexter] Add os.path.normcase(...) transform to test path early. (details)
  12. [Dexter] Add DexLimitSteps command and ConditionalController (details)
  13. [flang] Fix release build flags. (details)
Commit 301a6da8c24a09052e3bda10e90b450b7b39ffea by Matthew.Arsenault
AMDGPU: Fix clang side null pointer value for private

The change to fold_priv_arith looks strange to me, but this was
already the untested behavior for local.
The file was modifiedclang/lib/Basic/Targets/AMDGPU.h
The file was modifiedclang/test/CodeGenOpenCL/amdgpu-nullptr.cl
Commit df06f4ff227bdcbbad01b418199876761f2a1ff0 by kadircet
[lldb] Handle a new clang built-in type
The file was modifiedlldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
Commit e16a4efdc6f429eabfb47ef90d40fcb6b6e362ad by hokein.wu
Remove a comment-out llvm::errs debugging code, NFC.
The file was modifiedclang/lib/AST/Stmt.cpp
Commit 85117e286db0bfa6c7cecadd2c0c348e3358f450 by Matthew.Arsenault
AMDGPU: Fix not using scalar loads for global reads in shaders

The pass which infers when it's legal to load a global address space
as SMRD was only considering amdgpu_kernel, and ignoring the shader
entry type calling conventions.
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPUAnnotateUniformValues.cpp
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/mubuf-global.ll
The file was addedllvm/test/CodeGen/AMDGPU/infer-uniform-load-shader.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/global-saddr.ll
Commit 21ccc684ff4c8563e7b20bed4ae7dc7d18fe03f3 by hokein.wu
[AST][RecoveryExpr] Build RecoveryExpr for "undef_var" cases.

Summary:
For a none-function-like unresolved expression, clang builds a TypoExpr
for it, and tries to correct it afterwards. If the typo-correction
fails, clang just drops the whole expr.

This patch improves the recovery strategy -- if the typo-correction
fails, we preserve the AST by degrading the typo exprs to recovery
exprs.

This would improve toolings for "undef_var" broken cases:
```
void foo();
void test() {
  fo^o(undef_var); // go-to-def, hover still works.
}
```

TESTED=ran tests with this patch + turn-on-recovery-ast patch, it breaks
one declare_variant_messages testcase (the diagnostics are slightly
changed), I think it is acceptable.

```
Error: 'error' diagnostics seen but not expected:
  File llvm-project/clang/test/OpenMP/declare_variant_messages.cpp Line 16: expected 'match' clause on 'omp declare variant' directive
  File llvm-project/clang/test/OpenMP/declare_variant_messages.cpp Line 57: expected 'match' clause on 'omp declare variant' directive
error: 'warning' diagnostics expected but not seen:
  File llvm-project/clang/test/OpenMP/declare_variant_messages.cpp Line 47: the context selector 'kind' in the context set 'device' cannot have a score ('<invalid>'); score ignored
  File llvm-project/clang/test/OpenMP/declare_variant_messages.cpp Line 87: the context selector 'kind' in the context set 'device' cannot have a score ('<invalid>'); score ignored
error: 'warning' diagnostics seen but not expected:
  File llvm-project/clang/test/OpenMP/declare_variant_messages.cpp Line 47: the context selector 'kind' in the context set 'device' cannot have a score ('<recovery-expr>()'); score ignored
  File llvm-project/clang/test/OpenMP/declare_variant_messages.cpp Line 87: the context selector 'kind' in the context set 'device' cannot have a score ('<recovery-expr>()'); score ignored
6 errors generated.
```

Reviewers: sammccall, jdoerfert

Subscribers: sstefan1, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D80733
The file was modifiedclang/lib/Sema/SemaExprCXX.cpp
The file was modifiedclang/test/AST/ast-dump-recovery.cpp
Commit 6c733f5a1320977d24e7f5c565e55a6590e6ec8c by sguelton
Use Pseudo Instruction to carry stack probing information

Instead of using a fake call and metadata to temporarily represent a probed
static alloca, use a pseudo instruction.

This is inspired by the SystemZ approach proposed in https://reviews.llvm.org/D78717.

Differential Revision: https://reviews.llvm.org/D80641
The file was modifiedllvm/lib/Target/X86/X86InstrCompiler.td
The file was modifiedllvm/lib/Target/X86/X86FrameLowering.cpp
Commit aa3a85cdaa4432ca389bdbf48049eaa64dc6e266 by grimar
[yaml2obj] - Allocate the file space for SHT_NOBITS sections in some cases.

This teaches yaml2obj to allocate file space for a no-bits section
when there is a non-nobits section in the same segment that follows it.

It was discussed in D78005 thread and matches GNU linkers and LLD behavior.

Differential revision: https://reviews.llvm.org/D80629
The file was modifiedllvm/test/tools/llvm-objcopy/ELF/preserve-segment-contents.test
The file was modifiedllvm/lib/ObjectYAML/ELFEmitter.cpp
The file was modifiedllvm/test/tools/yaml2obj/ELF/program-header-nobits.yaml
Commit d559185aaebeb66456edb63b47da5a2f67a0a5e2 by gribozavr
Renamed Lang_C to Lang_C99, Lang_CXX to Lang_CXX03, and 2a to 20

Summary:
I think we would be better off with tests explicitly specifying the
language mode. Right now Lang_C means C99, but reads as "any C version",
or as "unspecified C version".

I also changed '-std=c++98' to '-std=c++03' because they are aliases (so
there is no difference in practice), because Clang implements C++03
rules in practice, and because 03 makes a nice sortable progression
between 03, 11, 14, 17, 20.

Reviewers: shafik, hlopko

Reviewed By: hlopko

Subscribers: jfb, martong, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D81000
The file was modifiedclang/include/clang/Testing/CommandLineArgs.h
The file was modifiedclang/unittests/AST/MatchVerifier.h
The file was modifiedclang/lib/Testing/CommandLineArgs.cpp
The file was modifiedclang/unittests/AST/ASTImporterODRStrategiesTest.cpp
The file was modifiedclang/unittests/AST/StructuralEquivalenceTest.cpp
The file was modifiedclang/unittests/AST/ASTImporterGenericRedeclTest.cpp
The file was modifiedclang/unittests/Tooling/Syntax/TreeTest.cpp
The file was modifiedclang/unittests/AST/SourceLocationTest.cpp
The file was modifiedclang/unittests/AST/ASTImporterTest.cpp
Commit 89d9dba2c6885949887edf4b80e1aabf8d8f3f88 by a.bataev
[OPENMP50]Initial codegen for 'affinity' clauses.

Summary:
Added initial codegen for 'affinity' clauses on task directives.
Emits next code:
```
kmp_task_affinity_info_t affs[<num_elems>];

void *td = __kmpc_task_alloc(..);

affs[<i>].base = &data_i;
affs[<i>].size = sizeof(data_i);
__kmpc_omp_reg_task_with_affinity(&loc, <gtid>, td, <num_elems>, affs);
```

The result returned by the call of `__kmpc_omp_reg_task_with_affinity`
function is ignored currently sincethe  runtime currently ignores args
and returns 0 uncoditionally.

Reviewers: jdoerfert

Subscribers: yaxunl, guansong, sstefan1, llvm-commits, cfe-commits, caomhin

Tags: #clang, #llvm

Differential Revision: https://reviews.llvm.org/D80240
The file was addedclang/test/OpenMP/task_affinity_codegen.cpp
The file was modifiedllvm/include/llvm/Frontend/OpenMP/OMPKinds.def
The file was modifiedclang/lib/CodeGen/CGOpenMPRuntime.cpp
The file was modifiedclang/lib/CodeGen/CGOpenMPRuntime.h
Commit 53c29a42d044b167f6b5f28e096c8d9e50d6edc7 by gribozavr
Reinstate the syntax tree test for 'static' in an array subscript

Reviewers: eduucaldas

Reviewed By: eduucaldas

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D81009
The file was modifiedclang/unittests/Tooling/Syntax/TreeTest.cpp
Commit bf1cdc2c6c0460b7121ac653c796ef4995b1dfa9 by Tom.Weaver
[Dexter] Add os.path.normcase(...) transform to test path early.

  When passing a test path, if the path points directly at a file, then
  normcase would not be called on path.

  This would change the expected lower case drive path, on windows, to be
  uppercase. This patch simply calls normcase on the test path at the earliest
  point possible to avoid this issue.

  Reviewers: djtodoro, jmorse

  Differential Revision: https://reviews.llvm.org/D78633
The file was modifieddebuginfo-tests/dexter/dex/tools/TestToolBase.py
Commit 81e836a5a675f6a3d9d35560fddbbb87fdf66201 by Tom.Weaver
[Dexter] Add DexLimitSteps command and ConditionalController

  * Adds DexLimitSteps Command.
  * Add ConditionalController, a new DebuggerController type.
  * 5 regression tests
  * documentation

  Reviewers: jmorse

  Differential Revision: https://reviews.llvm.org/D79786
The file was addeddebuginfo-tests/dexter/feature_tests/commands/perfect/limit_steps/limit_steps_overlapping_ranges.cpp
The file was modifieddebuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py
The file was addeddebuginfo-tests/dexter/feature_tests/commands/perfect/limit_steps/limit_steps_expect_value.cpp
The file was modifieddebuginfo-tests/dexter/dex/command/ParseCommand.py
The file was addeddebuginfo-tests/dexter/dex/debugger/DebuggerControllers/ConditionalController.py
The file was addeddebuginfo-tests/dexter/dex/command/commands/DexLimitSteps.py
The file was modifieddebuginfo-tests/dexter/dex/debugger/DebuggerBase.py
The file was addeddebuginfo-tests/dexter/dex/debugger/DebuggerControllers/ControllerHelpers.py
The file was modifieddebuginfo-tests/dexter/dex/debugger/DebuggerControllers/DebuggerControllerBase.py
The file was modifieddebuginfo-tests/dexter/dex/debugger/DebuggerControllers/DefaultController.py
The file was addeddebuginfo-tests/dexter/feature_tests/commands/perfect/limit_steps/limit_steps_expect_loop.cpp
The file was addeddebuginfo-tests/dexter/feature_tests/commands/perfect/limit_steps/limit_steps_same_line_conditional.cpp
The file was modifieddebuginfo-tests/dexter/dex/tools/test/Tool.py
The file was addeddebuginfo-tests/dexter/feature_tests/commands/perfect/limit_steps/limit_steps_check_json_step_count.cpp
The file was modifieddebuginfo-tests/dexter/dex/debugger/lldb/LLDB.py
The file was modifieddebuginfo-tests/dexter/dex/debugger/dbgeng/dbgeng.py
The file was addedd.diff
The file was modifieddebuginfo-tests/dexter/Commands.md
Commit 81bf1e29aae5992db318803ba4722a585ad64638 by david.truby
[flang] Fix release build flags.

Summary:
This patch removes the custom CMAKE_RELEASE_CXX_FLAGS variable.
This variable being set was having the effect of removing other important
Release flags, notably `-DNDEBUG`.

This patch may need to be accompanied by fixes for the macOS issues that
the removed comment mentions; I don't have a mac to test this on though so
hopefully a reviewer can help with that.

Reviewers: Andrzej, tskeith, sscalpone

Subscribers: mgorny, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D80794
The file was modifiedflang/CMakeLists.txt