FailedChanges

Summary

  1. Revert "[DBG][OPT] Attempt to salvage or undef debug info when removing (details)
  2. [InstCombine] avoid crash from deleting an instruction that still has (details)
  3. Revert "[InstCombine] avoid crash from deleting an instruction that (details)
  4. [TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in (details)
  5. [libc++] Mark __call_once_proxy as hidden and internal (details)
  6. clang-format: [JS] support null operators. (details)
  7. clang-format: [JS] test declared fields. (details)
  8. [clangd] fixes semantic highlighting test (details)
  9. [PowerPC] Implementing overflow version for XO-Form instructions (details)
Commit 9f48a160dd3fd56314cfbbe74c56e09aaab11566 by Tom.Weaver
Revert "[DBG][OPT] Attempt to salvage or undef debug info when removing
trivially deletable instructions in the Reassociate Expression pass."
This reverts commit 1984a27db58e9053371ab6d6dc288c81c8a071ac.
The file was removedllvm/test/Transforms/Reassociate/reassociate_salvages_debug_info.ll
The file was removedllvm/test/Transforms/Reassociate/undef_intrinsics_when_deleting_instructions.ll
The file was removedllvm/lib/Transforms/Scalar/Reassociate.cpp.rej
Commit 3db8a3ef86e7b3331ab466a78c10a62be9e69829 by spatel
[InstCombine] avoid crash from deleting an instruction that still has
uses (PR43723) (3rd try)
Re-try because earlier attempts were reverted due to use-after-free.
Hopefully, diagnosed correctly this time - we replace/remove the
invariant.start first rather than the invariant.end to avoid angering
worklist-based iteration.
We gather a set of white-listed instructions in isAllocSiteRemovable()
and then replace/erase them. But we don't know in general if the
instructions in the set have uses amongst themselves, so order of
deletion makes a difference.
There's already a special-case for the llvm.objectsize intrinsic, so add
another for llvm.invariant.start.
Should fix: https://bugs.llvm.org/show_bug.cgi?id=43723
Differential Revision: https://reviews.llvm.org/D69977
The file was modifiedllvm/lib/Transforms/InstCombine/InstructionCombining.cpp
The file was modifiedllvm/test/Transforms/InstCombine/builtin-object-size-ptr.ll
Commit 29f5d1670c368589b2555932551360721da7799a by spatel
Revert "[InstCombine] avoid crash from deleting an instruction that
still has uses (PR43723) (3rd try)"
This reverts commit 3db8a3ef86e7b3331ab466a78c10a62be9e69829. This
caused a different memory-sanitizer failure than earlier attempts, but
it's still not right.
The file was modifiedllvm/lib/Transforms/InstCombine/InstructionCombining.cpp
The file was modifiedllvm/test/Transforms/InstCombine/builtin-object-size-ptr.ll
Commit abbbf9880c272da7a3db5de40a91dcbddac8bb50 by joan.lluch
[TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in
DAGCombine (4) (Baseline tests)
Summary: Baseline tests before applying D70042
Reviewers: spatel, asl
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70083
The file was modifiedllvm/test/CodeGen/MSP430/shift-amount-threshold.ll
Commit 48b7068beca9d3a39dcfbebcb384b59b7898065f by Louis Dionne
[libc++] Mark __call_once_proxy as hidden and internal
We effectively never want to export that function, which is an
implementation detail of libc++. This was previously tried in
603715c66b6b and then reverted in 8335dd314f36 because it caused linker
warnings. These linker warnings should go away now that we use
internal_linkage instead of always_inline to implement per-TU
insulation.
The file was modifiedlibcxx/include/mutex
Commit a7638d384983e8e3eb44a2d8c757238efc7096dc by martin
clang-format: [JS] support null operators.
Summary: JavaScript / TypeScript is adding two new operators: the null
propagating operator `?.` and the nullish coalescing operator `??`.
    const x = foo ?? 'default';
   const z = foo?.bar?.baz;
This change adds support to lex and format both.
Reviewers: krasimir
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69971
The file was modifiedclang/unittests/Format/FormatTestJS.cpp
The file was modifiedclang/lib/Format/FormatToken.h
The file was modifiedclang/lib/Format/FormatTokenLexer.cpp
Commit 6bcd8d4a18fc0604a2297a626c1fc808cbfb7b9b by martin
clang-format: [JS] test declared fields.
Summary: TypeScript now supports declaring fields:
    class Foo {
     declare field: string;
   }
clang-format happens to already format this fine, so this change just
adds a regression test.
Reviewers: krasimir
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69972
The file was modifiedclang/unittests/Format/FormatTestJS.cpp
Commit f8c17fe1112009e793d6f9a261622423c2c62049 by hokein.wu
[clangd] fixes semantic highlighting test
Summary: fixes https://github.com/clangd/clangd/issues/176
Patch by liu hui!
Reviewers: ilya-biryukov, hokein, sammccall
Reviewed By: hokein
Subscribers: MaskRay, jkorous, arphaman, kadircet, usaxena95,
cfe-commits
Tags: #clang-tools-extra, #clang
Differential Revision: https://reviews.llvm.org/D70078
The file was modifiedclang-tools-extra/clangd/clients/clangd-vscode/test/semantic-highlighting.test.ts
Commit fdf3d1766bbabb48a397fae646facbe2690313f6 by stefanp
[PowerPC] Implementing overflow version for XO-Form instructions
The Overflow version of XO-Form instruction uses the SO, OV and OV32
special registers.
This changes modifies existing multiclasses and instruction definitions
to allow for the use of the XER register to record the various types if
overflow from possible add, subtract and multiply instructions. It then
modifies the existing instructions as to use these multiclasses as
needed.
Patch By: Kamau Bridgeman
Differential Revision: https://reviews.llvm.org/D66902
The file was modifiedllvm/lib/Target/PowerPC/P9InstrResources.td
The file was modifiedllvm/test/MC/PowerPC/ppc64-encoding.s
The file was modifiedllvm/test/MC/Disassembler/PowerPC/ppc64le-encoding.txt
The file was modifiedllvm/test/MC/PowerPC/invalid-instructions-spellcheck.s
The file was modifiedllvm/lib/Target/PowerPC/PPCInstrInfo.td
The file was modifiedllvm/lib/Target/PowerPC/PPCInstr64Bit.td
The file was modifiedllvm/test/MC/Disassembler/PowerPC/ppc64-encoding.txt