FailedChanges

Summary

  1. [clang-tidy] Add bugprone-bad-signal-to-kill-thread checker and alias (details)
  2. Fix TestNoGPacketSupported on linux (details)
  3. [ObjC] Override TailCallKind when lowering objc intrinsics (details)
  4. Revert "[clang-tidy] Add bugprone-bad-signal-to-kill-thread checker and (details)
  5. [clang-tidy] Add bugprone-bad-signal-to-kill-thread check and its alias (details)
  6. gn build: Merge 8d288a0668a (details)
  7. lldb: Fix some -Wdeprecated-copy warnings (details)
  8. [Format] Fix clang-format.el unit tests after commit f349cc37cc485fd5f (details)
  9. change LLVM_VERSION_SUFFIX default from svn to git (details)
  10. Timer - fix shadow variable warnings for Name/Description members. NFC. (details)
  11. Fix filename typo in rG8d288a0668a5 (details)
  12. [Support] Add erase() to json::Object (details)
  13. [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators (details)
  14. Fix errors where we thought we were checking for labels but weren't due (details)
  15. [ModuloSchedule] Do target loop analysis before peeling. (details)
  16. [scudo][standalone] Match function name change to bionic name change. (details)
  17. [libTooling] Further simplify `Stencil` type and introduce (details)
  18. [libc++][P0980] Marked member functions move/copy/assign of char_traits (details)
  19. [clangd] Fix crash in DefineInline::prepare() (details)
Commit 4edf0cb0e03e31d468979d0d7dec08bd9f4f8204 by abelkocsis
[clang-tidy] Add bugprone-bad-signal-to-kill-thread checker and alias
cert-pos44-c
The file was addedclang-tools-extra/docs/clang-tidy/checks/bugprone-bad-signal-to-kill-thread.rst
The file was modifiedclang-tools-extra/clang-tidy/bugprone/CMakeLists.txt
The file was addedclang-tools-extra/clang-tidy/bugprone/BadSignalToKillThreadCheck.h
The file was modifiedclang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/list.rst
The file was addedclang-tools-extra/docs/clang-tidy/checks/cert-pos44-c.rst
The file was addedclang-tools-extra/test/clang-tidy/bugprone-bad-signal-to-kill-thread.cpp
The file was modifiedclang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp
The file was addedclang-tools-extra/clang-tidy/bugprone/BadSignalToKillThreadCheck.cpp
The file was modifiedclang-tools-extra/docs/ReleaseNotes.rst
The file was addedbad-signal-to-kill-thread.patch
Commit 135a493f34561219d67251b58a482cd3fc6416b9 by pavel
Fix TestNoGPacketSupported on linux
The mock server pretends the process stopped with signal 17, which is
SIGCHLD on linux. This causes lldb to resume to process, utterly
confusing the test. Lldb probably shouldn't resume in this case, but for
now this issue can be fixed by changing the signal number to 2, which is
SIGINT just about anywhere.
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestNoGPacketSupported.py
Commit a9a3781df81a8a630e5d233efbc8b15b24ddd1dd by francisvm
[ObjC] Override TailCallKind when lowering objc intrinsics
The tail-call-kind-ness is known by the ObjCARC analysis and can be
enforced while lowering the intrinsics to calls.
This allows us to get the requested tail calls at -O0 without trying to
preserve the attributes throughout passes that change code even at -O0
,like the Always Inliner, where the ObjCOpt pass doesn't run.
Differential Revision: https://reviews.llvm.org/D69980
The file was modifiedllvm/test/Transforms/PreISelIntrinsicLowering/objc-arc.ll
The file was modifiedllvm/lib/CodeGen/PreISelIntrinsicLowering.cpp
Commit 8cec7e0208f5b65790fd5c73b90d6d35944b07b1 by abelkocsis
Revert "[clang-tidy] Add bugprone-bad-signal-to-kill-thread checker and
alias cert-pos44-c"
This reverts commit 4edf0cb0e03e31d468979d0d7dec08bd9f4f8204.
The file was modifiedclang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp
The file was removedclang-tools-extra/clang-tidy/bugprone/BadSignalToKillThreadCheck.h
The file was removedclang-tools-extra/docs/clang-tidy/checks/cert-pos44-c.rst
The file was removedclang-tools-extra/test/clang-tidy/bugprone-bad-signal-to-kill-thread.cpp
The file was removedclang-tools-extra/docs/clang-tidy/checks/bugprone-bad-signal-to-kill-thread.rst
The file was removedbad-signal-to-kill-thread.patch
The file was modifiedclang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/list.rst
The file was removedclang-tools-extra/clang-tidy/bugprone/BadSignalToKillThreadCheck.cpp
The file was modifiedclang-tools-extra/clang-tidy/bugprone/CMakeLists.txt
The file was modifiedclang-tools-extra/docs/ReleaseNotes.rst
Commit 8d288a0668a574863d52784084ff565c89f7366e by abelkocsis
[clang-tidy] Add bugprone-bad-signal-to-kill-thread check and its alias
cert-pos44-c
The file was addedclang-tools-extra/docs/clang-tidy/checks/cert-pos44-c.rst
The file was addedclang-tools-extra/test/clang-tidy/bugprone-bad-signal-to-kill-thread.cpp
The file was addedclang-tools-extra/docs/clang-tidy/checks/bugprone-bad-signal-to-kill-thread.rst
The file was addedclang-tools-extra/clang-tidy/bugprone/BadSignalToKillThreadCheck.h
The file was modifiedclang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp
The file was addedclang-tools-extra/clang-tidy/bugprone/BadSignalToKillThreadCheck.cpp
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/list.rst
The file was modifiedclang-tools-extra/clang-tidy/bugprone/CMakeLists.txt
The file was modifiedclang-tools-extra/docs/ReleaseNotes.rst
The file was modifiedclang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp
Commit 2da34a43c7ae9cb5dded89edfebc6b6df0ef173a by llvmgnsyncbot
gn build: Merge 8d288a0668a
The file was modifiedllvm/utils/gn/secondary/clang-tools-extra/clang-tidy/bugprone/BUILD.gn
Commit a14eb8f47d43c701651ad59f49167a614a8c9773 by pavel
lldb: Fix some -Wdeprecated-copy warnings
gcc-9 started warning when a class defined a copy constructor without a
copy assignment operator (or vice-versa).
This fixes those warnings by deleting the other special member too
(after verifying it doesn't do anything non-trivial).
The file was modifiedlldb/include/lldb/Utility/FileSpec.h
The file was modifiedlldb/include/lldb/Utility/Status.h
The file was modifiedlldb/source/Utility/Status.cpp
The file was modifiedlldb/include/lldb/Utility/Broadcaster.h
The file was modifiedlldb/include/lldb/Symbol/SymbolContext.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValue.h
The file was modifiedlldb/include/lldb/Utility/ArchSpec.h
The file was modifiedlldb/include/lldb/Utility/Flags.h
The file was modifiedlldb/source/Utility/FileSpec.cpp
The file was modifiedlldb/source/Utility/ArchSpec.cpp
The file was modifiedlldb/source/Symbol/SymbolContext.cpp
The file was modifiedlldb/source/Utility/Scalar.cpp
The file was modifiedlldb/include/lldb/Symbol/Declaration.h
The file was modifiedlldb/include/lldb/Utility/Scalar.h
The file was modifiedlldb/source/Utility/Broadcaster.cpp
Commit a81c1a9c56300669b9edcb187f8f751fd06c2d29 by sam.mccall
[Format] Fix clang-format.el unit tests after commit f349cc37cc485fd5f
Also add a comment that test is not automatically run, and how to run
it.
Patch by Philipp Stephani!
The file was modifiedclang/tools/clang-format/clang-format-test.el
Commit 49fb4a96e0b79e18aec0ed908676ae4ecaf3084b by ndesaulniers
change LLVM_VERSION_SUFFIX default from svn to git
Summary: Sayonara SVN!
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewers: tstellar, jyknight, lebedev.ri, smeenai, mgorny, hans,
mclow.lists
Reviewed By: mgorny, hans
Subscribers: christof, libcxx-commits, llvm-commits, srhines
Tags: #libc, #llvm
Differential Revision: https://reviews.llvm.org/D70019
The file was modifiedlibunwind/CMakeLists.txt
The file was modifiedlibcxx/CMakeLists.txt
The file was modifiedllvm/CMakeLists.txt
The file was modifiedllvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn
The file was modifiedllvm/utils/gn/secondary/clang/include/clang/Config/BUILD.gn
The file was modifiedllvm/utils/gn/secondary/llvm/tools/llvm-config/BUILD.gn
Commit 5cfce5079bc8218e68b6404b70116aeccc346dd1 by llvm-dev
Timer - fix shadow variable warnings for Name/Description members. NFC.
The file was modifiedllvm/lib/Support/Timer.cpp
The file was modifiedllvm/include/llvm/Support/Timer.h
Commit b6cd799e29a9a5cef4d1d722f267e3b59ef6aaca by llvm-dev
Fix filename typo in rG8d288a0668a5
The file was modifiedclang-tools-extra/docs/ReleaseNotes.rst
Commit 4162875c3b2a2326c8f40b6cba98308d819f4d49 by sam.mccall
[Support] Add erase() to json::Object
The file was modifiedllvm/include/llvm/Support/JSON.h
The file was modifiedllvm/unittests/Support/JSONTest.cpp
Commit 6bbfafd03782a4bf9522edeaf4860470946ecfd0 by yi-hong.lyu
[CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators
For example:
long long test(long long a, long long b) {
if (a << b > 0)
   return b;
if (a << b < 0)
   return a;
return a*b;
}
Produces:
        sld. 5, 3, 4
       ble 0, .LBB0_2
       mr 3, 4
       blr
.LBB0_2:                                # %if.end
       cmpldi  5, 0
       li 5, 1
       isel 4, 4, 5, 2
       mulld 3, 4, 3
       blr
But the compare (cmpldi 5, 0) is redundant and can be removed (CR0
already contains the result of that comparison).
The root cause of this is that LLVM converts signed comparisons into
equality comparison based on dominance. Equality comparisons are
unsigned by default, so we get either a record-form or cmp (without the
l for logical) feeding a cmpl. That is the situation we want to avoid
here.
Differential Revision: https://reviews.llvm.org/D60506
The file was modifiedllvm/test/CodeGen/AArch64/use-cr-result-of-dom-icmp-st.ll
The file was modifiedllvm/lib/Target/PowerPC/PPCISelLowering.h
The file was modifiedllvm/lib/CodeGen/CodeGenPrepare.cpp
The file was modifiedllvm/test/CodeGen/PowerPC/use-cr-result-of-dom-icmp-st.ll
The file was modifiedllvm/include/llvm/CodeGen/TargetLowering.h
The file was modifiedllvm/test/CodeGen/X86/use-cr-result-of-dom-icmp-st.ll
Commit 19bbdf6ca6be5315b2ab88e9d930463ab65c278d by kevin.neal
Fix errors where we thought we were checking for labels but weren't due
to use of the wrong prefix. Spotted by Craig Topper in reviewing D69275.
The file was modifiedllvm/test/CodeGen/X86/fp-intrinsics.ll
Commit 03da6e8c00de2320e6b9dacba8f7850faceae319 by thomasraoux
    [ModuloSchedule] Do target loop analysis before peeling.
    Simple change to call target hook analyzeLoopForPipelining before
   changing the loop. After peeling analyzing the loop may be more
   complicated for target that don't have a loop instruction. This
doesn't
   affect Hexagone and PPC as they have hardware loop instructions.
    Differential Revision: https://reviews.llvm.org/D69912
The file was modifiedllvm/lib/CodeGen/ModuloSchedule.cpp
The file was modifiedllvm/include/llvm/CodeGen/ModuloSchedule.h
Commit 14df08f0580cea8f8bec5814e3b895b373001b56 by kostyak
[scudo][standalone] Match function name change to bionic name change.
Summary: Bionic was modified to have all function names consistent.
Modify the code and get rid of the special case for bionic since it's no
longer needed.
Reviewers: cryptoad
Reviewed By: cryptoad
Subscribers: srhines, llvm-commits, #sanitizers
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D70031
The file was modifiedcompiler-rt/lib/scudo/standalone/wrappers_c.inc
Commit 489449c28aaa45086d507fbad96826420adf409d by yitzhakm
[libTooling] Further simplify `Stencil` type and introduce
`MatchComputation`.
Summary: This revision introduces a new interface `MatchComputation`
which generalizes the `Stencil` interface and replaces the
`std::function` interface of
`MatchConsumer`. With this revision, `Stencil` (as an abstraction)
becomes just one collection of implementations of
`MatchComputation<std::string>`. Correspondingly, we remove the
`Stencil` class entirely in favor of a simple type alias, deprecate
`MatchConsumer` and change all functions that accepted
`MatchConsumer<std::string>` to use
`MatchComputation<std::string>` instead.
Reviewers: gribozavr
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69802
The file was modifiedclang/include/clang/Tooling/Transformer/MatchConsumer.h
The file was modifiedclang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp
The file was modifiedclang/include/clang/Tooling/Transformer/Stencil.h
The file was modifiedclang/unittests/Tooling/TransformerTest.cpp
The file was modifiedclang/lib/Tooling/Transformer/RewriteRule.cpp
The file was modifiedclang/lib/Tooling/Transformer/Stencil.cpp
The file was modifiedclang/unittests/Tooling/StencilTest.cpp
The file was modifiedclang/include/clang/Tooling/Transformer/RewriteRule.h
Commit eb8710cb93a5c21c168ffd97ac2b6872127cb60b by mcypark
[libc++][P0980] Marked member functions move/copy/assign of char_traits
constexpr.
Reviewers: ldionne, EricWF, mclow.lists
Reviewed By: ldionne
Subscribers: christof, dexonsmith, libcxx-commits
Tags: #libc
Differential Revision: https://reviews.llvm.org/D68840
The file was modifiedlibcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char32_t/copy.pass.cpp
The file was modifiedlibcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char8_t/copy.pass.cpp
The file was modifiedlibcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char8_t/move.pass.cpp
The file was modifiedlibcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char/copy.pass.cpp
The file was modifiedlibcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.wchar.t/move.pass.cpp
The file was modifiedlibcxx/include/__string
The file was modifiedlibcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char16_t/move.pass.cpp
The file was modifiedlibcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char8_t/assign3.pass.cpp
The file was modifiedlibcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char32_t/move.pass.cpp
The file was modifiedlibcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char/move.pass.cpp
The file was modifiedlibcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char16_t/assign3.pass.cpp
The file was modifiedlibcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char/assign3.pass.cpp
The file was modifiedlibcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char16_t/copy.pass.cpp
The file was modifiedlibcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.wchar.t/assign3.pass.cpp
The file was modifiedlibcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.wchar.t/copy.pass.cpp
The file was modifiedlibcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char32_t/assign3.pass.cpp
Commit b9213dfec4d8ce42d90507c25545564f4a0bbfb8 by sam.mccall
[clangd] Fix crash in DefineInline::prepare()
The file was modifiedclang-tools-extra/clangd/unittests/TweakTests.cpp
The file was modifiedclang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp