FailedChanges

Summary

  1. [NFC] Fix test reserve_global_reg.ll after 2d739f9 (details)
  2. [clangd] Implement rename by using SelectionTree and (details)
  3. [NFC] Clean up debug-names-verify-completeness.s test (details)
  4. [clangd] Store xref for Macros in ParsedAST. (details)
  5. gn build: Merge 2054ed052f1 (details)
Commit aea7578fade2563cb5ea60548914667b515c457a by russell.gallop
[NFC] Fix test reserve_global_reg.ll after 2d739f9
The file was modifiedllvm/test/Feature/reserve_global_reg.ll
Commit 4f80fc2491cc35730a9a84b86975278b7daa8522 by hokein.wu
[clangd] Implement rename by using SelectionTree and
findExplicitReferences.
Summary: With the new implemenation, we will have better coverage of
various AST nodes, and fix some known/potential bugs.
Also added the existing clang-renamae tests. Known changed behavior:
- "~Fo^o()" will not trigger the rename, will fix afterwards
- references in macro bodies are not renamed now
This fixes:
- https://github.com/clangd/clangd/issues/167
- https://github.com/clangd/clangd/issues/169
- https://github.com/clangd/clangd/issues/171
Reviewers: ilya-biryukov
Subscribers: MaskRay, jkorous, arphaman, kadircet, usaxena95,
cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69934
The file was modifiedclang-tools-extra/clangd/refactor/Rename.cpp
The file was modifiedclang-tools-extra/clangd/unittests/RenameTests.cpp
Commit fa541860564ba3a82bf085613ebc1376f641e966 by pavel
[NFC] Clean up debug-names-verify-completeness.s test
This patch replaces the tabs by spaces and avoid the need for a
debug_str section by moving all strings inline. It also removes the
hardcoded DIE offsets in the test, which will simplify a follow-up
patch.
The file was modifiedllvm/test/tools/llvm-dwarfdump/X86/debug-names-verify-completeness.s
Commit 2054ed052f15b584e1bce57c8f765991eab2da7d by usx
[clangd] Store xref for Macros in ParsedAST.
This patch adds the cross references for Macros in the MainFile. We add
references for the main file to the ParsedAST. We query the references
from it using the SymbolID. Xref outside main file will be added to the
index in a separate patch.
The file was addedclang-tools-extra/clangd/unittests/CollectMacrosTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/CMakeLists.txt
The file was modifiedclang-tools-extra/clangd/CollectMacros.h
The file was modifiedclang-tools-extra/clangd/XRefs.cpp
The file was modifiedclang-tools-extra/clangd/SemanticHighlighting.cpp
The file was modifiedclang-tools-extra/clangd/unittests/ParsedASTTests.cpp
Commit 7e45b5864f1881ba0e6ca45286a746979b56b17c by llvmgnsyncbot
gn build: Merge 2054ed052f1
The file was modifiedllvm/utils/gn/secondary/clang-tools-extra/clangd/unittests/BUILD.gn