SuccessChanges

Summary

  1. [MLIR] Add Async dialect with trivial async.region operation (details)
  2. [clangd] Fix assertion in remote-index marshalling (details)
  3. Revert "Revert "Add the ability to write target stop-hooks using the ScriptInterpreter."" (details)
  4. [CodeGen] emit CG profile for COFF object file (details)
  5. Use "default member initializer" instead of "in-class initializer" for diagnostics. (details)
  6. [ValueTracking] Early exit known non zero for phis (details)
  7. [mlir] Support return and call ops in bare-ptr calling convention (details)
  8. [InstCombine] ease alignment restriction for converting masked load to normal load (details)
  9. [libc++][ci] Add a script to describe when to trigger libc++ CI builds (details)
  10. [libc++][ci] Improve the phabricator-report script (details)
  11. [lldb/docs] Remove manual codesigning documentation (details)
  12. [libc++][ci] Turn on Phabricator reporting by default (details)
  13. [trace] Fix destructor declaration (details)
  14. Fix TODO in the mlir-cpu-runner/bare_ptr_call_conv.mlir test: call ops in bare-ptr calling convention is supported now (NFC) (details)
  15. [libc++] Fix some test failures in unusual configurations (details)
  16. [lldb] Hoist --server argument out of LLDB_TEST_COMMON_ARGS (NFC) (details)
  17. [libc++] Rename the -fno-rtti Lit feature to just no-rtti (details)
  18. Better diagnostics for anonymous bit-fields with attributes or an initializer. (details)
  19. Revert "[Sema] Address-space sensitive check for unbounded arrays (v2)" (details)
  20. [clangd] Trivial setter support when moving items to fields (details)
  21. [MLIR] Avoid adding debuginfo for a function if it contains calls that has no debug info. (details)
  22. [ms] [llvm-ml] Add support for .radix directive, and accept all radix specifiers (details)
  23. [ms] [llvm-ml] Add MASM hex float support (details)
  24. [ms] [llvm-ml] Add REAL10 support (x87 extended precision) (details)
  25. [ms] [llvm-ml] Add support for "alias" directive (details)
  26. [ms] [llvm-ml] Accept whitespace around the dot operator (details)
  27. [ms] [llvm-ml] Create the @feat.00 symbol, and populate it appropriately (details)
Commit 05a3b4fe30050b2b75c5eb339af52ba68cf01a7c by ezhulenev
[MLIR] Add Async dialect with trivial async.region operation

Start Async dialect for modeling asynchronous execution.

Reviewed By: mehdi_amini, herhut

Differential Revision: https://reviews.llvm.org/D88459
The file was addedmlir/include/mlir/Dialect/Async/IR/AsyncOps.td
The file was modifiedmlir/include/mlir/Dialect/CMakeLists.txt
The file was addedmlir/lib/Dialect/Async/IR/Async.cpp
The file was addedmlir/include/mlir/Dialect/Async/IR/Async.h
The file was addedmlir/include/mlir/Dialect/Async/IR/CMakeLists.txt
The file was addedmlir/lib/Dialect/Async/IR/CMakeLists.txt
The file was modifiedmlir/include/mlir/InitAllDialects.h
The file was addedmlir/lib/Dialect/Async/CMakeLists.txt
The file was modifiedmlir/lib/Dialect/CMakeLists.txt
The file was addedmlir/include/mlir/Dialect/Async/CMakeLists.txt
The file was addedmlir/include/mlir/Dialect/Async/IR/AsyncBase.td
The file was addedmlir/test/Dialect/Async/ops.mlir
Commit 962a247aebba39bc8f2d6aa901ed512f5c09dc72 by kadircet
[clangd] Fix assertion in remote-index marshalling

convert_to_slash is a no-op on posix style.
The file was modifiedclang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp
Commit 1b1d9815987a753f2f3524cfad050b85972dae5b by jingham
Revert "Revert "Add the ability to write target stop-hooks using the ScriptInterpreter.""

This reverts commit f775fe59640a2e837ad059a8f40e26989d4f9831.

I fixed a return type error in the original patch that was causing a test failure.
Also added a REQUIRES: python to the shell test so we'll skip this for
people who build lldb w/o Python.
Also added another test for the error printing.
The file was modifiedlldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
The file was modifiedlldb/docs/use/python-reference.rst
The file was addedlldb/test/Shell/Commands/Inputs/stop_hook.py
The file was modifiedlldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h
The file was modifiedlldb/unittests/ScriptInterpreter/Python/PythonTestSuite.cpp
The file was addedlldb/test/Shell/Commands/command-stop-hook-output.test
The file was modifiedlldb/include/lldb/Interpreter/ScriptInterpreter.h
The file was modifiedlldb/source/Target/Target.cpp
The file was modifiedlldb/source/Commands/CommandObjectTarget.cpp
The file was addedlldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py
The file was modifiedlldb/test/API/commands/target/stop-hooks/main.c
The file was addedlldb/test/API/commands/target/stop-hooks/stop_hook.py
The file was modifiedlldb/bindings/python/python-swigsafecast.swig
The file was modifiedlldb/bindings/python/python-wrapper.swig
The file was modifiedlldb/include/lldb/Symbol/SymbolContext.h
The file was modifiedlldb/test/API/commands/target/stop-hooks/TestStopHooks.py
The file was modifiedlldb/source/Symbol/SymbolContext.cpp
The file was modifiedlldb/include/lldb/Target/Target.h
The file was modifiedlldb/source/Commands/Options.td
Commit 6c91e623e53703560e781b172e9160cae2cf8d21 by zequanwu
[CodeGen] emit CG profile for COFF object file

Differential Revision: https://reviews.llvm.org/D87811
The file was modifiedllvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
The file was addedllvm/test/MC/COFF/cgprofile.ll
The file was modifiedllvm/include/llvm/CodeGen/TargetLoweringObjectFileImpl.h
Commit 15fbae8ac303d8601ea95418d4818cb50d0765e1 by aaron
Use "default member initializer" instead of "in-class initializer" for diagnostics.

This changes some diagnostics to use terminology from the standard
rather than invented terminology, which improves consistency with other
diagnostics as well. There are no functional changes intended other
than wording and naming.
The file was modifiedclang/test/Parser/MicrosoftExtensions.cpp
The file was modifiedclang/lib/Sema/SemaDeclCXX.cpp
The file was modifiedclang/lib/Sema/SemaTemplateInstantiate.cpp
The file was modifiedclang/test/Parser/cxx-class.cpp
The file was modifiedclang/test/SemaCXX/PR9572.cpp
The file was modifiedclang/test/SemaCXX/cxx98-compat.cpp
The file was modifiedclang/include/clang/Basic/DiagnosticParseKinds.td
The file was modifiedclang/include/clang/Basic/DiagnosticSemaKinds.td
The file was modifiedclang/test/SemaCXX/member-init.cpp
The file was modifiedclang/test/SemaCXX/class.cpp
Commit ac8a51c701ebd332a44944f8ff8545c21bc438ce by nikita.ppv
[ValueTracking] Early exit known non zero for phis

After D88276 we no longer expect computeKnownBits() to prove
non-zeroness for cases where isKnownNonZero() can't, so don't
fall through to it.
The file was modifiedllvm/lib/Analysis/ValueTracking.cpp
Commit a89fc12653c520a5a70249e07c0a394584f4abbe by diego.caballero
[mlir] Support return and call ops in bare-ptr calling convention

This patch adds support for the 'return' and 'call' ops to the bare-ptr
calling convention. These changes also align the bare-ptr calling
convention code with the latest changes in the default calling convention
and reduce the amount of customization code needed.

Reviewed By: ftynse

Differential Revision: https://reviews.llvm.org/D87724
The file was modifiedmlir/test/Conversion/StandardToLLVM/convert-static-memref-ops.mlir
The file was modifiedmlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h
The file was modifiedmlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
Commit 0527c8749b90cc742077ae9b3def80efde721090 by spatel
[InstCombine] ease alignment restriction for converting masked load to normal load

I think we initially made this fold conservative to be safer, but we do not
need the alignment attribute/metadata limitation because the masked load
intrinsic itself specifies the alignment. A normal vector load is better for
IR transforms and should be no worse in codegen than the masked alternative.
If it is worse for some target, the backend can reverse this transform.

Differential Revision: https://reviews.llvm.org/D88505
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
The file was modifiedllvm/test/Transforms/InstCombine/masked_intrinsics.ll
Commit d689a64edd568e3048eb33976aa148251614d510 by Louis Dionne
[libc++][ci] Add a script to describe when to trigger libc++ CI builds
The file was addedlibcxx/utils/ci/buildkite-pipeline-trigger.sh
Commit b1e78509678814de6684db3f7498d016f07a3d54 by Louis Dionne
[libc++][ci] Improve the phabricator-report script

- Detect whether a build has passed more accurately
- Retry pushing the status to Phabricator
- Allow running on a non-review branch
The file was modifiedlibcxx/utils/ci/phabricator-report
Commit 5d19eb542db40fc5fe9f37c46246785ba5ae1e10 by davelee.com
[lldb/docs] Remove manual codesigning documentation

The `macos-setup-codesign.sh` script has been in place for over two years. If there are no known issues, it's a good time to drop the manual steps from the docs.

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D88257
The file was modifiedlldb/docs/resources/build.rst
Commit d94253b52eb1ccf08daaa281488b3903396ca9b9 by Louis Dionne
[libc++][ci] Turn on Phabricator reporting by default
The file was modifiedlibcxx/utils/ci/buildkite-pipeline.yml
The file was modifiedlibcxx/utils/ci/run-buildbot.sh
Commit 92e1ebeaa1fe0e5461327d071c55167733834e60 by walter erquinigo
[trace] Fix destructor declaration

The destructor must be defined in the implementation class so that it
can be called, as Vedant Kumar pointed out in:

'''
What were your thoughts, re:

+class Trace : public PluginInterface {
+public:
+  ~Trace() override = default;

   Does this need to be `virtual ~Trace() = ...`?

      Otherwise, when a std::shared_ptr<Trace> is destroyed, the
      destructor for the derived TraceIntelPT instance won't run.
'''
The file was modifiedlldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h
The file was modifiedlldb/include/lldb/Target/Trace.h
Commit eff9984dca033af2727ff90e22fbfb3af4ce7d4c by joker.eph
Fix TODO in the mlir-cpu-runner/bare_ptr_call_conv.mlir test: call ops in bare-ptr calling convention is supported now (NFC)

This was fixed in a89fc12653c.
The file was modifiedmlir/test/mlir-cpu-runner/bare_ptr_call_conv.mlir
Commit d0667562e127925fb845124302ae31f10b3a849d by Louis Dionne
[libc++] Fix some test failures in unusual configurations
The file was modifiedlibcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp
The file was modifiedlibcxxabi/test/incomplete_type.sh.cpp
Commit 3c7070f1a6b89277fce042a943cd83fa65507a67 by Jonas Devlieghere
[lldb] Hoist --server argument out of LLDB_TEST_COMMON_ARGS (NFC)

Give the server argument its own variable (LLDB_TEST_SERVER) so that we
can configure it in lit.site.cfg.py if we so desire.
The file was modifiedlldb/test/API/CMakeLists.txt
The file was modifiedlldb/test/API/lit.site.cfg.py.in
The file was modifiedlldb/utils/lldb-dotest/CMakeLists.txt
The file was modifiedlldb/test/API/lit.cfg.py
The file was modifiedlldb/utils/lldb-dotest/lldb-dotest.in
Commit f9e70fa546a461b3c9fa8463efcd9f7fe989bd9f by Louis Dionne
[libc++] Rename the -fno-rtti Lit feature to just no-rtti

This is consistent to the way we name other Lit features, and it removes
the possibility for confusing the Lit feature with the actual compiler
flag.
The file was modifiedlibcxx/test/std/utilities/type.index/type.index.members/lt.pass.cpp
The file was modifiedlibcxx/utils/libcxx/test/params.py
The file was modifiedlibcxx/test/support/test.support/test_macros_header.rtti.pass.cpp
The file was modifiedlibcxx/test/support/test.support/test_macros_header.no_rtti.verify.cpp
The file was modifiedlibcxx/test/std/language.support/support.rtti/type.info/type_info_hash.pass.cpp
The file was modifiedlibcxxabi/test/incomplete_type.sh.cpp
The file was modifiedlibcxx/test/std/utilities/type.index/type.index.members/ctor.pass.cpp
The file was modifiedlibcxx/test/libcxx/language.support/support.rtti/type.info/type_info.comparison.merged.sh.cpp
The file was modifiedlibcxx/test/std/language.support/support.rtti/type.info/type_info.pass.cpp
The file was modifiedlibcxx/test/std/utilities/type.index/type.index.members/eq.pass.cpp
The file was modifiedlibcxx/test/std/utilities/function.objects/func.wrap/func.wrap.func/func.wrap.func.targ/target_type.pass.cpp
The file was modifiedlibcxx/test/std/utilities/type.index/type.index.overview/copy_ctor.pass.cpp
The file was modifiedlibcxx/test/std/utilities/type.index/type.index.overview/copy_assign.pass.cpp
The file was modifiedlibcxx/test/std/utilities/type.index/type.index.hash/hash.pass.cpp
The file was modifiedlibcxx/test/std/utilities/any/any.class/any.observers/type.pass.cpp
The file was modifiedlibcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.getdeleter/get_deleter.pass.cpp
The file was modifiedlibcxx/test/std/utilities/type.index/type.index.members/name.pass.cpp
The file was modifiedlibcxx/test/std/utilities/type.index/type.index.members/hash_code.pass.cpp
The file was modifiedlibcxx/test/std/utilities/function.objects/func.wrap/func.wrap.func/func.wrap.func.targ/target.pass.cpp
The file was modifiedlibcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.cast/dynamic_pointer_cast.pass.cpp
The file was modifiedlibcxx/test/std/utilities/type.index/type.index.synopsis/hash_type_index.pass.cpp
The file was modifiedlibcxx/test/libcxx/language.support/support.rtti/type.info/type_info.comparison.unmerged.sh.cpp
Commit 538762fef0b662048be2a261ebc12da249efa977 by aaron
Better diagnostics for anonymous bit-fields with attributes or an initializer.

The current C++ grammar allows an anonymous bit-field with an attribute,
but this is ambiguous (the attribute in that case could appertain to the
type instead of the bit-field). The current thinking in the Core Working
Group is that it's better to disallow attributes in that position at the
grammar level so that the ambiguity resolves in favor of applying to the
type.

During discussions about the behavior of the attribute, the Core Working
Group also felt it was better to disallow anonymous bit-fields from
specifying a default member initializer.

This implements both sets of related grammar changes.
The file was modifiedclang/include/clang/Basic/DiagnosticParseKinds.td
The file was modifiedclang/include/clang/Basic/DiagnosticSemaKinds.td
The file was modifiedclang/lib/Parse/ParseDecl.cpp
The file was modifiedclang/lib/Parse/ParseDeclCXX.cpp
The file was modifiedclang/lib/Sema/SemaDecl.cpp
The file was modifiedclang/test/Parser/MicrosoftExtensions.cpp
The file was modifiedclang/test/Parser/c2x-attributes.c
The file was addedclang/test/CXX/class/class.bit/p1.cpp
Commit 155d2d5300551c6ac26eaeef259d73d62f939d0b by Chris.Hamilton
Revert "[Sema] Address-space sensitive check for unbounded arrays (v2)"

This reverts commit d9ee935679e7164d1c47e351bbbcf5c25742b59c.
The file was removedclang/test/Sema/unbounded-array-bounds.c
The file was modifiedclang/test/Sema/const-eval.c
The file was modifiedclang/lib/Sema/SemaChecking.cpp
The file was modifiedclang/test/SemaCXX/constant-expression-cxx1y.cpp
The file was modifiedclang/include/clang/Basic/DiagnosticSemaKinds.td
Commit 01a30fa6787d8375e1df573150f9927561b0a0f1 by n.james93
[clangd] Trivial setter support when moving items to fields

Extend the Trivial setter documentation to support cases where the value is moved into a field using `std::move`.

Reviewed By: sammccall, kadircet

Differential Revision: https://reviews.llvm.org/D88297
The file was modifiedclang-tools-extra/clangd/Hover.cpp
The file was modifiedclang-tools-extra/clangd/unittests/HoverTests.cpp
Commit f0506e4923cdbd2b53258bc6c3a2b6bc62c8ccc3 by timshen
[MLIR] Avoid adding debuginfo for a function if it contains calls that has no debug info.

Also add a verifier pass to ExecutionEngine.

It's hard to come up with a test case, since mlir-opt always add location info after parsing it (?)

Differential Revision: https://reviews.llvm.org/D88135
The file was modifiedmlir/lib/Target/LLVMIR/ConvertToLLVMIR.cpp
The file was modifiedmlir/lib/Target/LLVMIR/DebugTranslation.cpp
The file was modifiedmlir/test/Target/llvmir-debug.mlir
Commit 6b70a83d9cc0ec17aa4bc199081c0a51e65be6dd by epastor
[ms] [llvm-ml] Add support for .radix directive, and accept all radix specifiers

Add support for .radix directive, and radix specifiers [yY] (binary), [oOqQ] (octal), and [tT] (decimal).

Also, when lexing MASM integers, require radix specifier; MASM requires that all literals without a radix specifier be treated as in the default radix. (e.g., 0100 = 100)

Relanding D87400, now with fewer ms-inline-asm tests broken!

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D88337
The file was modifiedllvm/include/llvm/MC/MCParser/MCAsmLexer.h
The file was modifiedllvm/lib/MC/MCParser/AsmLexer.cpp
The file was modifiedllvm/lib/MC/MCParser/MasmParser.cpp
The file was modifiedllvm/tools/llvm-ml/llvm-ml.cpp
The file was addedllvm/test/tools/llvm-ml/radix.test
The file was addedllvm/test/tools/llvm-ml/radix_errors.test
The file was modifiedllvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
The file was modifiedllvm/lib/MC/MCParser/COFFMasmParser.cpp
Commit c65e9e71eb7612b297a8bfd3e74759d55cfc7bf4 by epastor
[ms] [llvm-ml] Add MASM hex float support

Implement MASM's syntax for specifying floats in raw hexadecimal bytes.

Reviewed By: thakis

Differential Revision: https://reviews.llvm.org/D87401
The file was modifiedllvm/lib/MC/MCParser/MasmParser.cpp
The file was modifiedllvm/tools/llvm-ml/llvm-ml.cpp
The file was modifiedllvm/include/llvm/MC/MCParser/MCAsmLexer.h
The file was modifiedllvm/tools/llvm-mc/llvm-mc.cpp
The file was modifiedllvm/lib/MC/MCParser/AsmLexer.cpp
The file was modifiedllvm/test/tools/llvm-ml/builtin_types.test
Commit fdd23a35422ca133410c6b066ea191f426267c46 by epastor
[ms] [llvm-ml] Add REAL10 support (x87 extended precision)

Add MASM support for 80-bit reals in the x87 extended precision format.

Reviewed By: thakis

Differential Revision: https://reviews.llvm.org/D87402
The file was modifiedllvm/include/llvm/MC/MCStreamer.h
The file was modifiedllvm/test/tools/llvm-ml/type_operators.test
The file was modifiedllvm/lib/MC/MCParser/MasmParser.cpp
The file was modifiedllvm/lib/MC/MCStreamer.cpp
The file was modifiedllvm/test/tools/llvm-ml/builtin_types.test
Commit 0548d1ca24b72d28e50fbd8a456b1fd36beacb07 by epastor
[ms] [llvm-ml] Add support for "alias" directive

Support the "alias" directive.

Required support for emitWeakReference in MCWinCOFFStreamer.

Reviewed By: thakis

Differential Revision: https://reviews.llvm.org/D87403
The file was modifiedllvm/lib/MC/MCParser/COFFMasmParser.cpp
The file was modifiedllvm/lib/MC/MCWinCOFFStreamer.cpp
The file was modifiedllvm/include/llvm/MC/MCWinCOFFStreamer.h
The file was modifiedllvm/test/tools/llvm-ml/proc_frame.test
The file was modifiedllvm/test/tools/llvm-ml/proc.test
The file was addedllvm/test/tools/llvm-ml/alias.test
The file was addedllvm/test/tools/llvm-ml/alias_errors.test
Commit feb74530f86516de211d8b91eab426fc39d1b3e8 by epastor
[ms] [llvm-ml] Accept whitespace around the dot operator

MASM allows arbitrary whitespace around the Intel dot operator, especially when used for struct field lookup

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D88450
The file was addedllvm/test/tools/llvm-ml/dot_operator.test
The file was modifiedllvm/lib/MC/MCParser/MasmParser.cpp
The file was modifiedllvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
The file was modifiedllvm/test/tools/llvm-ml/struct.test
Commit 13f701b99ca1e0786258ef05b0439d4893aac8cb by epastor
[ms] [llvm-ml] Create the @feat.00 symbol, and populate it appropriately

@feat.00 is a bitfield read by Microsoft-style linkers, and is required to signal (e.g.) /safeseh support on 32-bit systems.

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D88451
The file was addedllvm/test/tools/llvm-ml/feat00_override.test
The file was addedllvm/test/tools/llvm-ml/feat00.test
The file was modifiedllvm/tools/llvm-ml/llvm-ml.cpp