FailedChanges

Changes from Git (git http://labmaster3.local/git/llvm-project.git)

Summary

  1. DebugInfo: Check DW_OP_convert in loclists with Split DWARF (details)
  2. DebugInfo: Fix convert-loclist.ll to handle different target instruction (details)
  3. DebugInfo: Simplify emitDebugLocEntry by never passing a null CU (details)
  4. Xfail this test temporarily until AdrianM or I can debug why his patch (details)
  5. DebugInfo: Hash DW_OP_convert in loclists when using Split DWARF (details)
  6. Fix unused variable warning (NFC) (details)
  7. [X86] Don't emit two X86ISD::COMI/UCOMI nodes when handling comi/ucomi (details)
  8. Re-land "[lldb/Test] Make substrs argument to self.expect ordered." (details)
  9. [lldb/Test] Use arrays instead of sets for build_and_run_expr (details)
  10. [lldb/Test] Sort substr for TestDataFormatterStdMap.py (details)
  11. [lldb/Test] Fix typo in TestDataFormatterStdMap.py (details)
  12. [lldb] [ObjectFile/ELF] Fix negated seg ids on 32-bit arches (details)
  13. Update TTI's getUserCost to return TCC_Free on freeze (details)
  14. [lldb/Test] Fix substr order in asan & ubsan tests (details)
  15. [lldb/Test] Sort substr for TestDataFormatterStdMap.py (2/2) (details)
  16. [X86] Use X86ISD::SUB instead of X86ISD::CMP in some places. (details)
  17. [mlir] Initial support for type constraints in the declarative assembly (details)
  18. [mlir][ODS] Refactor BuildableType to use $_builder as part of the (details)
  19. [mlir] Emit a fatal error when the assembly format is invalid (details)
  20. [X86] Remove some uncovered and possibly broken code from combineZext. (details)
  21. [GVN] Add GVNOption to control load-pre more fine-grained. (details)
Commit 552a8fe12bd1822f48dda2e9e8728a179f82d356 by dblaikie
DebugInfo: Check DW_OP_convert in loclists with Split DWARF
The file was modifiedllvm/test/DebugInfo/X86/convert-loclist.ll
Commit 4f281f047457ce3f1870a93253476222314f420b by dblaikie
DebugInfo: Fix convert-loclist.ll to handle different target instruction
lengths
The file was modifiedllvm/test/DebugInfo/X86/convert-loclist.ll
Commit 031f83fb8206d936cdef660eefdd26478926b352 by dblaikie
DebugInfo: Simplify emitDebugLocEntry by never passing a null CU
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DIEHash.cpp
Commit bc3f87cc029e7f8519e584e38ba0b4b2500a7258 by Jason Molenda
Xfail this test temporarily until AdrianM or I can debug why his patch
is causing this regression; or if it doesn't get figured out tomorrow,
we'll revert the patch.
The file was modifiedlldb/packages/Python/lldbsuite/test/commands/add-dsym/uuid/TestAddDsymCommand.py
Commit 1ced28cbe75ff81f35ac2c71e941041eb3afcd00 by dblaikie
DebugInfo: Hash DW_OP_convert in loclists when using Split DWARF
This code was incorrectly emitting extra bytes into arbitrary parts of
the object file when it was meant to be hashing them to compute the DWO
ID.
Follow-up patch(es) will refactor this API somewhat to make such bugs
harder to introduce, hopefully.
The file was modifiedllvm/lib/CodeGen/AsmPrinter/ByteStreamer.h
The file was modifiedllvm/test/DebugInfo/X86/convert-loclist.ll
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
Commit ea4652ebeb207823212a09772b14cb0a167895ac by joker-eph
Fix unused variable warning (NFC)
Use isa<> instead of dyn_cast<> when the result isn't used.
The file was modifiedmlir/lib/Target/LLVMIR/ConvertFromLLVMIR.cpp
Commit c3a47221e053a9a0697d27fc3701f29d4058e065 by craig.topper
[X86] Don't emit two X86ISD::COMI/UCOMI nodes when handling comi/ucomi
intrinsics.
We were creating two with different operand orders, and then only using
one of them.
Instead just swap the operands when needed and create a single node.
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit e211a7d2aafeeb9536f3aa9492601099655b833c by Jonas Devlieghere
Re-land "[lldb/Test] Make substrs argument to self.expect ordered."
Re-landing this now that (hopefully) all the failures this caused on the
bots have been addressed.
This patch changes the behavior of the substrs argument to self.expect.
Currently, the elements of substrs are unordered and as long as the
string appears in the output, the assertion passes.
We can be more precise by requiring that the substrings be ordered in
the way they appear. My hope is that this will make it harder to
accidentally pass a check because a string appears out of order.
Differential revision: https://reviews.llvm.org/D73766
The file was modifiedlldb/packages/Python/lldbsuite/test/commands/target/basic/TestTargetCommand.py
The file was modifiedlldb/packages/Python/lldbsuite/test/lldbtest.py
The file was modifiedlldb/packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py
Commit c1912c7542d6f49dfd6cce03193727981529db8a by Jonas Devlieghere
[lldb/Test] Use arrays instead of sets for build_and_run_expr
The file was modifiedlldb/packages/Python/lldbsuite/test/types/TestLongTypes.py
The file was modifiedlldb/packages/Python/lldbsuite/test/types/TestLongTypesExpr.py
Commit 70cea38ff7faa21e760dc9b252d968160f808d23 by Jonas Devlieghere
[lldb/Test] Sort substr for TestDataFormatterStdMap.py
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py
Commit 4c05019dc0cdf1b88bb229677f45c9a13074b84f by Jonas Devlieghere
[lldb/Test] Fix typo in TestDataFormatterStdMap.py
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py
Commit 98594a44aaa8410492d25793e1f01fb6b8bef45c by mgorny
[lldb] [ObjectFile/ELF] Fix negated seg ids on 32-bit arches
Scale segment identifier up to user_id_t before negating it.  This fixes
the identifers being wrongly e.g. 0x00000000fffffffe instead of
0xfffffffffffffffe.  Fix suggested by Pavel Labath.
This fixes 5 tests failing on i386 (PR #44748):
  lldb-shell :: ObjectFile/ELF/PT_LOAD-overlap-PT_INTERP.yaml
lldb-shell :: ObjectFile/ELF/PT_LOAD-overlap-PT_TLS.yaml
lldb-shell :: ObjectFile/ELF/PT_LOAD-overlap-section.yaml
lldb-shell :: ObjectFile/ELF/PT_LOAD.yaml
lldb-shell :: ObjectFile/ELF/PT_TLS-overlap-PT_LOAD.yaml
Differential Revision: https://reviews.llvm.org/D73914
The file was modifiedlldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
Commit 035eb393f7d6efad66831b42efa2ac8a070fedf3 by aqjune
Update TTI's getUserCost to return TCC_Free on freeze
The file was modifiedllvm/include/llvm/Analysis/TargetTransformInfoImpl.h
Commit 0c16a22a2ebd1fc4238b6bd1c6e7d4d72d496b1f by Jonas Devlieghere
[lldb/Test] Fix substr order in asan & ubsan tests
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/asan/TestMemoryHistory.py
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/ubsan/basic/TestUbsanBasic.py
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/asan/TestReportData.py
Commit 904d54de9ba9f71e937b24e04ad5941281cd50b7 by Jonas Devlieghere
[lldb/Test] Sort substr for TestDataFormatterStdMap.py (2/2)
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py
Commit 8413116bf10402eef12f556cb9d80b08faeb9890 by craig.topper
[X86] Use X86ISD::SUB instead of X86ISD::CMP in some places.
Our normal lowering for ISD::SETCC uses X86ISD::SUB to enable CSE unless
the RHS is 0. optimizeCompareInstr called by the peephole pass can turn
subs with unused results into cmps to clean this up.
This commit makes other places that create X86ISD::CMP have the same
behavior.
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit 7ef37a5f9990eb51fc0ba8e09e9abc4bc8ef0e36 by riddleriver
[mlir] Initial support for type constraints in the declarative assembly
format
Summary: This revision add support for accepting a few type constraints,
e.g. AllTypesMatch, when inferring types for operands and results. This
is used to remove the c++ parsers for several additional operations.
Differential Revision: https://reviews.llvm.org/D73735
The file was modifiedmlir/test/mlir-tblgen/op-format-spec.td
The file was modifiedmlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
The file was modifiedmlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
The file was modifiedmlir/tools/mlir-tblgen/OpFormatGen.cpp
The file was modifiedmlir/lib/Dialect/VectorOps/VectorOps.cpp
The file was modifiedmlir/include/mlir/Dialect/VectorOps/VectorOps.td
The file was modifiedmlir/include/mlir/Dialect/SPIRV/SPIRVLogicalOps.td
The file was modifiedmlir/test/Dialect/SPIRV/ops.mlir
The file was modifiedmlir/include/mlir/TableGen/OpTrait.h
The file was modifiedmlir/include/mlir/Dialect/SPIRV/SPIRVBitOps.td
The file was modifiedmlir/lib/Dialect/SPIRV/SPIRVOps.cpp
The file was modifiedmlir/include/mlir/IR/OpBase.td
Commit fbba6395171d8644e859db8e4ca1ed662a0962bc by riddleriver
[mlir][ODS] Refactor BuildableType to use $_builder as part of the
format
Summary: Currently BuildableType is assumed to be preceded by a builder.
This prevents constructing types that don't have a callable 'get' method
with the builder. This revision reworks the format to be like attribute
builders, i.e. by accepting $_builder within the format itself.
Differential Revision: https://reviews.llvm.org/D73736
The file was modifiedmlir/lib/TableGen/Type.cpp
The file was modifiedmlir/tools/mlir-tblgen/OpFormatGen.cpp
The file was modifiedmlir/include/mlir/IR/OpBase.td
Commit abe6d1174df422915958c49c0367471c2de5df7a by riddleriver
[mlir] Emit a fatal error when the assembly format is invalid
This revision makes sure that errors emitted outside of testing are
treated as fatal errors. This avoids the current silent failures that
occur when the format is invalid.
The file was modifiedmlir/tools/mlir-tblgen/OpFormatGen.cpp
The file was modifiedmlir/test/mlir-tblgen/op-format-spec.td
Commit 4581d97416129cb2346de5041efc98891b13459d by craig.topper
[X86] Remove some uncovered and possibly broken code from combineZext.
This code matches (zext (trunc (setcc_carry))) -> (and (setcc_carry), 1)
but the code never checks what type we're truncating too. An and mask of
1 would only make sense if the trunc was to MVT::i1, but we didn't check
for that.
I believe this code is a leftover from when i1 was a legal type.
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit e53bbf12132570ee6313ef500e1c715d3eab4e6f by thomasraoux
[GVN] Add GVNOption to control load-pre more fine-grained.
Adds the global (cl::opt) GVNOption enable-load-in-loop-pre in order to
control whether the optimization will be performed if the load is part
of a loop.
Patch by Hendrik Greving!
Differential Revision: https://reviews.llvm.org/D73804
The file was modifiedllvm/include/llvm/Transforms/Scalar/GVN.h
The file was modifiedllvm/lib/Transforms/Scalar/GVN.cpp
The file was addedllvm/test/Transforms/GVN/PRE/pre-load-in-loop.ll