SuccessChanges

Summary

  1. [libomptarget][amdgpu] Improve diagnostics on arch mismatch (details)
  2. [lldb][NFC] Refactor _get_bool_config_skip_if_decorator (details)
  3. De-templatify EmitCallArgs argument type checking, NFCI (details)
  4. Don't setup inalloca for swiftcc on i686-windows-msvc (details)
  5. [libomptarget][amdgpu] Robust handling of device_environment symbol (details)
  6. [libomptarget][amdgpu] Let default number of teams equal number of CUs (details)
Commit cab9f6923522475e0d2137c66622c3fa70b01d3b by jonathanchesterfield
[libomptarget][amdgpu] Improve diagnostics on arch mismatch
The file was modifiedopenmp/libomptarget/plugins/amdgpu/CMakeLists.txt
The file was modifiedopenmp/libomptarget/plugins/amdgpu/src/rtl.cpp
The file was addedopenmp/libomptarget/plugins/amdgpu/impl/get_elf_mach_gfx_name.h
The file was addedopenmp/libomptarget/plugins/amdgpu/impl/get_elf_mach_gfx_name.cpp
Commit 199ec40e7bcc8548282d803b1a43b1ae1d3b57ce by Raphael Isemann
[lldb][NFC] Refactor _get_bool_config_skip_if_decorator

NFC preparation for another patch. Also add some documentation for why the
error value is true (and not false).
The file was modifiedlldb/packages/Python/lldbsuite/test/decorators.py
Commit d7098ff29c58dd08ede8314818b7de7fd2fea4cc by rnk
De-templatify EmitCallArgs argument type checking, NFCI

This template exists to abstract over FunctionPrototype and
ObjCMethodDecl, which have similar APIs for storing parameter types. In
place of a template, use a PointerUnion with two cases to handle this.
Hopefully this improves readability, since the type of the prototype is
easier to discover. This allows me to sink this code, which is mostly
assertions, out of the header file and into the cpp file. I can also
simplify the overloaded methods for computing isGenericMethod, and get
rid of the second EmitCallArgs overload.

Differential Revision: https://reviews.llvm.org/D92883
The file was modifiedclang/lib/CodeGen/CGExprCXX.cpp
The file was modifiedclang/lib/CodeGen/CGCall.cpp
The file was modifiedclang/lib/CodeGen/CodeGenFunction.h
Commit df282215d497e15104ae9e182e083cdfa0bae3c2 by rnk
Don't setup inalloca for swiftcc on i686-windows-msvc

Swiftcall does it's own target-independent argument type classification,
since it is not designed to be ABI compatible with anything local on the
target that isn't LLVM-based. This means it never uses inalloca.
However, we have duplicate logic for checking for inalloca parameters
that runs before call argument setup. This logic needs to know ahead of
time if inalloca will be used later, and we can't move the
CGFunctionInfo calculation earlier.

This change gets the calling convention from either the
FunctionProtoType or ObjCMethodDecl, checks if it is swift, and if so
skips the stackbase setup.

Depends on D92883.

Differential Revision: https://reviews.llvm.org/D92944
The file was modifiedclang/lib/CodeGen/CGCall.cpp
The file was addedclang/test/CodeGenCXX/windows-x86-swiftcall.cpp
Commit e191d3115921d9b5b6602747bff72a1f2cf565c4 by jonathanchesterfield
[libomptarget][amdgpu] Robust handling of device_environment symbol
The file was modifiedopenmp/libomptarget/plugins/amdgpu/src/rtl.cpp
Commit c9bc414840a41aff3e83a1529ba6dd98e13ce39d by jonathanchesterfield
[libomptarget][amdgpu] Let default number of teams equal number of CUs
The file was modifiedopenmp/libomptarget/plugins/amdgpu/src/rtl.cpp