FailedChanges

Summary

  1. [DFSan] Appease the custom wrapper lint script. (details)
  2. [mlir] Remove the dependency on StandardOps from FoldUtils (details)
  3. [SmallVector] Copy new docs into Doxygen comment (details)
  4. [msan] Do not use 77 as exit code, instead use 1 (details)
  5. [WebAssembly] Support COMDAT sections in assembly syntax (details)
Commit 5ff35356f1af2bb92785b38c657463924d9ec386 by mascasa
[DFSan] Appease the custom wrapper lint script.
The file was modifiedcompiler-rt/test/dfsan/custom.cpp
Commit 186c154991e85f8d6a4a77c5add3322351862725 by riddleriver
[mlir] Remove the dependency on StandardOps from FoldUtils

OperationFolder currently uses ConstantOp as a backup when trying to materialize a constant after an operation is folded. This dependency isn't really useful or necessary given that dialects can/should provide a `materializeConstant` implementation.

Fixes PR#44866

Differential Revision: https://reviews.llvm.org/D92980
The file was modifiedmlir/lib/Transforms/Utils/FoldUtils.cpp
The file was modifiedmlir/test/mlir-tblgen/pattern.mlir
The file was modifiedmlir/test/lib/Dialect/Test/TestOps.td
The file was modifiedmlir/test/lib/Dialect/Test/TestDialect.cpp
The file was modifiedmlir/lib/Dialect/Shape/IR/Shape.cpp
Commit 10b5eaed917d6f91aa2d416c08c93697bd1d446f by scott.linder
[SmallVector] Copy new docs into Doxygen comment

Copy the `ProgrammersManual.rst` changes from D92522 to the Doxygen
comment for `SmallVector`, to hopefully encourage new uses migrating to
the no-explicit-`N` form.

Differential Revision: https://reviews.llvm.org/D93069
The file was modifiedllvm/include/llvm/ADT/SmallVector.h
Commit b1dd1a099771543cf0ca133b6342af1b3ce61a44 by eugenis
[msan] Do not use 77 as exit code, instead use 1

MSan uses 77 as exit code since it appeared with c5033786ba34 ("[msan]
MemorySanitizer runtime."). However, Test runners like the one from
Meson use the GNU standard approach where a exit code of 77 signals
that the test should be skipped [1]. As a result Meson's test runner
reports tests as skipped if MSan is enabled and finds issues:

build $ meson test
ninja: Entering directory `/home/user/code/project/build'
ninja: no work to do.
1/1 PROJECT:all / SimpleTest    SKIP           0.09s

I could not find any rationale why 77 was initially chosen, and I
found no other clang sanitizer that uses this value as exit
code. Hence I believe it is safe to change this to a safe
default. You can restore the old behavior by setting the environment
variable MSAN_OPTIONS to "exitcode=77", e.g.

export MSAN_OPTIONS="exitcode=77"

1: https://mesonbuild.com/Unit-tests.html#skipped-tests-and-hard-errors

Reviewed By: #sanitizers, eugenis

Differential Revision: https://reviews.llvm.org/D92490
The file was modifiedcompiler-rt/lib/msan/msan.cpp
Commit 4564553b8d8ab81dc21431a35275581cb42329c8 by dschuff
[WebAssembly] Support COMDAT sections in assembly syntax

This CL changes the asm syntax for section flags, making them more like ELF
(previously "passive" was the only option). Now we also allow "G" to designate
COMDAT group sections. In these sections we set the appropriate comdat flag on
function symbols, and also avoid auto-creating a new section for them.

This also adds asm-based tests for the changes D92691 to go along with
the direct-to-object tests.

Differential Revision: https://reviews.llvm.org/D92952
The file was addedllvm/test/MC/WebAssembly/comdat-sections.s
The file was modifiedllvm/lib/MC/MCParser/WasmAsmParser.cpp
The file was modifiedllvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
The file was modifiedllvm/lib/MC/WasmObjectWriter.cpp
The file was modifiedllvm/test/MC/WebAssembly/comdat.ll
The file was modifiedllvm/lib/MC/MCSectionWasm.cpp
The file was modifiedllvm/test/MC/WebAssembly/comdat-sections.ll