SuccessChanges

Summary

  1. [Hexagon] Tweak _MSC_VER workaround version (details)
  2. [VectorCombine] add test for load with offset; NFC (details)
  3. [CUDA] Do not diagnose host/device variable access in dependent types. (details)
  4. [mlir][OpFormat] Add support for emitting newlines from the custom format of an operation (details)
  5. [mlir][OpAsmParser] Add support for parsing integer literals without going through IntegerAttr (details)
Commit 55fc64bce08a30f1bf7f7ebf83df776a40700fbe by rnk
[Hexagon] Tweak _MSC_VER workaround version

My bot runs VS 2019, but it could not compile this code.

Message:
[55/2465] Building CXX object lib\Target\Hexagon\CMakeFiles\LLVMHexagonCodeGen.dir\HexagonVectorCombine.cpp.obj
FAILED: lib/Target/Hexagon/CMakeFiles/LLVMHexagonCodeGen.dir/HexagonVectorCombine.cpp.obj
...
C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.23.28105\include\map(71): error C2976: 'std::map': too few template arguments
C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.23.28105\include\map(71): note: see declaration of 'std::map'

The version in the path, 14.23, corresponds to _MSC_VER 1923, so raise
the version floor to 1924.

I have not tested with versions between 1924 and 1928 (latest), but the
latest works with the variadic version.
The file was modifiedllvm/lib/Target/Hexagon/HexagonVectorCombine.cpp
Commit 9c1765acabf10b7df7cf49456a06bbba2b33b364 by spatel
[VectorCombine] add test for load with offset; NFC
The file was modifiedllvm/test/Transforms/VectorCombine/X86/load.ll
Commit 0936655bac78f6e9cb84dc3feb30c32012100839 by tra
[CUDA] Do not diagnose host/device variable access in dependent types.

`isCUDADeviceBuiltinSurfaceType()`/`isCUDADeviceBuiltinTextureType()` do not
work on dependent types as they rely on specific type attributes.

Differential Revision: https://reviews.llvm.org/D92893
The file was modifiedclang/include/clang/Basic/Attr.td
The file was modifiedclang/test/SemaCUDA/device-use-host-var.cu
Commit c234b65cef07b38c91b9ab7dec6a35f8b390e658 by riddleriver
[mlir][OpFormat] Add support for emitting newlines from the custom format of an operation

This revision adds a new `printNewline` hook to OpAsmPrinter that allows for printing a newline within the custom format of an operation, that is then indented to the start of the operation. Support for the declarative assembly format is also added, in the form of a `\n` literal.

Differential Revision: https://reviews.llvm.org/D93151
The file was modifiedmlir/test/mlir-tblgen/op-format-spec.td
The file was modifiedmlir/test/mlir-tblgen/op-format.mlir
The file was modifiedmlir/lib/IR/AsmPrinter.cpp
The file was modifiedmlir/tools/mlir-tblgen/OpFormatGen.cpp
The file was modifiedmlir/include/mlir/IR/OpImplementation.h
The file was modifiedmlir/docs/OpDefinitions.md
The file was modifiedmlir/test/lib/Dialect/Test/TestOps.td
Commit 6bc9439f59acbcc5e46a108c2f74a4d5ffe55a3b by riddleriver
[mlir][OpAsmParser] Add support for parsing integer literals without going through IntegerAttr

Some operations use integer literals as part of their custom format that don't necessarily map to an internal IntegerAttr. This revision exposes the same `parseInteger` functions as the DialectAsmParser to allow for these operations to parse integer literals without incurring the otherwise unnecessary roundtrip through IntegerAttr.

Differential Revision: https://reviews.llvm.org/D93152
The file was modifiedmlir/include/mlir/IR/OpImplementation.h
The file was modifiedmlir/lib/Parser/DialectSymbolParser.cpp
The file was modifiedmlir/test/IR/parser.mlir
The file was modifiedmlir/lib/Parser/Parser.h
The file was modifiedmlir/test/lib/Dialect/Test/TestOps.td
The file was modifiedmlir/lib/Parser/Parser.cpp
The file was modifiedmlir/test/lib/Dialect/Test/TestDialect.cpp