SuccessChanges

Summary

  1. [IVDescriptors] Remove getConsecutiveDirection (NFC) (details)
  2. [lld-macho][nfc] Refactor to accommodate paired relocs (details)
Commit ed6a135246f01eb7a52bbe321a0b4de1d40b513d by kazu
[IVDescriptors] Remove getConsecutiveDirection (NFC)

The last use of the function was removed on Sep 18, 2016 in commit
5f8cc0c3469ba3a7aa440b43aaababa3a6274213.

The function was later moved to llvm/lib/Analysis/IVDescriptors.cpp on
Sep 12, 2018 in commit 7e98d69847aefb1028aaa7131b508f4b4e9896ae.
The file was modifiedllvm/include/llvm/Analysis/IVDescriptors.h
The file was modifiedllvm/lib/Analysis/IVDescriptors.cpp
Commit d4ec3346b1baf31819d20a8950ced8be8f66a408 by gkm
[lld-macho][nfc] Refactor to accommodate paired relocs

This is a refactor to pave the way for supporting paired-ADDEND for ARM64. The only paired reloc type for X86_64 is SUBTRACTOR. In a later diff, I will add SUBTRACTOR for both X86_64 and ARM64.

* s/`getImplicitAddend`/`getAddend`/ because it handles all forms of addend: implicit, explicit, paired.
* add predicate `bool isPairedReloc()`
* check range of `relInfo.r_symbolnum` is internal, unrelated to user-input, so use `assert()`, not `error()`
* minor cleanups & rearrangements in `InputFile::parseRelocations()`

Differential Revision: https://reviews.llvm.org/D90614
The file was modifiedlld/MachO/Arch/X86_64.cpp
The file was modifiedlld/MachO/InputFiles.cpp
The file was modifiedlld/MachO/Target.h