SuccessChanges

Summary

  1. [libObject, llvm-readobj] - Reimplement `ELFFile<ELFT>::getEntry`. (details)
  2. [clangd] Fix broken JSON test on windows (details)
Commit 8590b5ccd568764287ec5ed28567d0284ab9dbdb by grimar
[libObject, llvm-readobj] - Reimplement `ELFFile<ELFT>::getEntry`.

Currently, `ELFFile<ELFT>::getEntry` does not check an index of
an entry. Because of that the code might read past the end of the symbol
table silently. I've added a test to `llvm-readobj\ELF\relocations.test`
to demonstrate the possible issue. Also, I've added a unit test for
this method.

After this change, `getEntry` stops reporting the section index and
reuses the `getSectionContentsAsArray` method, which already has
all the validation needed. Our related warnings now provide
more and better context sometimes.

Differential revision: https://reviews.llvm.org/D93209
The file was modifiedllvm/test/tools/llvm-readobj/ELF/versym-invalid.test
The file was modifiedllvm/test/tools/llvm-readobj/ELF/relr-relocs.test
The file was modifiedllvm/test/tools/yaml2obj/ELF/sht-symtab-shndx.yaml
The file was modifiedllvm/test/tools/llvm-readobj/ELF/call-graph-profile.test
The file was modifiedllvm/test/Object/invalid.test
The file was modifiedlld/test/ELF/invalid/dynamic-section-broken.test
The file was modifiedllvm/test/tools/llvm-readobj/ELF/symbols.test
The file was modifiedllvm/tools/llvm-readobj/ELFDumper.cpp
The file was modifiedllvm/unittests/Object/ELFObjectFileTest.cpp
The file was modifiedllvm/test/tools/llvm-readobj/ELF/reloc-symbol-with-versioning.test
The file was modifiedllvm/include/llvm/Object/ELF.h
The file was modifiedllvm/test/tools/llvm-readobj/ELF/relocations.test
The file was modifiedllvm/test/tools/obj2yaml/ELF/dynamic-section.yaml
The file was modifiedllvm/test/tools/llvm-readobj/ELF/relocation-errors.test
The file was modifiedllvm/test/tools/llvm-readobj/ELF/stack-sizes.test
The file was modifiedllvm/test/tools/obj2yaml/ELF/rel-rela-section.yaml
Commit 0336ff0a17e6aec831334aeb50e6685f6b184065 by sam.mccall
[clangd] Fix broken JSON test on windows
The file was modifiedclang-tools-extra/clangd/unittests/GlobalCompilationDatabaseTests.cpp