SuccessChanges

Summary

  1. [MC][ELF] Drop MCSymbol::isExternal call sites (details)
  2. [PowerPC] Materialize i64 constants by enumerated patterns. (details)
  3. [MC][ELF] Remove unneeded MCSymbol::setExternal calls (details)
Commit e4c360a897fe062914519d331e8f1e28b2b1fbfd by i
[MC][ELF] Drop MCSymbol::isExternal call sites

ELF uses symbol bindings and MCSymbol::isExternal is not really useful.
The function is no longer used in ELF code now.
The file was modifiedllvm/lib/MC/ELFObjectWriter.cpp
Commit 29eb3dcfe628e9fc89047ceb1502e22a0831cb87 by esme.yi
[PowerPC] Materialize i64 constants by enumerated patterns.

Summary: Some constants can be handled with less instructions than our current results. And it seems our original approach is not very easy to extend. Therefore this patch proposes to materialize all 64-bit constants by enumerated patterns.
I traversed almost all constants to verified the functionality of these pattens. A traversed comparison of the number of instructions used by the original method and the new method has also been completed, where no degradation was caused by this patch. This patch also passed Bootstrap test and SPEC test.
Improvements of this patch are shown in llvm/test/CodeGen/PowerPC/constants-i64.ll

Reviewed By: steven.zhang, stefanp

Differential Revision: https://reviews.llvm.org/D92089
The file was modifiedllvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp
The file was modifiedllvm/test/CodeGen/PowerPC/negctr.ll
The file was modifiedllvm/test/CodeGen/PowerPC/combine_ext_trunc.ll
The file was modifiedllvm/test/CodeGen/PowerPC/funnel-shift.ll
The file was modifiedllvm/test/CodeGen/PowerPC/tailcall-speculatable-callee.ll
The file was modifiedllvm/test/CodeGen/PowerPC/fast-isel-pcrel.ll
The file was modifiedllvm/test/CodeGen/PowerPC/fp128-bitcast-after-operation.ll
The file was modifiedllvm/test/CodeGen/PowerPC/aix-cc-abi.ll
The file was modifiedllvm/test/CodeGen/PowerPC/pr43976.ll
The file was modifiedllvm/test/CodeGen/PowerPC/arr-fp-arg-no-copy.ll
The file was modifiedllvm/test/CodeGen/PowerPC/rematerializable-instruction-machine-licm.ll
The file was modifiedllvm/test/CodeGen/PowerPC/ori_imm32.ll
The file was modifiedllvm/test/CodeGen/PowerPC/constants-i64.ll
The file was modifiedllvm/test/CodeGen/PowerPC/pr45448.ll
The file was modifiedllvm/test/CodeGen/PowerPC/sms-grp-order.ll
The file was modifiedllvm/test/CodeGen/PowerPC/fp-strict-f128.ll
The file was modifiedllvm/test/CodeGen/PowerPC/memCmpUsedInZeroEqualityComparison.ll
The file was modifiedllvm/test/CodeGen/PowerPC/f128-fma.ll
The file was modifiedllvm/test/CodeGen/PowerPC/bperm.ll
The file was modifiedllvm/test/CodeGen/PowerPC/ori_imm64.ll
The file was modifiedllvm/test/CodeGen/PowerPC/urem-vector-lkk.ll
The file was modifiedllvm/test/CodeGen/PowerPC/fp-to-int-to-fp.ll
The file was modifiedllvm/test/CodeGen/PowerPC/srem-vector-lkk.ll
The file was modifiedllvm/test/CodeGen/PowerPC/f128-passByValue.ll
The file was modifiedllvm/test/CodeGen/PowerPC/unaligned-addressing-mode.ll
Commit 7b9890e17e9e9be4d14845f3bfe52e1a06ab032a by i
[MC][ELF] Remove unneeded MCSymbol::setExternal calls

ELF code uses symbol bindings and does not call isExternal().
The file was modifiedllvm/lib/MC/MCELFStreamer.cpp
The file was modifiedllvm/include/llvm/MC/MCSymbol.h
The file was modifiedllvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
The file was modifiedllvm/lib/Target/Sparc/MCTargetDesc/SparcMCExpr.cpp