SuccessChanges

Summary

  1. Revert "[lldb] Re-enable TestPlatformProcessConnect on macos" (details)
  2. [libomptarget][devicertl][nfc] Simplify target_atomic abstraction (details)
  3. [mlir][Linalg] NFC - Expose getSmallestBoundingIndex as an utility function (details)
  4. Reland "[PDB] Defer relocating .debug$S until commit time and parallelize it" (details)
  5. [PredicateInfo][SCCP][NewGVN] Add tests for logical and/or (NFC) (details)
  6. [lldb/Commands] Align process launch --plugin with process attach (NFC) (details)
  7. [PredicateInfo] Handle logical and/or (details)
  8. [mlir] Fix SubTensorInsertOp semantics (details)
  9. [mlir] Add ComplexDialect to SCF->GPU pass. (details)
  10. [mlir][Linalg] NFC - Fully compose map and operands when creating AffineMin in tiling. (details)
  11. [flang] Infrastructure improvements in utility routines (details)
  12. [CodeView] Emit function types in -gline-tables-only. (details)
  13. [OpenMP][NVPTX] Added forward declaration to pave the way for building deviceRTLs with OpenMP (details)
Commit 599fdfc5db8f44582ee9bd05544769268ec9b4a3 by pavel
Revert "[lldb] Re-enable TestPlatformProcessConnect on macos"

This reverts commit 079e664661770a78e30c0d27a12d50047f1b1ea8. It needs
more work.
The file was modifiedlldb/test/API/tools/lldb-server/platform-process-connect/TestPlatformProcessConnect.py
The file was modifiedlldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py
Commit fbc1dcb946553a3dc923a63288d9275eea86f918 by jonathanchesterfield
[libomptarget][devicertl][nfc] Simplify target_atomic abstraction

[libomptarget][devicertl][nfc] Simplify target_atomic abstraction

Atomic functions were implemented as a shim around cuda's atomics, with
amdgcn implementing those symbols as a shim around gcc style intrinsics.

This patch folds target_atomic.h into target_impl.h and folds amdgcn.

Further work is likely to be useful here, either changing to openmp's atomic
interface or instantiating the templates on the few used types in order to
move them into a cuda/c++ implementation file. This change is mostly to
group the remaining uses of the cuda api under nvptx' target_impl abstraction.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D95062
The file was modifiedopenmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h
The file was modifiedopenmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h
The file was modifiedopenmp/libomptarget/deviceRTLs/common/state-queuei.h
The file was modifiedopenmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt
The file was modifiedopenmp/libomptarget/deviceRTLs/common/src/loop.cu
The file was modifiedopenmp/libomptarget/deviceRTLs/common/omptargeti.h
The file was modifiedopenmp/libomptarget/deviceRTLs/common/src/libcall.cu
The file was modifiedopenmp/libomptarget/deviceRTLs/nvptx/src/target_impl.cu
The file was modifiedopenmp/libomptarget/deviceRTLs/common/src/reduction.cu
The file was removedopenmp/libomptarget/deviceRTLs/common/target_atomic.h
The file was removedopenmp/libomptarget/deviceRTLs/amdgcn/src/hip_atomics.h
Commit c075572646a9bd71ac675e20f3d75101ae7dd090 by nicolas.vasilache
[mlir][Linalg] NFC - Expose getSmallestBoundingIndex as an utility function
The file was modifiedmlir/lib/Dialect/Linalg/Utils/Utils.cpp
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Promotion.cpp
The file was modifiedmlir/include/mlir/Dialect/Linalg/Utils/Utils.h
Commit 1a9bd5b81328adf0dd5a8b4f3ad5949463e66da3 by rnk
Reland "[PDB] Defer relocating .debug$S until commit time and parallelize it"

This reverts commit 5b7aef6eb4b2930971029b984cb2360f7682e5a5 and relands
6529d7c5a45b1b9588e512013b02f891d71bc134.

The ASan error was debugged and determined to be the fault of an invalid
object file input in our test suite, which was fixed by my last change.
LLD's project policy is that it assumes input objects are valid, so I
have added a comment about this assumption to the relocation bounds
check.
The file was modifiedlld/COFF/Chunks.cpp
The file was modifiedllvm/lib/DebugInfo/PDB/Native/DbiStreamBuilder.cpp
The file was modifiedllvm/include/llvm/DebugInfo/PDB/Native/DbiModuleDescriptorBuilder.h
The file was modifiedllvm/lib/DebugInfo/PDB/Native/DbiModuleDescriptorBuilder.cpp
The file was modifiedlld/COFF/PDB.cpp
The file was modifiedlld/COFF/Chunks.h
Commit e406de77c6f33a6d3bf0b432bad1217b37605c15 by nikita.ppv
[PredicateInfo][SCCP][NewGVN] Add tests for logical and/or (NFC)

Duplicate some existing and/or tests using logical form.
The file was modifiedllvm/test/Transforms/NewGVN/condprop.ll
The file was modifiedllvm/test/Transforms/Util/PredicateInfo/testandor.ll
The file was modifiedllvm/test/Transforms/SCCP/conditions-ranges.ll
Commit 8fc9b6c2c560fc5945ce2115de345efb1617d59d by medismail.bennani
[lldb/Commands] Align process launch --plugin with process attach (NFC)

Following `7169d3a315f4cdc19c4ab6b8f20c6f91b46ba9b8`, this patch updates
the short option for the plugin command option to (`-p` to `-P`) to
align with the `process attach` command options.

The long option remains the same since there are already the same for both
commands.

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
The file was modifiedlldb/source/Commands/CommandOptionsProcessLaunch.cpp
Commit 1c6d1e57c15b59114a05b20e667517872510aaa9 by nikita.ppv
[PredicateInfo] Handle logical and/or

Teach PredicateInfo to handle logical and/or the same way as
bitwise and/or. This allows handling logical and/or inside IPSCCP
and NewGVN.
The file was modifiedllvm/lib/Transforms/Utils/PredicateInfo.cpp
The file was modifiedllvm/test/Transforms/Util/PredicateInfo/testandor.ll
The file was modifiedllvm/test/Transforms/SCCP/conditions-ranges.ll
The file was modifiedllvm/test/Transforms/NewGVN/condprop.ll
Commit 866cb26039043581d5ab8b30d5a999a7c273f361 by nicolas.vasilache
[mlir] Fix SubTensorInsertOp semantics

Like SubView, SubTensor/SubTensorInsertOp are allowed to have rank-reducing/expanding semantics. In the case of SubTensorInsertOp , the rank of offsets/sizes/strides should be the rank of the destination tensor.

Also, add a builder flavor for SubTensorOp to return a rank-reduced tensor.

Differential Revision: https://reviews.llvm.org/D95076
The file was modifiedmlir/lib/Dialect/StandardOps/IR/Ops.cpp
The file was modifiedmlir/test/IR/core-ops.mlir
The file was modifiedmlir/include/mlir/Dialect/StandardOps/IR/Ops.td
Commit b1e1bbae0e30c89251940efb0780eee6a1b79ecd by pifon
[mlir] Add ComplexDialect to SCF->GPU pass.
The file was modifiedmlir/lib/Conversion/SCFToGPU/CMakeLists.txt
The file was modifiedmlir/lib/Conversion/SCFToGPU/SCFToGPUPass.cpp
Commit 8dd58a509cc8b93a211c9b07b12e1548dc187fc3 by nicolas.vasilache
[mlir][Linalg] NFC - Fully compose map and operands when creating AffineMin in tiling.

This may simplify the composition of patterns but is otherwise NFC.
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Tiling.cpp
Commit 0996b590aaafe2de8378fd45a5094c13a4de3360 by pklausler
[flang] Infrastructure improvements in utility routines

* IsArrayElement() needs another option to control whether it
  should ignore trailing component references.
* Add IsObjectPointer().
* Add const Scope& variants of IsFunction() and IsProcedure().
* Make TypeAndShape::Characterize() work with procedure bindings.
* Handle CHARACTER length in MeasureSizeInBytes().
* Fine-tune FindExternallyVisibleObject()'s handling of dummy arguments
  to conform with Fortran 2018: only INTENT(IN) and dummy pointers
  in pure functions signify; update two tests accordingly.

Also: resolve some stylistic inconsistencies and add a missing
"const" in the expression traversal template framework.

Differential Revision: https://reviews.llvm.org/D95011
The file was modifiedflang/test/Semantics/structconst03.f90
The file was modifiedflang/lib/Evaluate/characteristics.cpp
The file was modifiedflang/include/flang/Evaluate/call.h
The file was modifiedflang/test/Semantics/structconst04.f90
The file was modifiedflang/lib/Semantics/tools.cpp
The file was modifiedflang/include/flang/Evaluate/traverse.h
The file was modifiedflang/lib/Evaluate/tools.cpp
The file was modifiedflang/include/flang/Evaluate/tools.h
Commit a3d7cee7f9bdfbe3e88e4de39a76c3d3e2690fdb by akhuang
[CodeView] Emit function types in -gline-tables-only.

This change adds function types to further differentiate between
FUNC_IDs in -gline-tables-only.

Size increase of object files in clang are
Before: 917990 kb
After:  999312 kb

Bug: https://bugs.llvm.org/show_bug.cgi?id=48432

Differential Revision: https://reviews.llvm.org/D95001
The file was modifiedclang/lib/CodeGen/CGDebugInfo.cpp
The file was modifiedclang/test/CodeGenCXX/debug-info-gline-tables-only-codeview.cpp
Commit 33a5d212c6198af2bd902bb8e4cfd0f0bec0114f by tianshilei1992
[OpenMP][NVPTX] Added forward declaration to pave the way for building deviceRTLs with OpenMP

Once we switch to build deviceRTLs with OpenMP, primitives and CUDA
intrinsics cannot be used directly anymore because `__device__` is not recognized
by OpenMP compiler. To avoid involving all CUDA internal headers we had in `clang`,
we forward declared these functions. Eventually they will be transformed into
right LLVM instrinsics.

Reviewed By: JonChesterfield

Differential Revision: https://reviews.llvm.org/D95058
The file was modifiedopenmp/libomptarget/deviceRTLs/nvptx/src/target_impl.cu