SuccessChanges

Summary

  1. [CGP] Add uaddo test with math used, SPARC/AArch64 variants. (details)
  2. [lldb][test] Remove expected failure decorator from test_copy_from_dummy_target (TestScriptedResolver) (details)
  3. [lldb] Fix another instance where we pass a nullptr as TypeSourceInfo to NonTypeTemplateParmDecl::Create (details)
  4. llvm: Use quotes around MSVC_DIA_SDK_DIR CMake variable (details)
  5. Use SETNE directly rather than SUB/SETNE 0 for stack guard check (details)
  6. [IR] Set name when inserting 'llvm::Value*' (details)
  7. [llvm-exegesis] Improve error reporting in Assembler.cpp (details)
  8. Move DFA tables into the read-only data segmant. (details)
  9. Reland "[DebugInfo] Enable the debug entry values feature by default" (details)
Commit 106ae108c18fb13e298e39dd010edcc87a10e48d by flo
[CGP] Add uaddo test with math used, SPARC/AArch64 variants.
The file was modifiedllvm/test/Transforms/CodeGenPrepare/X86/overflow-intrinsics.ll
The file was addedllvm/test/Transforms/CodeGenPrepare/AArch64/overflow-intrinsics.ll
The file was addedllvm/test/Transforms/CodeGenPrepare/SPARC/lit.local.cfg
The file was addedllvm/test/Transforms/CodeGenPrepare/SPARC/overflow-intrinsics.ll
Commit db23825970b021d0b5302d43aa5355c295c133d9 by Tatyana Krasnukha
[lldb][test] Remove expected failure decorator from test_copy_from_dummy_target (TestScriptedResolver)

This test case doesn't check that breakpoint's locations are resolved, and it passes on Windows too.
The file was modifiedlldb/test/API/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py
Commit 40b2c7f29b44e3c3e171a04593ac650aaf7c6ae6 by Raphael Isemann
[lldb] Fix another instance where we pass a nullptr as TypeSourceInfo to NonTypeTemplateParmDecl::Create

Summary:
Follow up to an issue pointed out in the review of D73808. We shouldn't just pass in a nullptr TypeSourceInfo
in case Clang decided to access it.

Reviewers: shafik, vsk

Reviewed By: shafik, vsk

Subscribers: kristof.beyls, JDevlieghere, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D73946
The file was modifiedlldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
Commit d6fe253653b7e760f94ca21d0a7ebbfeeee28777 by martin
llvm: Use quotes around MSVC_DIA_SDK_DIR CMake variable

MSVC_DIA_SDK_DIR variable will point to a path which contains spaces,
and without quotes it will fail to configure the project.
The file was modifiedllvm/cmake/config-ix.cmake
Commit b3cd44f80b8d6de76d41f1c78241d782c77cd193 by jrtc27
Use SETNE directly rather than SUB/SETNE 0 for stack guard check

Summary:
Backends should fold the subtraction into the comparison, but not all
seem to. Moreover, on targets where pointers are not integers, such as
CHERI, an integer subtraction is not appropriate. Instead we should just
compare the two pointers directly, as this should work everywhere and
potentially generate more efficient code.

Reviewers: bogner, lebedev.ri, efriedma, t.p.northover, uweigand, sunfish

Reviewed By: lebedev.ri

Subscribers: dschuff, sbc100, arichardson, jgravelle-google, hiraditya, aheejin, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D74454
The file was modifiedllvm/test/CodeGen/SystemZ/stack-guard.ll
The file was modifiedllvm/test/CodeGen/WebAssembly/stack-protector.ll
The file was modifiedllvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
The file was modifiedllvm/test/CodeGen/Thumb/stack_guard_remat.ll
Commit c30d8f7c910d9ddcaf8cab1ebea4b202bc88fcf9 by modocache
[IR] Set name when inserting 'llvm::Value*'

Summary:
I noticed a small regression in a toy project of mine after applying
D73835, in which instruction names weren't being set properly. In the
example test case included with this patch,
`llvm::IRBuilderBase::CreateAdd` returns an `llvm::Value *` that is then
passed as an argument to `llvm::IRBuilderBase::Insert`. The overloaded
function that is selected for that call then ignores the `Name`
parameter that is given. This patch addresses that issue.

Reviewers: nikic, Meinersbur, nhaehnle, fhahn, thakis, teemperor

Reviewed By: nikic, fhahn

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D74754
The file was modifiedllvm/unittests/IR/IRBuilderTest.cpp
The file was modifiedllvm/include/llvm/IR/IRBuilder.h
Commit 63bb9fee525f8f29fd9c2174fa7f15573c3d1fd7 by Milos.Stojanovic
[llvm-exegesis] Improve error reporting in Assembler.cpp

Followup to D74085.
Replace the use of `report_fatal_error()` with returning the error to
`llvm-exegesis.cpp` and handling it there.

Differential Revision: https://reviews.llvm.org/D74325
The file was modifiedllvm/tools/llvm-exegesis/lib/Assembler.cpp
The file was modifiedllvm/tools/llvm-exegesis/lib/Assembler.h
The file was modifiedllvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp
Commit 9e4b761aba01391bf3966a1a61eab6b5c76c70ad by benny.kra
Move DFA tables into the read-only data segmant.
The file was modifiedllvm/utils/TableGen/DFAPacketizerEmitter.cpp
The file was modifiedllvm/utils/TableGen/DFAEmitter.cpp
Commit a82d3e8a6e67473c94a5ce6345372748e9b61718 by djordje.todorovic
Reland "[DebugInfo] Enable the debug entry values feature by default"

This patch enables the debug entry values feature.

  - Remove the (CC1) experimental -femit-debug-entry-values option
  - Enable it for x86, arm and aarch64 targets
  - Resolve the test failures
  - Leave the llc experimental option for targets that do not
    support the CallSiteInfo yet

Differential Revision: https://reviews.llvm.org/D73534
The file was modifiedclang/lib/CodeGen/CGDebugInfo.cpp
The file was modifiedllvm/test/DebugInfo/MIR/X86/dbgcall-site-interpretation.mir
The file was modifiedclang/include/clang/Driver/CC1Options.td
The file was modifiedllvm/test/DebugInfo/MIR/X86/dbg-call-site-spilled-arg-multiple-defs.mir
The file was modifiedllvm/test/CodeGen/MIR/X86/call-site-info-error4.mir
The file was modifiedllvm/test/DebugInfo/X86/loclists-dwp.ll
The file was modifiedllvm/test/DebugInfo/X86/dbg-value-range.ll
The file was modifiedllvm/test/CodeGen/MIR/X86/call-site-info-error2.mir
The file was modifiedllvm/test/CodeGen/X86/speculative-load-hardening-indirect.ll
The file was modifiedllvm/include/llvm/CodeGen/CommandFlags.inc
The file was modifiedllvm/test/CodeGen/X86/xray-custom-log.ll
The file was modifiedllvm/test/DebugInfo/MIR/X86/entry-value-of-modified-param.mir
The file was modifiedllvm/test/tools/llvm-dwarfdump/X86/stats-dbg-callsite-info.ll
The file was modifiedllvm/lib/Target/X86/X86TargetMachine.cpp
The file was modifiedllvm/test/DebugInfo/X86/dbgcall-site-zero-valued-imms.ll
The file was modifiedclang/lib/Frontend/CompilerInvocation.cpp
The file was modifiedllvm/test/DebugInfo/MIR/X86/debug-call-site-param.mir
The file was modifiedclang/test/CodeGenCXX/dbg-info-all-calls-described.cpp
The file was modifiedllvm/test/DebugInfo/MIR/X86/call-site-gnu-vs-dwarf5-attrs.mir
The file was modifiedllvm/test/DebugInfo/MIR/X86/dbgcall-site-two-fwd-reg-defs.mir
The file was modifiedllvm/test/DebugInfo/MIR/X86/entry-values-diamond-bbs.mir
The file was modifiedllvm/test/DebugInfo/MIR/ARM/dbgcall-site-propagated-value.mir
The file was modifiedllvm/test/tools/llvm-locstats/locstats.ll
The file was modifiedllvm/test/DebugInfo/MIR/AArch64/dbgcall-site-interpretation.mir
The file was modifiedllvm/test/DebugInfo/MIR/X86/dbgcall-site-reference.mir
The file was modifiedllvm/test/DebugInfo/MIR/ARM/dbgcall-site-interpretation.mir
The file was modifiedllvm/test/DebugInfo/MIR/X86/dbgcall-site-partial-describe.mir
The file was modifiedllvm/test/DebugInfo/Sparc/entry-value-complex-reg-expr.ll
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
The file was modifiedllvm/include/llvm/Target/TargetOptions.h
The file was modifiedllvm/test/DebugInfo/MIR/SystemZ/call-site-lzer.mir
The file was modifiedllvm/test/DebugInfo/MIR/AArch64/dbgcall-site-interpret-movzxi.mir
The file was modifiedllvm/test/DebugInfo/MIR/Hexagon/live-debug-values-bundled-entry-values.mir
The file was modifiedllvm/test/DebugInfo/MIR/X86/kill-entry-value-after-diamond-bbs.mir
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfDebug.h
The file was modifiedllvm/lib/CodeGen/LiveDebugValues.cpp
The file was modifiedllvm/lib/CodeGen/MIRParser/MIRParser.cpp
The file was modifiedllvm/test/CodeGen/AArch64/arm64-anyregcc.ll
The file was modifiedllvm/test/DebugInfo/MIR/X86/dbgcall-site-reg-shuffle.mir
The file was modifiedclang/lib/CodeGen/BackendUtil.cpp
The file was modifiedllvm/test/DebugInfo/MIR/X86/propagate-entry-value-cross-bbs.mir
The file was modifiedclang/include/clang/Basic/CodeGenOptions.def
The file was modifiedllvm/test/CodeGen/X86/xray-typed-event-log.ll
The file was modifiedlldb/test/API/functionalities/param_entry_vals/basic_entry_values_x86_64/Makefile
The file was modifiedllvm/lib/CodeGen/TargetOptionsImpl.cpp
The file was modifiedllvm/test/CodeGen/X86/call-site-info-output.ll
The file was modifiedllvm/test/DebugInfo/MIR/X86/DW_OP_entry_value.mir
The file was modifiedllvm/lib/Target/AArch64/AArch64TargetMachine.cpp
The file was modifiedllvm/test/DebugInfo/MIR/Hexagon/dbgcall-site-instr-before-bundled-call.mir
The file was modifiedllvm/test/DebugInfo/MIR/X86/dbgcall-site-copy-super-sub.mir
The file was modifiedclang/test/CodeGen/debug-info-extern-call.c
The file was modifiedllvm/include/llvm/Target/TargetMachine.h
The file was modifiedllvm/test/CodeGen/MIR/X86/call-site-info-error3.mir
The file was modifiedllvm/test/DebugInfo/MIR/X86/unreachable-block-call-site.mir
The file was modifiedlldb/packages/Python/lldbsuite/test/decorators.py
The file was modifiedllvm/lib/Target/AArch64/AArch64ISelLowering.cpp
The file was modifiedllvm/test/DebugInfo/AArch64/call-site-info-output.ll
The file was modifiedllvm/test/CodeGen/AArch64/arm64-patchpoint.ll
The file was modifiedllvm/test/DebugInfo/MIR/AArch64/dbgcall-site-orr-moves.mir
The file was modifiedllvm/test/DebugInfo/X86/dbgcall-site-64-bit-imms.ll
The file was modifiedllvm/test/CodeGen/X86/statepoint-allocas.ll
The file was modifiedllvm/test/CodeGen/X86/hoist-invariant-load.ll
The file was modifiedllvm/test/CodeGen/MIR/Hexagon/bundled-call-site-info.mir
The file was modifiedllvm/test/DebugInfo/MIR/X86/multiple-param-dbg-value-entry.mir
The file was modifiedllvm/lib/CodeGen/MachineFunction.cpp
The file was modifiedllvm/test/tools/llvm-dwarfdump/X86/valid-call-site-GNU-extensions.ll
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
The file was modifiedllvm/test/CodeGen/MIR/X86/call-site-info-error1.mir
The file was modifiedllvm/test/DebugInfo/MIR/X86/dbginfo-entryvals.mir
The file was modifiedllvm/test/DebugInfo/MIR/X86/dbg-call-site-spilled-arg.mir
The file was addedllvm/test/DebugInfo/X86/no-entry-values-with-O0.ll
The file was modifiedllvm/lib/Target/ARM/ARMTargetMachine.cpp
The file was modifiedllvm/lib/Target/ARM/ARMISelLowering.cpp
The file was modifiedllvm/test/DebugInfo/X86/dbg-value-regmask-clobber.ll
The file was modifiedllvm/test/DebugInfo/MIR/ARM/if-coverter-call-site-info.mir
The file was modifiedllvm/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp
The file was modifiedllvm/test/CodeGen/X86/tail-dup-repeat.ll
The file was modifiedllvm/test/DebugInfo/ARM/call-site-info-output.ll
The file was modifiedllvm/test/tools/llvm-dwarfdump/X86/locstats.ll
The file was modifiedllvm/test/CodeGen/AArch64/arm64-tls-dynamics.ll
The file was modifiedllvm/test/DebugInfo/ARM/entry-value-multi-byte-expr.ll
The file was modifiedllvm/test/DebugInfo/MIR/X86/dbgcall-site-lea-interpretation.mir
The file was modifiedllvm/test/CodeGen/ARM/smml.ll