SuccessChanges

Changes from Git (git http://labmaster3.local/git/llvm-project.git)

Summary

  1. Explicitly specify CMAKE_AR in WinMsvc.cmake (details)
  2. Utility: ignore OS version on non-Darwin targets in `ArchSpec` (details)
  3. [X86] Add TDX instructions. (details)
  4. [X86] Parse data32 call in .code16 as CALLpcrel32 (details)
  5. Revert "[NewPM] Add callbacks to PassBuilder to run before/after parsing a pass" (details)
  6. [AMDGPU] Consider all SGPR uses as unique in constant bus verify (details)
  7. [NFC] Remove unnecessary default constructors (details)
  8. [GlobalISel][AMDGPU] Lower G_SMULH/G_UMULH (details)
  9. [lld-macho] Initial support for common symbols (details)
  10. [lld-macho] Implement and test resolution of common symbols (details)
  11. [lld-macho] Emit indirect symbol table (details)
  12. [lld-macho] Ignore `-mllvm` and its argument (details)
  13. [lld-macho] Support -weak_lx, -weak_library, -weak_framework (details)
  14. [lld-macho][NFC] Refactor syslibroot / library path lookup (details)
  15. [lld-macho][NFC] Make `!= nullptr` implicit (details)
  16. [IRSim] Adding structural comparison to IRSimilarityCandidate. (details)
  17. Revert "[IRSim] Adding structural comparison to IRSimilarityCandidate." (details)
  18. [IRSim] Adding structural comparison to IRSimilarityCandidate. (details)
Commit ee7ee71f40e904a8380d6439ac4741304b4a2dfd by smeenai
Explicitly specify CMAKE_AR in WinMsvc.cmake

As of cmake 3.18, cmake changes how it searches for compilers for
Windows (see
https://gitlab.kitware.com/cmake/cmake/-/commit/55196a1440e26917d40e6a7a3eb8d9fb323fa657)
and now finds llvm-ar instead of llvm-lib as CMAKE_AR. This explicitly
specifies CMAKE_AR as llvm-lib so the correct program is found.

Reviewed By: smeenai

Differential Revision: https://reviews.llvm.org/D88176
The file was modifiedllvm/cmake/modules/LLVMExternalProjectUtils.cmake
The file was modifiedllvm/cmake/platforms/WinMsvc.cmake
Commit 92d42b32a9b7a085fd200a56022724a77cf12a2d by Saleem Abdulrasool
Utility: ignore OS version on non-Darwin targets in `ArchSpec`

The OS version field is generally not very helpful for non-Darwin
targets.  On Linux, it identifies the kernel version which moves
out-of-sync with the userspace.  On Windows, this field actually ends up
corresponding to the Visual Studio toolset version instead of the OS
version.  Consider non-Darwin targets without an OS version to be fully
specified.

Differential Revision: https://reviews.llvm.org/D88181
Reviewed By: Jonas Devlieghere, Dave Lee
The file was modifiedlldb/source/Utility/ArchSpec.cpp
Commit bc7f6c6dd8252370e6b485b8193093004644a16d by freddy.ye
[X86] Add TDX instructions.

For more details about these instructions, please refer to the latest TDX document: https://software.intel.com/content/www/us/en/develop/articles/intel-trust-domain-extensions.html

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D88006
The file was modifiedllvm/test/MC/Disassembler/X86/x86-64.txt
The file was modifiedllvm/test/MC/X86/x86-64.s
The file was modifiedllvm/test/MC/X86/x86-32-coverage.s
The file was modifiedllvm/test/MC/Disassembler/X86/x86-32.txt
The file was addedllvm/lib/Target/X86/X86InstrTDX.td
The file was modifiedllvm/lib/Target/X86/X86InstrInfo.td
Commit 3d38a975d72c8711a123d1862e517bcbdab7d700 by i
[X86] Parse data32 call in .code16 as CALLpcrel32

Used by kexec-tools (PR46942)
In GNU as, tc-i386.c:output_jump uses 4-byte immediate if a data32 prefix is present.

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D88137
The file was modifiedllvm/test/MC/X86/x86-16.s
The file was modifiedllvm/test/MC/X86/data-prefix-fail.s
The file was modifiedllvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
Commit 29aaa188480e59f136330d77d255453e8d744b32 by aeubanks
Revert "[NewPM] Add callbacks to PassBuilder to run before/after parsing a pass"

This reverts commit 111aa4e36614d9a056cf5040d4d7bbfddeb9ebb2.
The file was modifiedllvm/include/llvm/Passes/PassBuilder.h
The file was modifiedllvm/tools/opt/NewPMDriver.cpp
The file was modifiedllvm/unittests/IR/PassBuilderCallbacksTest.cpp
The file was modifiedllvm/lib/Passes/PassBuilder.cpp
The file was modifiedpolly/lib/Support/RegisterPasses.cpp
The file was modifiedllvm/tools/llvm-opt-fuzzer/llvm-opt-fuzzer.cpp
Commit 1e0500d4f7f19b3eae0f9b6f05591a40188d8d99 by carl.ritson
[AMDGPU] Consider all SGPR uses as unique in constant bus verify

Fix the verifier so that overlapping SGPR operands are counted
independently.  We cannot assume that overlapping SGPR accesses
only count as a single constant bus use.
The exception is implicit uses which do not add to constant bus
usage (only) when overlapping.

Reviewed By: rampitec

Differential Revision: https://reviews.llvm.org/D87748
The file was addedllvm/test/CodeGen/AMDGPU/verify-constant-bus-violations.mir
The file was modifiedllvm/lib/Target/AMDGPU/SIInstrInfo.cpp
Commit 714075f9c1ac50cde20e21e559f0e29fdc848bf1 by aeubanks
[NFC] Remove unnecessary default constructors
The file was modifiedllvm/include/llvm/Passes/StandardInstrumentations.h
Commit 41d6669f1f16cc2f6cd0faf2c58447d1aa2072fa by Pushpinder.Singh
[GlobalISel][AMDGPU] Lower G_SMULH/G_UMULH

Reviewed By: arsenm, foad

Differential Revision: https://reviews.llvm.org/D85653
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/legalize-smulh.mir
The file was modifiedllvm/include/llvm/CodeGen/GlobalISel/LegalizerHelper.h
The file was modifiedllvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/legalize-umulh.mir
Commit 63ace77962543f961f1d566dd1243b1fb37129ef by jezng
[lld-macho] Initial support for common symbols

On Unix, it is traditionally allowed to write variable definitions without
initialization expressions (such as "int foo;") to header files. These are
called tentative definitions.

The compiler creates common symbols when it sees tentative definitions. When
linking the final binary, if there are remaining common symbols after name
resolution is complete, the linker converts them to regular defined symbols in
a `__common` section.

This diff implements most of that functionality, though we do not yet handle
the case where there are both common and non-common definitions of the same
symbol.

Reviewed By: #lld-macho, gkm

Differential Revision: https://reviews.llvm.org/D86909
The file was modifiedlld/MachO/Driver.cpp
The file was modifiedlld/MachO/SymbolTable.cpp
The file was modifiedlld/MachO/SyntheticSections.h
The file was modifiedlld/MachO/Symbols.h
The file was modifiedlld/MachO/SymbolTable.h
The file was modifiedlld/MachO/InputFiles.cpp
The file was addedlld/test/MachO/common-symbol-coalescing.s
Commit cd7cb0c30305501982ba37b4905bb264b3539ad0 by jezng
[lld-macho] Implement and test resolution of common symbols

Handle the case where there are both common and non-common definitions
of the same symbol. Add a bunch of tests to ensure compatibility with ld64.

Reviewed By: #lld-macho, gkm

Differential Revision: https://reviews.llvm.org/D86910
The file was modifiedlld/MachO/SymbolTable.cpp
The file was modifiedlld/test/MachO/nonweak-definition-override.s
The file was addedlld/test/MachO/common-symbol-resolution.s
Commit 5d26bd3b75538515194d9e54c76e723524c1ac18 by jezng
[lld-macho] Emit indirect symbol table

Makes it a little easier to read objdump's disassembly.

Reviewed By: #lld-macho, gkm

Differential Revision: https://reviews.llvm.org/D87178
The file was modifiedlld/MachO/SyntheticSections.h
The file was modifiedlld/MachO/Writer.cpp
The file was addedlld/test/MachO/indirect-symtab.s
The file was modifiedlld/MachO/SyntheticSections.cpp
The file was modifiedlld/MachO/OutputSection.h
The file was modifiedlld/MachO/Symbols.h
Commit 79412d6ca772c1c3913030cfef4b17f4afac110d by jezng
[lld-macho] Ignore `-mllvm` and its argument

Test Plan:

Reviewed By: #lld-macho, compnerd, MaskRay

Differential Revision: https://reviews.llvm.org/D87803
The file was modifiedlld/MachO/Options.td
The file was modifiedlld/test/MachO/silent-ignore.test
Commit 98f03908d07d06c74be5547cc0436bd89186cae2 by jezng
[lld-macho] Support -weak_lx, -weak_library, -weak_framework

They cause their corresponding libraries / frameworks to be loaded via
`LC_LOAD_WEAK_DYLIB` instead of `LC_LOAD_DYLIB`.

Reviewed By: #lld-macho, gkm

Differential Revision: https://reviews.llvm.org/D87929
The file was modifiedlld/MachO/Driver.cpp
The file was modifiedlld/MachO/Options.td
The file was modifiedlld/MachO/Writer.cpp
The file was addedlld/test/MachO/weak-import.s
The file was modifiedlld/MachO/InputFiles.h
Commit ca8752a793f1576b666fb22a74278d44725138f1 by jezng
[lld-macho][NFC] Refactor syslibroot / library path lookup

* Move computation of systemLibraryRoots into a separate function, so we
  can add more functionality to it without things becoming unwieldy
* Have `getSearchPaths` and related functions return by value instead of
  by output parameter. NRVO should ensure that performance is unaffected.

Reviewed By: #lld-macho, smeenai

Differential Revision: https://reviews.llvm.org/D87959
The file was modifiedlld/MachO/Driver.cpp
Commit 9c70281497730a7dc7df43435bf570bef1108454 by jezng
[lld-macho][NFC] Make `!= nullptr` implicit
The file was modifiedlld/MachO/Driver.cpp
The file was modifiedlld/MachO/InputFiles.cpp
The file was modifiedlld/MachO/OutputSegment.cpp
Commit b27db2bb68163fa5bcb4a8f631a305eb5adb44e5 by andrew.litteken
[IRSim] Adding structural comparison to IRSimilarityCandidate.

Just because sequences of instructions are similar to one another,
doesn't mean they are doing the same thing.

This introduces a structural check for the IRSimilarityCandidate that
compares two IRSimilarityCandidates against one another, and in each
instruction creates a mapping between the operands and results, or
checks that the existing mapping is valid.  If this check passes, it
means we have structurally similar IRSimilarityCandidates.

Tests for whether the candidates are found in
unittests/Analysis/IRSimilarityIdentifierTest.cpp.
The file was modifiedllvm/unittests/Analysis/IRSimilarityIdentifierTest.cpp
The file was modifiedllvm/include/llvm/Analysis/IRSimilarityIdentifier.h
The file was modifiedllvm/lib/Analysis/IRSimilarityIdentifier.cpp
Commit 0a8e097e72dfc148df1d9345aba52e75cdc5aa50 by andrew.litteken
Revert "[IRSim] Adding structural comparison to IRSimilarityCandidate."

This reverts commit b27db2bb68163fa5bcb4a8f631a305eb5adb44e5.
The file was modifiedllvm/include/llvm/Analysis/IRSimilarityIdentifier.h
The file was modifiedllvm/lib/Analysis/IRSimilarityIdentifier.cpp
The file was modifiedllvm/unittests/Analysis/IRSimilarityIdentifierTest.cpp
Commit d1aa143aa84e20a8cdef24a0b5ccf70941884534 by andrew.litteken
[IRSim] Adding structural comparison to IRSimilarityCandidate.

Just because sequences of instructions are similar to one another,
doesn't mean they are doing the same thing.

This introduces a structural check for the IRSimilarityCandidate that
compares two IRSimilarityCandidates against one another, and in each
instruction creates a mapping between the operands and results, or
checks that the existing mapping is valid.  If this check passes, it
means we have structurally similar IRSimilarityCandidates.

Tests for whether the candidates are found in
unittests/Analysis/IRSimilarityIdentifierTest.cpp.

Recommit of: b27db2bb68163fa5bcb4a8f631a305eb5adb44e5 for Differential
URL.

Differential Revision: https://reviews.llvm.org/D86971
The file was modifiedllvm/unittests/Analysis/IRSimilarityIdentifierTest.cpp
The file was modifiedllvm/lib/Analysis/IRSimilarityIdentifier.cpp
The file was modifiedllvm/include/llvm/Analysis/IRSimilarityIdentifier.h