FailedChanges

Summary

  1. [Hexagon] Avoid creating an empty target feature (details)
  2. [SyntaxTree] Expand support for `NestedNameSpecifier` (details)
  3. Correctly set CompilingPCH in PrecompilePreambleAction. (details)
  4. [gn build] Port e2d61ae5733 (details)
  5. [mlir][vector] Relax transfer_read/transfer_write restriction on memref operand (details)
  6. [PGO] Delete dead comdat renaming code related to GlobalAlias. NFC (details)
Commit 7406eb4f6afd8df9bd4dbb918f5e7005ba71d58c by kparzysz
[Hexagon] Avoid creating an empty target feature

If the CPU string is empty, the target feature map may end up having
an empty string inserted to it. The symptom of the problem is a warning
message:
  '+' is not a recognized feature for this target (ignoring feature)
Also, the target-features attribute in the module will have an empty
string in it.
The file was addedclang/test/CodeGen/hexagon-empty-cpu-feature.c
The file was modifiedclang/lib/Basic/Targets/Hexagon.cpp (diff)
Commit f9500cc487573c55ea37b4ee6e9162d115753a48 by ecaldas
[SyntaxTree] Expand support for `NestedNameSpecifier`

Summary:
We want NestedNameSpecifier syntax nodes to be generally supported, not
only for `DeclRefExpr` and `DependentScopedDeclRefExpr`.

To achieve this we:
* Use the `RecursiveASTVisitor`'s API to traverse
`NestedNameSpecifierLoc`s and automatically create its syntax nodes
* Add links from the `NestedNameSpecifierLoc`s to their syntax nodes.

In this way, from any semantic construct that has a `NestedNameSpecifier`,
we implicitly generate its syntax node via RAV and we can easily access
this syntax node via the links we added.
The file was modifiedclang/lib/Tooling/Syntax/BuildTree.cpp (diff)
The file was modifiedclang/unittests/Tooling/Syntax/TreeTest.cpp (diff)
The file was modifiedclang/include/clang/AST/NestedNameSpecifier.h (diff)
Commit e2d61ae5733316a14783b36c84b8e7681b0e3d59 by adamcz
Correctly set CompilingPCH in PrecompilePreambleAction.

This fixes a crash bug in clangd when used with modules. ASTWriter would
end up writing references to submodules into the PCH file, but upon
reading the submodules would not exists and
HeaderFileInfoTrait::ReadData would crash.

Differential Revision: https://reviews.llvm.org/D85532
The file was addedclang-tools-extra/clangd/unittests/ModulesTests.cpp
The file was modifiedclang/unittests/Frontend/ASTUnitTest.cpp (diff)
The file was modifiedclang-tools-extra/clangd/unittests/CMakeLists.txt (diff)
The file was modifiedclang/lib/Frontend/PrecompiledPreamble.cpp (diff)
Commit 1042f079ee658df896766bbbb84126501aa56221 by llvmgnsyncbot
[gn build] Port e2d61ae5733
The file was modifiedllvm/utils/gn/secondary/clang-tools-extra/clangd/unittests/BUILD.gn (diff)
Commit 68330ee0a977926d2f2857c62420b7729f4e45d3 by thomasraoux
[mlir][vector] Relax transfer_read/transfer_write restriction on memref operand

Relax the verifier for transfer_read/transfer_write operation so that it can
take a memref with a different element type than the vector being read/written.

This is based on the discourse discussion:
https://llvm.discourse.group/t/memref-cast/1514

Differential Revision: https://reviews.llvm.org/D85244
The file was modifiedmlir/test/Conversion/VectorToLLVM/vector-to-llvm.mlir (diff)
The file was modifiedmlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp (diff)
The file was modifiedmlir/test/Dialect/Vector/invalid.mlir (diff)
The file was modifiedmlir/test/Dialect/Vector/ops.mlir (diff)
The file was modifiedmlir/lib/Dialect/Vector/VectorOps.cpp (diff)
Commit 3b21a07fd7fd09618032db49f919cf917ef8afd7 by i
[PGO] Delete dead comdat renaming code related to GlobalAlias. NFC

A GlobalAlias is an address-taken user of its aliased function.
canRenameComdatFunc has excluded such cases.

Reviewed By: davidxl

Differential Revision: https://reviews.llvm.org/D85597
The file was modifiedllvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp (diff)
The file was modifiedllvm/test/Transforms/PGOProfile/comdat_rename.ll (diff)