FailedChanges

Summary

  1. Make linalg::ReshapeOp implement ViewLikeOpInterface (details)
  2. [MLIR][SPIRVToLLVM] SPIRV function fix and nits (details)
  3. [NFC] Add tests for boolean comparisons (details)
  4. [DAGCombiner] Rebuild (setcc x, y, ==) from (xor (xor x, y), 1) (details)
  5. [RISCV] Add error checking for extensions missing separating underscores (details)
Commit 1919c8bfe8379402401da52d84d5397233cab8b9 by herhut
Make linalg::ReshapeOp implement ViewLikeOpInterface

Summary: A reshape aliases its input memref, so it acts like a view.

Differential Revision: https://reviews.llvm.org/D83773
The file was modifiedmlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
The file was modifiedmlir/include/mlir/Dialect/Linalg/IR/LinalgOps.td
Commit d431951343cdaa301cbd72743fde8114b93f9d33 by georgemitenk0v
[MLIR][SPIRVToLLVM] SPIRV function fix and nits

This patch addresses the comments from https://reviews.llvm.org/D83030 and
https://reviews.llvm.org/D82639. `this->` is removed when not inside the
template. Also, type conversion for `spv.func` takes `convertRegionTypes()`
in order to apply type conversion on all blocks within the function.

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D83786
The file was modifiedmlir/lib/Conversion/SPIRVToLLVM/ConvertSPIRVToLLVM.cpp
Commit 2b6215f188bf862d5a551499764121d91fd6e6ea by roger.ferrer
[NFC] Add tests for boolean comparisons

They currently show that the not equal case may be improved.

See PR42876

Differential Revision: https://reviews.llvm.org/D65801
The file was addedllvm/test/CodeGen/RISCV/cmp-bool.ll
The file was addedllvm/test/CodeGen/ARM/cmp-bool.ll
The file was addedllvm/test/CodeGen/AArch64/cmp-bool.ll
The file was addedllvm/test/CodeGen/X86/cmp-bool.ll
Commit 14bc5e149d11766dee21cd679a9794fdf2e9414e by roger.ferrer
[DAGCombiner] Rebuild (setcc x, y, ==) from (xor (xor x, y), 1)

The existing code already considered this case. Unfortunately a typo in
the condition prevents it from triggering. Also the existing code, had
it run, forgot to do the folding.

This fixes PR42876.

Differential Revision: https://reviews.llvm.org/D65802
The file was modifiedllvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
The file was modifiedllvm/test/CodeGen/AArch64/cmp-bool.ll
The file was modifiedllvm/test/CodeGen/RISCV/cmp-bool.ll
The file was modifiedllvm/test/CodeGen/ARM/cmp-bool.ll
The file was modifiedllvm/test/CodeGen/X86/cmp-bool.ll
The file was modifiedllvm/test/CodeGen/WebAssembly/reg-stackify.ll
Commit de7bf722c23a1ab006bd306165c094669071577f by simon.cook
[RISCV] Add error checking for extensions missing separating underscores

Currently if two multi-letter extensions are provided in a -march=
string, the verification code checks the version of the first and
consumes the second, resulting in that part of the architecture
string being ignored. This adds a test that when a version number has
been parsed for an extension, there are no subsequent characters.

Differential Revision: https://reviews.llvm.org/D83819
The file was modifiedclang/test/Driver/riscv-arch.c
The file was modifiedclang/lib/Driver/ToolChains/Arch/RISCV.cpp