FailedChanges

Summary

  1. [CodeComplete] Add ranged for loops code pattern. (details)
  2. PR47682: Merge the DeclContext of a merged FunctionDecl before we inherit (details)
  3. Change materializeFrameBaseRegister() to return register (details)
  4. [AMDGPU] Fix FP materialization/resolve with flat scratch (details)
  5. Change static buffer to be BSS instead of DATA in HandlePacket_qSpeedTest (details)
  6. [libomptarget] Build cuda plugin without cuda installed locally (details)
  7. ADT: Use 'using' to inherit assign and append in SmallString (details)
Commit d18c3c7b18e9e78145d701c4687682848071ab98 by n.james93
[CodeComplete] Add ranged for loops code pattern.

Add code pattersn for c++ `range for` loops and objective c `for...in` loops.

Reviewed By: kadircet

Differential Revision: https://reviews.llvm.org/D95131
The file was modifiedclang/lib/Sema/SemaCodeComplete.cpp (diff)
Commit e92be7cd9f03ab3eb8c4a21e686743c2575a169a by richard
PR47682: Merge the DeclContext of a merged FunctionDecl before we inherit
default arguments.

When a function is declared with a qualified name, its eventual semantic
DeclContext may differ from the scope specified by the qualifier if it
redeclares a function in an inline namespace. In this case, we need to
update the DeclContext to be that of the previous declaration, and we
need to do so before we decide whether to inherit default arguments from
that previous declaration, because we only inherit default arguments
from declarations in the same scope.
The file was modifiedclang/lib/Sema/SemaDecl.cpp (diff)
The file was modifiedclang/test/SemaCXX/default1.cpp (diff)
Commit 607bec0bb9f787acca95f53dabe6a5c227f6b6b2 by Stanislav.Mekhanoshin
Change materializeFrameBaseRegister() to return register

The only caller of this function is in the LocalStackSlotAllocation
and it creates base register of class returned by the target's
getPointerRegClass(). AMDGPU wants to use a different reg class
here so let materializeFrameBaseRegister to just create and return
whatever it wants.

Differential Revision: https://reviews.llvm.org/D95268
The file was modifiedllvm/lib/Target/PowerPC/PPCRegisterInfo.cpp (diff)
The file was modifiedllvm/include/llvm/CodeGen/TargetRegisterInfo.h (diff)
The file was modifiedllvm/lib/Target/AArch64/AArch64RegisterInfo.cpp (diff)
The file was modifiedllvm/lib/Target/AArch64/AArch64RegisterInfo.h (diff)
The file was modifiedllvm/lib/Target/PowerPC/PPCRegisterInfo.h (diff)
The file was modifiedllvm/lib/CodeGen/LocalStackSlotAllocation.cpp (diff)
The file was modifiedllvm/lib/Target/ARM/ARMBaseRegisterInfo.cpp (diff)
The file was modifiedllvm/lib/Target/ARM/ARMBaseRegisterInfo.h (diff)
The file was modifiedllvm/lib/Target/AMDGPU/SIRegisterInfo.h (diff)
The file was modifiedllvm/lib/Target/AMDGPU/SIRegisterInfo.cpp (diff)
Commit ca904b81e6488b45cbfe846dc86f1406b8e9c03d by Stanislav.Mekhanoshin
[AMDGPU] Fix FP materialization/resolve with flat scratch

Differential Revision: https://reviews.llvm.org/D95266
The file was modifiedllvm/test/CodeGen/AMDGPU/local-stack-alloc-block-sp-reference.ll (diff)
The file was modifiedllvm/lib/Target/AMDGPU/SIRegisterInfo.cpp (diff)
The file was modifiedllvm/test/CodeGen/AMDGPU/flat-scratch.ll (diff)
Commit ad25bdcb8e4e9459886062d3855a5971af758731 by Jason Molenda
Change static buffer to be BSS instead of DATA in HandlePacket_qSpeedTest

Having this 4MB buffer with a compile-time initialized string forced it
into the DATA section and it took up 4MB of space in the binary, which
accounts for like 80% of debugserver's footprint on disk.  Change it to
BSS and strcpy in the initial value at runtime instead.

<rdar://problem/73503892>
The file was modifiedlldb/tools/debugserver/source/RNBRemote.cpp (diff)
Commit 47e95e87a3e4f738635ff965616d4e2d96bf838a by jonathanchesterfield
[libomptarget] Build cuda plugin without cuda installed locally

[libomptarget] Build cuda plugin without cuda installed locally

Compiles a new file, `plugins/cuda/dynamic_cuda/cuda.cpp`, to an object file that exposes the same symbols that the plugin presently uses from libcuda. The object file contains dlopen of libcuda and cached dlsym calls. Also provides a cuda.h containing the subset that is used.

This lets the cmake file choose between the system cuda and a dlopen shim, with no changes to rtl.cpp.

The corresponding change to amdgpu is postponed until after a refactor of the plugin to reduce the size of the hsa.h stub required

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D95155
The file was modifiedopenmp/libomptarget/plugins/cuda/CMakeLists.txt (diff)
The file was addedopenmp/libomptarget/plugins/cuda/dynamic_cuda/cuda.h
The file was addedopenmp/libomptarget/include/dlwrap.h
The file was addedopenmp/libomptarget/plugins/cuda/dynamic_cuda/cuda.cpp
Commit ba5628f2c2a9de049b80b3e276f7e05f481c49e7 by Duncan P. N. Exon Smith
ADT: Use 'using' to inherit assign and append in SmallString

Rather than reimplement, use a `using` declaration to bring in
`SmallVectorImpl<char>`'s assign and append implementations in
`SmallString`.

The `SmallString` versions were missing reference invalidation
assertions from `SmallVector`. This patch also fixes a bug in
`llvm::FileCollector::addFileImpl`, which was a copy/paste from
`clang::ModuleDependencyCollector::copyToRoot`, both caught by the
no-longer-skipped assertions.

As a drive-by, this also sinks the `const SmallVectorImpl&` versions of
these methods down into `SmallVectorImpl`, since I imagine they'd be
useful elsewhere.

Differential Revision: https://reviews.llvm.org/D95202
The file was modifiedllvm/include/llvm/ADT/SmallVector.h (diff)
The file was modifiedclang/lib/Frontend/ModuleDependencyCollector.cpp (diff)
The file was modifiedllvm/include/llvm/ADT/SmallString.h (diff)
The file was modifiedllvm/unittests/ADT/SmallVectorTest.cpp (diff)
The file was modifiedllvm/lib/Support/FileCollector.cpp (diff)