FailedChanges

Summary

  1. [libcxx-fuzzing] Fixed bug found by -Wstring-concatenation (details)
  2. [Reduce] Rewrite function body delta pass again (details)
  3. [X86] Remove a DCI.isBeforeLegalize() call from combineVSelectWithAllOnesOrZeros. (details)
  4. [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops (details)
  5. Hook up OpenBSD 64-bit PowerPC support (details)
  6. fix typo (details)
Commit 48887c4e81d47ebeaa6dc7888143cc51bd0ed7c5 by Dávid Bolvanský
[libcxx-fuzzing] Fixed bug found by -Wstring-concatenation
The file was modifiedlibcxx/test/libcxx/fuzzing/fuzzer_test.h
Commit d4c3f20285aded64e31a4faf6a5a9280352ff6af by lebedev.ri
[Reduce] Rewrite function body delta pass again

It is not enough to replace all uses of users of the function with undef,
the users, we only drop instruction users, so they may stick around.

Let's try different approach - first drop bodies for all the functions
we will drop, which should take care of blockaddress issue the previous
rewrite was dealing with; then, after dropping *all* such bodies,
replace remaining uses with undef (thus all the uses are either
outside of functions, or are in kept functions)
and then finally drop functions.

This seems to work, and passes the *existing* test coverage,
but it is possible that a new issue will be discovered later :)

A new (previously crashing) test added.
The file was modifiedllvm/tools/llvm-reduce/deltas/ReduceFunctions.cpp
The file was addedllvm/test/Reduce/remove-function-bodies-used-in-globals.ll
Commit d3153b5ca29b80d73af449727ca557eb6ccbd973 by craig.topper
[X86] Remove a DCI.isBeforeLegalize() call from combineVSelectWithAllOnesOrZeros.

This was blocking isTypeLegal call so that we could do a particular
transform on illegal types before type legalization. But the we
create a target specific node using that type. We shouldn't do
that if the type isn't legal. So I think we should just always
make sure the type is legal.

I suspect that in order to get the condition VT to not be a vector
of i1 we already completed type legalization anyway so this probably
doesn't matter much in practice.
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit 654e8aadfdda97524c463bcf3552d2ecf2feda93 by uday
[MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops

This diff attempts to resolve the TODO in `getOpIndexSet` (formerly
known as `getInstIndexSet`), which states "Add support to handle IfInsts
surronding `op`".

Major changes in this diff:

1. Overload `getIndexSet`. The overloaded version considers both
`AffineForOp` and `AffineIfOp`.
2. The `getInstIndexSet` is updated accordingly: its name is changed to
`getOpIndexSet` and its implementation is based on a new API `getIVs`
instead of `getLoopIVs`.
3. Add `addAffineIfOpDomain` to `FlatAffineConstraints`, which extracts
new constraints from the integer set of `AffineIfOp` and merges it to
the current constraint system.
4. Update how a `Value` is determined as dim or symbol for
`ValuePositionMap` in `buildDimAndSymbolPositionMaps`.

Differential Revision: https://reviews.llvm.org/D84698
The file was modifiedmlir/lib/Dialect/Affine/Transforms/LoopTiling.cpp
The file was modifiedmlir/include/mlir/Analysis/Utils.h
The file was modifiedmlir/lib/Analysis/AffineAnalysis.cpp
The file was modifiedmlir/lib/Transforms/Utils/LoopUtils.cpp
The file was modifiedmlir/lib/Analysis/Utils.cpp
The file was modifiedmlir/test/Transforms/memref-dependence-check.mlir
The file was modifiedmlir/lib/Analysis/AffineStructures.cpp
The file was modifiedmlir/include/mlir/Analysis/AffineAnalysis.h
The file was modifiedmlir/include/mlir/Analysis/AffineStructures.h
Commit 4eb4ebf76a6e26b0632968dd299d1dc6ad07e694 by brad
Hook up OpenBSD 64-bit PowerPC support
The file was modifiedclang/lib/Basic/Targets/OSTargets.h
The file was modifiedclang/test/Preprocessor/init.c
The file was modifiedclang/test/Preprocessor/init-ppc64.c
The file was modifiedclang/lib/Driver/ToolChains/Clang.cpp
The file was modifiedclang/lib/Basic/Targets.cpp
The file was modifiedclang/lib/Basic/Targets/PPC.h
The file was modifiedclang/test/Driver/ppc-abi.c
Commit 430db35bf21505015c618e292e98793e2ed49169 by brad
fix typo
The file was modifiedclang/lib/Driver/ToolChains/Clang.cpp