FailedChanges

Summary

  1. [LibFuzzer] [tests] [Darwin] Use the pthread library from the SDK (details)
  2. Revert "Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute" (details)
  3. [InstCombine] Move handling of gc.relocate in a gc.statepoint (details)
  4. Revert "[libFuzzer] Fix arguments of InsertPartOf/CopyPartOf calls in CrossOver mutator." (details)
  5. Update my email address. (details)
  6. [lldb] Fix TestAPILog.py for reproducer replay (details)
  7. [mlir][GPUToVulkan] Fix signature of bindMemRef function for f16 (details)
  8. [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD (details)
  9. Preserve the error message when MemoryBuffer creation fails (details)
  10. [PowerPC] Support constrained scalar sitofp/uitofp (details)
  11. [ASan][Darwin] Enable test on additional platforms (details)
  12. [lldb] Make it a fatal error when %lldb cannot be substituted (details)
  13. Forgot to update the test case for ppc64-tls-missing-gdld.s for 02e02f5398d0 (details)
  14. PrintStackTrace: don't symbolize if LLVM_DISABLE_SYMBOLIZATION is set (details)
  15. [llvm-mca][NFC] Refactor views to separate data collection from printing. (details)
Commit 7ed3286a512dde62ba8a72da5d148f64702434b5 by Azharuddin Mohammed
[LibFuzzer] [tests] [Darwin] Use the pthread library from the SDK
The file was modifiedcompiler-rt/lib/fuzzer/tests/CMakeLists.txt
Commit 58c305f466d1f78adb10e7295b9bc9fc192a6e09 by aaron
Revert "Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute"

This reverts commit 7a527f17776be78ec44b88e82b39afb65fc148e4.

It caused some buildbot failures:
http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage/builds/13600
http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/20294
The file was removedclang/test/Modules/Inputs/inherit-attribute/module.modulemap
The file was removedclang/test/Modules/inherit-attribute.cpp
The file was modifiedclang/lib/Serialization/ASTReaderDecl.cpp
The file was removedclang/test/Modules/Inputs/inherit-attribute/c.h
The file was removedclang/test/Modules/Inputs/inherit-attribute/a.h
The file was removedclang/test/Modules/Inputs/inherit-attribute/b.h
Commit 63d9d56a5546c4aed84c39dde797a3ba5bbfaeff by serguei.katkov
[InstCombine] Move handling of gc.relocate in a gc.statepoint

The only def for gc.relocate is a gc.statepoint. But real dependency is not
described by def-use chain. Instead this dependency is encoded by indecies
of operands in gc-live bundle of statepoint as integer constants in gc.relocate.

InstCombine operates by def-use chain. As a result when value in gc-live bundle
is simplified the gc.statepoint itself is not simplified but it might simplify dependent
gc.relocates. To trigger the optimization of gc.relocate we now unconditionally trigger
check of all dependent gc.relocates by adding them to worklist.

This CL handles of gc.relocates as process of gc.statepoint optimization considering
gc.statepoint and related gc.relocate as whole entity.

Reviewers: reames, dantrushin
Reviewed By: reames
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D85954
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
Commit 8831e34771fec4dfbe62a6e31d9bc9419a3b93c3 by Azharuddin Mohammed
Revert "[libFuzzer] Fix arguments of InsertPartOf/CopyPartOf calls in CrossOver mutator."

This reverts commit bb54bcf84970c04c9748004f3a4cf59b0c1832a7.

It is causing the value-profile-load.test test to fail on macOS.
The file was modifiedcompiler-rt/test/fuzzer/cross_over.test
The file was removedcompiler-rt/test/fuzzer/cross_over_insert.test
The file was removedcompiler-rt/test/fuzzer/cross_over_copy.test
The file was modifiedcompiler-rt/test/fuzzer/CrossOverTest.cpp
The file was modifiedcompiler-rt/lib/fuzzer/FuzzerMutate.cpp
Commit 50aae463315d4f7332400eb4b40953df67d016c8 by Dev
Update my email address.
The file was modifiedllvm/CODE_OWNERS.TXT
The file was modifiedllvm/CREDITS.TXT
Commit 08249d7f72ff8f8648c5264e090813c9c2cad466 by Jonas Devlieghere
[lldb] Fix TestAPILog.py for reproducer replay

With the log file being a build artifact we don't need to clean it up.
If this happens before the reproducer is captured, the file will be
missing from the reproducer root but being part of the mapping.
The file was modifiedlldb/test/API/api/log/TestAPILog.py
Commit 36ee9a322a44cfc5af0039a4a6f23de044e9f781 by thomasraoux
[mlir][GPUToVulkan] Fix signature of bindMemRef function for f16

Binding MemRefs of f16 needs special handling as the type is not supported on
CPU. There was a bug in the type used.

Differential Revision: https://reviews.llvm.org/D86328
The file was modifiedmlir/test/Conversion/GPUToVulkan/invoke-vulkan.mlir
The file was modifiedmlir/lib/Conversion/GPUToVulkan/ConvertLaunchFuncToVulkanCalls.cpp
Commit 02e02f5398d00c3914d87b640b5c626e211dca7a by stefanp
[LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD

The function `__tls_get_addr` is used to get the address of an object that is Thread Local Storage.
It needs to have two relocations on it.
One relocation is for the function call itself and it is either R_PPC64_REL24 or R_PPC64_REL24_NOTOC.
The other is R_PPC64_TLSGD or R_PPC64_TLSLD for the symbol that is having its address computed.

In the early days of the transition from the ELFv1 ABI that is used for big endian PowerPC Linux distributions to the ELFv2 ABI that is used for little endian PowerPC Linux distributions, there was some ambiguity in the specification of the relocations for TLS. The GNU linker has implemented support for correct handling of calls to __tls_get_addr with a missing relocation. Unfortunately, we didn't notice that the IBM XL compiler did not handle TLS according to the updated ABI until we tried linking XL compiled libraries with LLD. As a result, there is a lot of code out there in various libraries compiled with XL that have this problem.

This patch adds a new error check in LLD that makes sure calls to `__tls_get_addr` are not missing the TLSGD/TLSLD relocation.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D85994
The file was modifiedlld/ELF/Relocations.cpp
The file was addedlld/test/ELF/ppc64-tls-missing-gdld.s
Commit 670063eb220663b5a42fd4e9bd63f51d379c9aa0 by joker.eph
Preserve the error message when MemoryBuffer creation fails

Reviewed By: mehdi_amini

Differential Revision: https://reviews.llvm.org/D86326
The file was modifiedmlir/lib/ExecutionEngine/ExecutionEngine.cpp
Commit a5b7b8cce022ad66585ec48a33d6a9a66ca03731 by qiucofan
[PowerPC] Support constrained scalar sitofp/uitofp

This patch adds support for constrained scalar int to fp operations on
PowerPC. Besides, this also fixes the FP exception bit of FCFID*
instructions.

Reviewed By: steven.zhang, uweigand

Differential Revision: https://reviews.llvm.org/D81669
The file was modifiedllvm/lib/Target/PowerPC/PPCISelLowering.h
The file was modifiedllvm/test/CodeGen/PowerPC/kernel-fp-round.ll
The file was modifiedllvm/lib/Target/PowerPC/PPCISelLowering.cpp
The file was modifiedllvm/lib/Target/PowerPC/PPCInstr64Bit.td
The file was modifiedllvm/test/CodeGen/PowerPC/fp-strict-conv-f128.ll
The file was modifiedllvm/lib/Target/PowerPC/PPCInstrInfo.td
The file was modifiedllvm/lib/Target/PowerPC/PPCInstrVSX.td
The file was modifiedllvm/test/CodeGen/PowerPC/fp-strict-conv.ll
Commit cc62373915f0d8ce1bae749195027cf8f08445ad by julian.lettner
[ASan][Darwin] Enable test on additional platforms
The file was modifiedcompiler-rt/test/asan/TestCases/Darwin/dead-strip.c
Commit 57e0ef131b621dc88ad2db53a52bf86b498e49c3 by Jonas Devlieghere
[lldb] Make it a fatal error when %lldb cannot be substituted

Refuse to run the shell tests when %lldb cannot be substituted. This
prevents the test from silently running again the `lldb` in your PATH.

I noticed because when this happens, %lldb-init gets substituted with
lldb-init, which does not exists.
The file was modifiedlldb/test/Shell/helper/toolchain.py
Commit 0cadd162b7c17ec3159154fa25abad33fcf51005 by stefanp
Forgot to update the test case for ppc64-tls-missing-gdld.s for 02e02f5398d0
The file was modifiedlld/test/ELF/ppc64-tls-missing-gdld.s
Commit 06cad825cdd4c819e88eac8179a06d196304e78e by maskray
PrintStackTrace: don't symbolize if LLVM_DISABLE_SYMBOLIZATION is set

See http://lists.llvm.org/pipermail/llvm-dev/2017-June/113975.html for a related previous discussion.
Many tools install signal handlers to print stack traces and optionally
symbolize the addresses with an external program 'llvm-symbolizer' (when
searching for 'llvm-symbolizer', the directory containg the executable
is preferred over PATH).

'llvm-symbolizer' can be slow if the executable is large and/or if
llvm-symbolizer' itself is under-optimized. For example, my 'llvm-lto2' from a
-DCMAKE_BUILD_TYPE=Debug build is 443MiB. The 'llvm-symbolizer' from the same
build takes ~2s to symbolize it. (An optimized 'llvm-symbolizer' takes 0.34s).
A crashed clang may take more than 5s to symbolize a stack trace.

If a test file has several `not --crash` RUN lines. It can be very slow in a Debug build.
This patch makes `not --crash` set an environment variable to suppress symbolization.
This is similar to D33804 which uses a command line option.
I pick 'symbolization' instead of 'symbolication' because the former is
used much more commonly and its stem matches 'llvm-symbolizer'.

Also set LLVM_DISABLE_CRASH_REPORT=1, which is currently only applicable on
`__APPLE__`.

Reviewed By: dblaikie, aganea

Differential Revision: https://reviews.llvm.org/D86170
The file was modifiedllvm/utils/not/not.cpp
The file was modifiedllvm/lib/Support/Signals.cpp
The file was addedllvm/test/tools/not/disable-symbolization.test
Commit cf6adecd6a8718ee2737ca55e4cd938364b984cc by wolfgang_pieb
[llvm-mca][NFC] Refactor views to separate data collection from printing.

    Reviewed By: andreadb, lebedev.ri

    Differential Revision: https://reviews.llvm.org/D86177
The file was modifiedllvm/tools/llvm-mca/Views/SummaryView.h
The file was modifiedllvm/tools/llvm-mca/Views/InstructionInfoView.cpp
The file was modifiedllvm/tools/llvm-mca/Views/SummaryView.cpp
The file was modifiedllvm/tools/llvm-mca/Views/InstructionInfoView.h