SuccessChanges

Summary

  1. [SCEV] Still trying to fix windows buildbots (details)
  2. [lldb/Utility] Remove some Scalar type accessors (details)
  3. [lld] s/dyn_cast/isa in InputSection.cpp (details)
  4. Reland "Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)" (details)
  5. [SCEV] Still (again) trying to fix buildbots (details)
  6. Revert "Reland "Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)"" (details)
Commit 2e194fe73b6fe639aaf1f71a3cd6bd7eeb894656 by sam.parker
[SCEV] Still trying to fix windows buildbots
The file was modifiedllvm/include/llvm/Analysis/ScalarEvolutionExpressions.h
The file was modifiedllvm/lib/Analysis/ScalarEvolution.cpp
Commit 0e301fd02386e01ca93a28e8c0484447fbb440a1 by pavel
[lldb/Utility] Remove some Scalar type accessors

Now that the number of Scalar "types" has been reduced, these don't make
sense anymore.
The file was modifiedlldb/include/lldb/Utility/Scalar.h
The file was modifiedlldb/source/Utility/Scalar.cpp
Commit 3d1b0000f9da83d3f636d76b2108cd5121f4f4b0 by pavel
[lld] s/dyn_cast/isa in InputSection.cpp

Avoids a -Wunused-variable with gcc.
The file was modifiedlld/ELF/InputSection.cpp
Commit ada2e8ea67393aa8c44fe8e9d46be62df6d1c702 by Raphael Isemann
Reland "Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)"

This relands D84013 but with a test that relies on less shell features to
hopefully make the test pass on Fuchsia (where the test from the previous patch
version strangely failed with a plain "Exit code 1").

Original summary:

D81347 changes the ASTFileSignature to be an array of 20 uint8_t instead of 5 uint32_t.
However, it didn't update the code in ObjectFilePCHContainerOperations that creates
the dwoID in the module from the ASTFileSignature (`Buffer->Signature` being the
array subclass that is now `std::array<uint8_t, 20>` instead of `std::array<uint32_t, 5>`).

```
  uint64_t Signature = [..] (uint64_t)Buffer->Signature[1] << 32 | Buffer->Signature[0]
```

This code works with the old ASTFileSignature  (where two uint32_t are enough to
fill the uint64_t), but after the patch this only took two bytes from the ASTFileSignature
and only partly filled the Signature uint64_t.

This caused that the dwoID in the module ref and the dwoID in the actual module no
longer match (which in turns causes that LLDB keeps warning about the dwoID's not
matching when debugging -gmodules-compiled binaries).

This patch just unifies the logic for turning the ASTFileSignature into an uint64_t which
makes the dwoID match again (and should prevent issues like that in the future).

Reviewed By: aprantl, dang

Differential Revision: https://reviews.llvm.org/D84013
The file was addedclang/test/Modules/ModuleDebugInfoDwoId.cpp
The file was modifiedclang/include/clang/Basic/Module.h
The file was modifiedclang/lib/CodeGen/ObjectFilePCHContainerOperations.cpp
The file was addedclang/test/Modules/Inputs/DebugDwoId.h
The file was modifiedclang/test/Modules/Inputs/module.map
The file was modifiedclang/lib/CodeGen/CGDebugInfo.cpp
Commit 4ce176bed2c4f88804e7d4bb9671637d88206e78 by sam.parker
[SCEV] Still (again) trying to fix buildbots
The file was modifiedllvm/include/llvm/Analysis/ScalarEvolutionExpressions.h
Commit 2b3074c0d14cadbd9595346fc795d4a49a479a20 by Raphael Isemann
Revert "Reland "Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)""

This reverts commit ada2e8ea67393aa8c44fe8e9d46be62df6d1c702. Still breaking
on Fuchsia (and also Fedora) with exit code 1, so back to investigating.
The file was modifiedclang/include/clang/Basic/Module.h
The file was modifiedclang/test/Modules/Inputs/module.map
The file was modifiedclang/lib/CodeGen/ObjectFilePCHContainerOperations.cpp
The file was removedclang/test/Modules/Inputs/DebugDwoId.h
The file was modifiedclang/lib/CodeGen/CGDebugInfo.cpp
The file was removedclang/test/Modules/ModuleDebugInfoDwoId.cpp