FailedChanges

Summary

  1. [HeapProf] Fix bot failures from instrumentation pass (details)
  2. Reapply D70800: Fix AArch64 AAPCS frame record chain (details)
  3. [X86] Don't call hasFnAttribute and getFnAttribute for 'prefer-vector-width' and 'min-legal-vector-width' in getSubtargetImpl (details)
  4. [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics (details)
  5. GlobalISel: Remove leftover lit.local.cfg (details)
  6. [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics (details)
  7. GlobalISel: Implement known bits for G_MERGE_VALUES (details)
  8. GlobalISel: Use & operator on KnownBits (details)
  9. [SVE] Remove calls to VectorType::getNumElements from IR (details)
  10. [libc++][NFC] Define functor's call operator inline (details)
  11. [lld-macho] Disable invalid/stub-link.s test for Mac (details)
  12. [OpenMP][MLIR] Conversion pattern for OpenMP to LLVM (details)
  13. [OpenMP] Ensure testing for versions 4.5 and default - Part 2 (details)
  14. [SVE] Remove calls to VectorType::getNumElements from Transforms/Vectorize (details)
  15. [MLIR] Fixed missing constraint append when adding an AffineIfOp domain (details)
  16. [Attributor] Guarantee getAAFor not to update AA in the manifestation stage (details)
  17. [libcxx] Fix the broken test after D82657. (details)
  18. Recommit "[libFuzzer] Fix value-profile-load test." (details)
  19. [analyzer] NFC: Store the pointee/referenced type for dynamic type tracking. (details)
  20. [analyzer] pr47037: CastValueChecker: Support for the new variadic isa<>. (details)
  21. [analyzer] Fix the debug print about debug egraph dumps requiring asserts. (details)
  22. [analyzer] NFC: Fix wrong parameter name in printFormattedEntry. (details)
  23. [SVE] Remove bad call to VectorType::getNumElements() from HeapProfiler (details)
  24. [InstSimplify] SimplifyPHINode(): check that instruction is in basic block first (details)
Commit 5b9d462b7d3c41a605534a1d95ae0b8d97a661d0 by tejohnson
[HeapProf] Fix bot failures from instrumentation pass

Fix bot failure from 7ed8124d46f94601d5f1364becee9cee8538265e:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-ubuntu/builds/8533

Since we are always using dynamic shadow,
insertDynamicShadowAtFunctionEntry should always return true for
modifying the function.
The file was modifiedllvm/lib/Transforms/Instrumentation/HeapProfiler.cpp
Commit e9d9a612084b47fc4277523561d61e675370c854 by resistor
Reapply D70800: Fix AArch64 AAPCS frame record chain

Original Commit Message:
After the commit r368987 (rG643adb55769e) was landed, the frame record (FP and LR register)
may be placed in the middle of a stack frame if a function has both callee-saved
general-purpose registers and floating point registers. This will break the stack unwinders
that simply walk through the frame records (based on the guarantee from AAPCS64
"The Frame Pointer" section). This commit fixes the problem by adding the frame record offset.

Patch By: logan
Differential Revision: D70800
The file was modifiedllvm/lib/Target/AArch64/AArch64InstrInfo.cpp
The file was addedllvm/test/CodeGen/AArch64/framelayout-frame-record.mir
The file was addedllvm/test/CodeGen/AArch64/framelayout-unaligned-fp.ll
The file was addedllvm/test/CodeGen/AArch64/framelayout-fp-csr.ll
The file was modifiedllvm/lib/Target/AArch64/AArch64FrameLowering.cpp
The file was modifiedllvm/lib/Target/AArch64/AArch64MachineFunctionInfo.h
Commit ba852e1e19ab8605ed199ea125e11ed80ae15386 by craig.topper
[X86] Don't call hasFnAttribute and getFnAttribute for 'prefer-vector-width' and 'min-legal-vector-width' in getSubtargetImpl

We only need to call getFnAttribute and then check if the Attribute
is None or not.
The file was modifiedllvm/lib/Target/X86/X86TargetMachine.cpp
Commit ae1396c7d4d83366695137f69f046719fd199408 by mikhail.maltsev
[ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

This patch adjusts the following ARM/AArch64 LLVM IR intrinsics:
- neon_bfmmla
- neon_bfmlalb
- neon_bfmlalt
so that they take and return bf16 and float types. Previously these
intrinsics used <8 x i8> and <4 x i8> vectors (a rudiment from
implementation lacking bf16 IR type).

The neon_vbfdot[q] intrinsics are adjusted similarly. This change
required some additional selection patterns for vbfdot itself and
also for vector shuffles (in a previous patch) because of SelectionDAG
transformations kicking in and mangling the original code.

This patch makes the generated IR cleaner (less useless bitcasts are
produced), but it does not affect the final assembly.

Reviewed By: dmgreen

Differential Revision: https://reviews.llvm.org/D86146
The file was modifiedllvm/lib/IR/AutoUpgrade.cpp
The file was modifiedclang/test/CodeGen/aarch64-bf16-dotprod-intrinsics.c
The file was modifiedllvm/include/llvm/IR/IntrinsicsAArch64.td
The file was addedllvm/test/Bitcode/arm-bf16-upgrade.ll.bc
The file was modifiedllvm/include/llvm/IR/IntrinsicsARM.td
The file was modifiedclang/lib/CodeGen/CGBuiltin.cpp
The file was modifiedllvm/test/CodeGen/ARM/arm-bf16-dotprod-intrinsics.ll
The file was modifiedllvm/lib/Target/ARM/ARMInstrNEON.td
The file was modifiedllvm/lib/Target/AArch64/AArch64InstrFormats.td
The file was modifiedclang/test/CodeGen/arm-bf16-dotprod-intrinsics.c
The file was addedllvm/test/Bitcode/aarch64-bf16-upgrade.ll.bc
The file was addedllvm/test/Bitcode/aarch64-bf16-upgrade.ll
The file was addedllvm/test/Bitcode/arm-bf16-upgrade.ll
The file was modifiedllvm/test/CodeGen/AArch64/aarch64-bf16-dotprod-intrinsics.ll
The file was modifiedllvm/lib/Target/AArch64/AArch64InstrInfo.td
Commit 9607ccf62617c9f025d182ddf137cf80e6d5c1f0 by Matthew.Arsenault
GlobalISel: Remove leftover lit.local.cfg

The global-isel feature has been required for a long time and was
removed in c9455d3c579292e7ae5b7559ad0302d459e69a95, so this was
causing all tests to be skipped.
The file was removedllvm/test/CodeGen/X86/GlobalISel/lit.local.cfg
The file was removedllvm/test/CodeGen/AArch64/GlobalISel/lit.local.cfg
The file was removedllvm/test/CodeGen/AMDGPU/GlobalISel/lit.local.cfg
The file was removedllvm/test/CodeGen/ARM/GlobalISel/lit.local.cfg
Commit 433f2680c9792b2748a69f6d70ad47d55d0efe56 by mikhail.maltsev
[ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

Add bitcode files which got truncated to 0 length in phabricator.

Differential Revision: https://reviews.llvm.org/D86146
The file was modifiedllvm/test/Bitcode/aarch64-bf16-upgrade.ll.bc
The file was modifiedllvm/test/Bitcode/arm-bf16-upgrade.ll.bc
Commit 531f7063babc37c2bffcbbbe56219294ee407f5d by Matthew.Arsenault
GlobalISel: Implement known bits for G_MERGE_VALUES
The file was modifiedllvm/lib/CodeGen/GlobalISel/GISelKnownBits.cpp
The file was modifiedllvm/include/llvm/Support/KnownBits.h
The file was modifiedllvm/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp
Commit e53b799779b079a70f600e5cad2ab7267d66b1b7 by Matthew.Arsenault
GlobalISel: Use & operator on KnownBits

Avoid repeating for zero and one
The file was modifiedllvm/lib/CodeGen/GlobalISel/GISelKnownBits.cpp
Commit 5a55e2781ca9178900f875b86d8a1416e8001f73 by ctetreau
[SVE] Remove calls to VectorType::getNumElements from IR

Reviewed By: RKSimon

Differential Revision: https://reviews.llvm.org/D81500
The file was modifiedllvm/include/llvm/IR/GetElementPtrTypeIterator.h
The file was modifiedllvm/lib/IR/AsmWriter.cpp
The file was modifiedllvm/lib/IR/Instructions.cpp
The file was modifiedllvm/lib/IR/Verifier.cpp
The file was modifiedllvm/include/llvm/IR/Instructions.h
The file was modifiedllvm/include/llvm/IR/Constant.h
The file was modifiedllvm/lib/IR/Constants.cpp
The file was modifiedllvm/lib/IR/IRBuilder.cpp
The file was modifiedllvm/lib/IR/Function.cpp
The file was modifiedllvm/lib/IR/AutoUpgrade.cpp
The file was modifiedllvm/lib/IR/Core.cpp
The file was modifiedllvm/include/llvm/IR/MatrixBuilder.h
Commit 21a1a263a6d9c0c44ef8eb0744786e2aa5d59e53 by Louis Dionne
[libc++][NFC] Define functor's call operator inline

This fixes a mismatched visibility attribute on the call operator in
addition to making the code clearer. Given this is a simple lambda
in essence, the intent has always been to give it inline visibility.
The file was modifiedlibcxx/include/__threading_support
Commit d2b845dd6c90508c6258b4023fdf9ab5519fee3f by jezng
[lld-macho] Disable invalid/stub-link.s test for Mac

It seems to be failing on some Google Buildbots.

This diff also includes a minor fix for the install name of one of
libSystem's re-exports. I don't think it's the cause of the test
failure, though. The wrong install name just meant that the symbol
lookup failure would still happen, but it would have been caused by the
re-export not being found, instead of the arch failing to match.

Differential Revision: https://reviews.llvm.org/D86728
The file was modifiedlld/test/MachO/invalid/stub-link.s
The file was modifiedlld/test/MachO/Inputs/iPhoneSimulator.sdk/usr/lib/libSystem.tbd
Commit 875074c8a93d71b3e246da4bae983ec7524f4f28 by kiran.chandramohan
[OpenMP][MLIR] Conversion pattern for OpenMP to LLVM

Adding a conversion pattern for the parallel Operation. This will
help the conversion of parallel operation with standard dialect to
parallel operation with llvm dialect. The type conversion of the block
arguments in a parallel region are controlled by the pattern for the
parallel Operation. Without this pattern, a parallel Operation with
block arguments cannot be converted from standard to LLVM dialect.
Other OpenMP operations without regions are marked as legal. When
translation of OpenMP operations with regions are added then patterns
for these operations can also be added.
Also uses all the standard to llvm patterns. Patterns of other dialects
can be added later if needed.

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D86273
The file was modifiedmlir/include/mlir/Conversion/Passes.h
The file was modifiedmlir/lib/Conversion/CMakeLists.txt
The file was addedmlir/include/mlir/Conversion/OpenMPToLLVM/ConvertOpenMPToLLVM.h
The file was addedmlir/lib/Conversion/OpenMPToLLVM/CMakeLists.txt
The file was addedmlir/lib/Conversion/OpenMPToLLVM/OpenMPToLLVM.cpp
The file was addedmlir/test/Conversion/OpenMPToLLVM/convert-to-llvmir.mlir
The file was modifiedmlir/include/mlir/Conversion/Passes.td
Commit a1bdf8f545cf3475673f2d1aa50d572b0a6a696d by Saiyedul.Islam
[OpenMP] Ensure testing for versions 4.5 and default - Part 2

Many OpenMP Clang tests do not RUN for version 4.5 and the default
version. This second patch in the series handles test cases which
require updation in CHECK lines along with adding RUN lines for
the default version. It involves updating line number of pragmas.

Reviewed By: ABataev

Differential Revision: https://reviews.llvm.org/D85150
The file was modifiedclang/test/OpenMP/nvptx_target_teams_distribute_parallel_for_simd_codegen.cpp
The file was modifiedclang/test/OpenMP/target_parallel_codegen_registration.cpp
The file was modifiedclang/test/OpenMP/target_teams_distribute_parallel_for_simd_codegen_registration.cpp
The file was modifiedclang/test/OpenMP/target_teams_distribute_simd_codegen_registration.cpp
The file was modifiedclang/test/OpenMP/target_teams_codegen_registration.cpp
The file was modifiedclang/test/OpenMP/nvptx_target_parallel_num_threads_codegen.cpp
The file was modifiedclang/test/OpenMP/nvptx_target_parallel_proc_bind_codegen.cpp
The file was modifiedclang/test/OpenMP/target_simd_codegen_registration.cpp
The file was modifiedclang/test/OpenMP/nvptx_target_teams_distribute_parallel_for_generic_mode_codegen.cpp
The file was modifiedclang/test/OpenMP/target_parallel_if_codegen.cpp
The file was modifiedclang/test/OpenMP/target_teams_codegen.cpp
The file was modifiedclang/test/OpenMP/nvptx_target_parallel_codegen.cpp
The file was modifiedclang/test/OpenMP/nvptx_target_teams_distribute_simd_codegen.cpp
The file was modifiedclang/test/OpenMP/target_parallel_for_if_messages.cpp
The file was modifiedclang/test/OpenMP/target_teams_distribute_codegen_registration.cpp
The file was modifiedclang/test/OpenMP/nvptx_distribute_parallel_generic_mode_codegen.cpp
The file was modifiedclang/test/OpenMP/nvptx_target_simd_codegen.cpp
The file was modifiedclang/test/OpenMP/target_parallel_for_simd_codegen_registration.cpp
The file was modifiedclang/test/OpenMP/nvptx_target_teams_distribute_parallel_for_codegen.cpp
The file was modifiedclang/test/OpenMP/target_parallel_for_codegen_registration.cpp
Commit 5e63083435a96c92a25c4f6d088dd1776d59e8aa by ctetreau
[SVE] Remove calls to VectorType::getNumElements from Transforms/Vectorize

Reviewed By: spatel

Differential Revision: https://reviews.llvm.org/D82056
The file was modifiedllvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
The file was modifiedllvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
The file was modifiedllvm/lib/Transforms/Vectorize/LoopVectorize.cpp
The file was modifiedllvm/lib/Transforms/Vectorize/VectorCombine.cpp
Commit 28a7dfa33d979e5ff3ed2d975c71b08d611fe6b6 by uday
[MLIR] Fixed missing constraint append when adding an AffineIfOp domain

The prior diff that introduced `addAffineIfOpDomain` missed appending
constraints from the ifOp domain. This revision fixes this problem.

Differential Revision: https://reviews.llvm.org/D86421
The file was modifiedmlir/test/Transforms/memref-dependence-check.mlir
The file was modifiedmlir/lib/Analysis/AffineStructures.cpp
Commit c5e6872ec6e5269a6d92098765eec266ed4ce4ae by okuraofvegetable
[Attributor] Guarantee getAAFor not to update AA in the manifestation stage

If we query an AA with `Attributor::getAAFor` in `AbstractAttribute::manifest`, the AA may be updated.
This patch makes use of the phase flag in Attributor, and handle `getAAFor` behavior according to the flag.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D86635
The file was modifiedllvm/lib/Transforms/IPO/Attributor.cpp
The file was modifiedllvm/include/llvm/Transforms/IPO/Attributor.h
Commit 3f8a0ecdaa634e4ef9ec29665db7c82b874422b5 by hokein.wu
[libcxx] Fix the broken test after D82657.

Differential Revision: https://reviews.llvm.org/D86685
The file was modifiedlibcxx/test/libcxx/utilities/memory/util.smartptr/util.smartptr.shared/function_type_default_deleter.fail.cpp
Commit 52f1df09237312eac044f84ca4c4f9e49aea0b9b by dokyungs
Recommit "[libFuzzer] Fix value-profile-load test."

value-profile-load.test needs adjustment with a mutator change in
bb54bcf84970c04c9748004f3a4cf59b0c1832a7, which reverted as of now, but will be
recommitted after landing this patch.

This patch makes value-profile-load.test more friendly to (and aware of) the
current value profiling strategy, which is based on the hamming as well as the
absolute distance. To this end, this patch adjusts the set of input values that
trigger an expected crash. More specifically, this patch now uses a single value
0x01effffe as a crashing input, because this value is close to values like
{0x1ffffff, 0xffffff, ...}, which are very likely to be added to the corpus per
the current hamming- and absolute-distance-based value profiling strategy. Note
that previously the crashing input values were {1234567 * {1, 2, ...}, s.t. <
INT_MAX}.

Every byte in the chosen value 0x01effeef is intentionally different; this was
to make it harder to find the value without the intermediate inputs added to the
corpus by the value profiling strategy.

Also note that LoadTest.cpp now uses a narrower condition (Size != 8) for
initial pruning of inputs, effectively preventing libFuzzer from generating
inputs longer than necessary and spending time on mutating such long inputs in
the corpus - a functionality not meant to be tested by this specific test.

Differential Revision: https://reviews.llvm.org/D86247
The file was modifiedcompiler-rt/test/fuzzer/value-profile-load.test
The file was modifiedcompiler-rt/test/fuzzer/LoadTest.cpp
Commit 5a9e7789396e7618c1407aafc329e00584437a2f by Artem Dergachev
[analyzer] NFC: Store the pointee/referenced type for dynamic type tracking.

The successfulness of a dynamic cast depends only on the C++ class, not the pointer or reference. Thus if *A is a *B, then &A is a &B,
const *A is a const *B etc. This patch changes DynamicCastInfo to store
and check the cast between the unqualified pointed/referenced types.
It also removes e.g. SubstTemplateTypeParmType from both the pointer
and the pointed type.

Differential Revision: https://reviews.llvm.org/D85752
The file was modifiedclang/test/Analysis/cast-value-state-dump.cpp
The file was modifiedclang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp
The file was modifiedclang/lib/StaticAnalyzer/Core/DynamicType.cpp
Commit 4448affede5100658530aea8793ae7a7bc05a110 by Artem Dergachev
[analyzer] pr47037: CastValueChecker: Support for the new variadic isa<>.

llvm::isa<>() and llvm::isa_and_not_null<>() template functions recently became
variadic. Unfortunately this causes crashes in case of isa_and_not_null<>()
and incorrect behavior in isa<>(). This patch fixes this issue.

Differential Revision: https://reviews.llvm.org/D85728
The file was modifiedclang/test/Analysis/cast-value-logic.cpp
The file was modifiedclang/test/Analysis/cast-value-notes.cpp
The file was modifiedclang/test/Analysis/Inputs/llvm.h
The file was modifiedclang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp
Commit 37c21dbb3a3209c31f22070c58f22c77357fa777 by Artem Dergachev
[analyzer] Fix the debug print about debug egraph dumps requiring asserts.

There's no need to remind people about that when clang *is* built with asserts.

Differential Revision: https://reviews.llvm.org/D86334
The file was modifiedclang/lib/StaticAnalyzer/Core/ExprEngine.cpp
Commit 6e26e49edf0d509fb3e76d984f2cbc8288fd6dc5 by Artem Dergachev
[analyzer] NFC: Fix wrong parameter name in printFormattedEntry.

Parameters were in a different order in the header and in the implementation.

Fix surrounding comments a bit.

Differential Revision: https://reviews.llvm.org/D86691
The file was modifiedclang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
The file was modifiedclang/lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
Commit 035833ae42aa6c597f28b6e0e1118508e26f175c by ctetreau
[SVE] Remove bad call to VectorType::getNumElements() from HeapProfiler

Reviewed By: tejohnson

Differential Revision: https://reviews.llvm.org/D86727
The file was modifiedllvm/lib/Transforms/Instrumentation/HeapProfiler.cpp
Commit b85f91fdced8e94c43f3350152bcb2ccfa71ef14 by lebedev.ri
[InstSimplify] SimplifyPHINode(): check that instruction is in basic block first

As pointed out in post-commit review, this can legally be called
on instructions that are not inserted into basic blocks,
so don't blindly assume that there is basic block.
The file was modifiedllvm/lib/Analysis/InstructionSimplify.cpp