FailedChanges

Summary

  1. Revert "[FileCheck] Move FileCheck implementation out of LLVMSupport into its own library" (details)
  2. [llvm-readobj/elf] - Don't fail when dumping an archive with a member that can't be recognized. (details)
  3. [lldb] Fix TestCompletion's pid completion failing randomly (details)
  4. [lldb][NFC] Remove trailing whitespace in TestCompletion (details)
Commit ed89eb3571e16307c16d2e5371855437835a40cc by Raphael Isemann
Revert "[FileCheck] Move FileCheck implementation out of LLVMSupport into its own library"

This reverts commit e9a3d1a401b07cbf7b11695637f1b549782a26cd. Seems the new
FileCheck library doesn't link on some bots. Reverting for now.
The file was removedllvm/lib/FileCheck/FileCheckImpl.h
The file was modifiedllvm/utils/gn/secondary/llvm/unittests/CodeGen/GlobalISel/BUILD.gn
The file was modifiedllvm/lib/Support/CMakeLists.txt
The file was modifiedllvm/unittests/Support/CMakeLists.txt
The file was modifiedllvm/utils/FileCheck/CMakeLists.txt
The file was modifiedllvm/unittests/CMakeLists.txt
The file was addedllvm/include/llvm/Support/FileCheck.h
The file was addedllvm/unittests/Support/FileCheckTest.cpp
The file was removedllvm/utils/gn/secondary/llvm/unittests/FileCheck/BUILD.gn
The file was modifiedllvm/utils/gn/secondary/llvm/unittests/Support/BUILD.gn
The file was removedllvm/lib/FileCheck/FileCheck.cpp
The file was addedllvm/lib/Support/FileCheck.cpp
The file was removedllvm/unittests/FileCheck/CMakeLists.txt
The file was modifiedllvm/lib/CMakeLists.txt
The file was modifiedllvm/utils/FileCheck/FileCheck.cpp
The file was removedllvm/utils/gn/secondary/llvm/lib/FileCheck/BUILD.gn
The file was modifiedllvm/utils/gn/secondary/llvm/unittests/BUILD.gn
The file was removedllvm/lib/FileCheck/CMakeLists.txt
The file was modifiedllvm/unittests/CodeGen/GlobalISel/GISelMITest.h
The file was removedllvm/unittests/FileCheck/FileCheckTest.cpp
The file was modifiedllvm/include/llvm/module.modulemap
The file was removedllvm/include/llvm/FileCheck/FileCheck.h
The file was addedllvm/lib/Support/FileCheckImpl.h
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Support/BUILD.gn
The file was modifiedllvm/unittests/CodeGen/GlobalISel/CMakeLists.txt
Commit 506f89ce914e99233a66fee8c1ec070b668d1759 by grimar
[llvm-readobj/elf] - Don't fail when dumping an archive with a member that can't be recognized.

Imagine we have an archive that has 3 objects in the following order:
<valid known object>,<unknown object> and <valid known object>.

Currently llvm-readelf/obj report an error and stops dumping in the middle.
This patch changes the error reported to warning.

Differential revision: https://reviews.llvm.org/D86771
The file was modifiedllvm/test/tools/llvm-readobj/archive.test
The file was modifiedllvm/tools/llvm-readobj/llvm-readobj.cpp
Commit b51321ccc894f6ed512c27cb43b1f04883d5ed0e by Raphael Isemann
[lldb] Fix TestCompletion's pid completion failing randomly

TestCompletion is randomly failing on some bots. The error message however states
that the computed completions actually do contain the expected pid we're
looking for, so there shouldn't be any test failure.

The reason for that turns out to be that complete_from_to is actually used
for testing two different features. It can be used for testing what the
common prefix for the list of completions is and *also* for checking all the
possible completions that are returned for a command. Which one of the two
things should be checked can't be defined by a parameter to the function, but
is instead guessed by the test method instead based on the results that were
returned. If there is a common prefix in all completions, then that prefix
is searched and otherwise all completions are searched.

For TestCompletion's pid test this behaviour leads to the strange test failures.
If all the pid's that our test LLDB can see have a common prefix (e.g., it
can only see pids [123, 122, 10004, 10000] -> common prefix '1'), then
complete_from_to check that the common prefix contains our pid, which is
always fails ('1' doesn't contain '123' or any other valid pid). If there
isn't a common prefix (e.g., pids are [123, 122, 10004, 777]) then
complete_from_to will check the list of completions instead which works correctly.

This patch is fixing this by adding a simple check method that doesn't
have this behaviour and is simply searching the returned list of completions.
This should get the bots green while I'm working on a proper fix that fixes
complete_from_to.
The file was modifiedlldb/test/API/functionalities/completion/TestCompletion.py
The file was modifiedlldb/packages/Python/lldbsuite/test/lldbtest.py
Commit da0d43d90a4f931466ecdd9bc27c47fa45cc6c21 by Raphael Isemann
[lldb][NFC] Remove trailing whitespace in TestCompletion
The file was modifiedlldb/test/API/functionalities/completion/TestCompletion.py