SuccessChanges

Summary

  1. [llvm-readobj][test] - Remove amdgpu-elf-definitions.test (details)
  2. [libcxx] Link target `cxx_external_threads` to `cxx-headers` for BUILD_EXTERNAL_THREAD_LIBRARY (details)
  3. [llvm-dwarfdump][test] Add tests for dumping the .debug_line_str section. (details)
  4. [NFC][Asan] Format includes (details)
  5. [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl() (details)
  6. Reland [FileCheck] Move FileCheck implementation out of LLVMSupport into its own library (details)
Commit ca233be2f0a6623d835d33f1453d3248448ba606 by grimar
[llvm-readobj][test] - Remove amdgpu-elf-definitions.test

`amdgpu-elf-definitions.test` is a file that tests
`Format`, 'OS/ABI' and 'Machine' fields printed for EM_AMDGPU.
It uses a precompiled object.

It is not needed to have it, because:
1) We already test formats in `file-header-format.test` + `llvm/unittests/Object/ELFObjectFileTest.cpp`.
2) We test 'OS/ABI' in `file-header-os-abi.test` for all possible values.
3) We test machine types in `file-header-machine-types.test`

In addition we have `amdgpu-elf-headers.test` which tests EM_AMDGPU specific flags. I.e.
it also tests the fact that llvm-readobj/elf are able to dump such objects.

This patch removes the test case and the corresponding binary.

Differential revision: https://reviews.llvm.org/D86774
The file was removedllvm/test/tools/llvm-readobj/ELF/amdgpu-elf-definitions.test
The file was removedllvm/test/tools/llvm-readobj/ELF/Inputs/trivial.obj.elf-amdhsa-gfx803
Commit 722db5c0b4e8dffabbd97265e5ea9edac05548ae by mikhail.maltsev
[libcxx] Link target `cxx_external_threads` to `cxx-headers` for BUILD_EXTERNAL_THREAD_LIBRARY

Fix compilation of libcxx when using -DLIBCXX_BUILD_EXTERNAL_THREAD_LIBRARY. Target `cxx_external_threads` gets linked to `cxx-headers` to include all needed headers and flags.

Reviewed By: #libc, ldionne

Differential Revision: https://reviews.llvm.org/D86773
The file was modifiedlibcxx/src/CMakeLists.txt
Commit ea1f5133cc572720bbb9a90d271a59d99a55845d by Xing
[llvm-dwarfdump][test] Add tests for dumping the .debug_line_str section.

This patch adds tests for dumping the .debug_line_str section. The
dumper of the debug_line_str section is able to write nonprintable
strings as escaped chars while the dumper of the debug_str and
debug_str.dwo sections cannot. I will fix them and add tests for them
in a follow-up patch.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D86916
The file was addedllvm/test/tools/llvm-dwarfdump/debug-line-str.yaml
Commit bd6ee511502f89319f8e50ad883cfe0406202ce1 by Vitaly Buka
[NFC][Asan] Format includes
The file was modifiedcompiler-rt/lib/asan/asan_allocator.cpp
Commit 2114f71aaa8dc2e75fe9cd79aa4d72d164e9b95d by a.bataev
[OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

Function Sema::isOpenMPGlobalCapturedDecl() has a parameter `unsigned Level`,
but use `Level >= 0` as the condition of `while`, thus cause an infinite loop.
Fix by changing the loop condition to `Level > 0`.

Reviewed By: ABataev

Differential Revision: https://reviews.llvm.org/D86858
The file was modifiedclang/lib/Sema/SemaOpenMP.cpp
Commit 5ffd940ac02a8e000691c45a6dc4f69d0198e675 by Raphael Isemann
Reland [FileCheck] Move FileCheck implementation out of LLVMSupport into its own library

This relands e9a3d1a401b07cbf7b11695637f1b549782a26cd which was originally
missing linking LLVMSupport into LLMVFileCheck which broke the SHARED_LIBS build.

Original summary:

The actual FileCheck logic seems to be implemented in LLVMSupport. I don't see a
good reason for having FileCheck implemented there as it has a very specific use
while LLVMSupport is a dependency of pretty much every LLVM tool there is. In
fact, the only use of FileCheck I could find (outside the FileCheck tool and the
FileCheck unit test) is a single call in GISelMITest.h.

This moves the FileCheck logic to its own LLVMFileCheck library. This way only
FileCheck and the GlobalISelTests now have a dependency on this code.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D86344
The file was modifiedllvm/unittests/CMakeLists.txt
The file was addedllvm/lib/FileCheck/FileCheck.cpp
The file was addedllvm/lib/FileCheck/CMakeLists.txt
The file was addedllvm/unittests/FileCheck/CMakeLists.txt
The file was modifiedllvm/unittests/CodeGen/GlobalISel/GISelMITest.h
The file was modifiedllvm/utils/gn/secondary/llvm/unittests/Support/BUILD.gn
The file was addedllvm/include/llvm/FileCheck/FileCheck.h
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Support/BUILD.gn
The file was modifiedllvm/unittests/Support/CMakeLists.txt
The file was modifiedllvm/include/llvm/module.modulemap
The file was modifiedllvm/utils/FileCheck/FileCheck.cpp
The file was removedllvm/lib/Support/FileCheckImpl.h
The file was modifiedllvm/lib/Support/CMakeLists.txt
The file was removedllvm/unittests/Support/FileCheckTest.cpp
The file was modifiedllvm/utils/FileCheck/CMakeLists.txt
The file was addedllvm/utils/gn/secondary/llvm/unittests/FileCheck/BUILD.gn
The file was modifiedllvm/unittests/CodeGen/GlobalISel/CMakeLists.txt
The file was modifiedllvm/utils/gn/secondary/llvm/unittests/BUILD.gn
The file was modifiedllvm/utils/gn/secondary/llvm/unittests/CodeGen/GlobalISel/BUILD.gn
The file was addedllvm/lib/FileCheck/FileCheckImpl.h
The file was removedllvm/include/llvm/Support/FileCheck.h
The file was removedllvm/lib/Support/FileCheck.cpp
The file was addedllvm/unittests/FileCheck/FileCheckTest.cpp
The file was addedllvm/utils/gn/secondary/llvm/lib/FileCheck/BUILD.gn
The file was modifiedllvm/lib/CMakeLists.txt