FailedChanges

Summary

  1. [ImplicitNullChecks] NFC: Separated out checks and added comments (details)
  2. [ImplicitNullChecks] NFC: Refactor dependence safety check (details)
  3. [lldb/Target] Add custom interpreter option to `platform shell` (details)
Commit 6f7737c46811993c0ed9b9143cbe4cb49dcf1d03 by anna
[ImplicitNullChecks] NFC: Separated out checks and added comments

Separated out some checks in isSuitableMemoryOp and added comments
explaining why some of those checks are done.

Tests-Run:X86 implicit null checks tests.
The file was modifiedllvm/lib/CodeGen/ImplicitNullChecks.cpp
Commit 425573a2fa2dc5666273944a584acdb286447b66 by anna
[ImplicitNullChecks] NFC: Refactor dependence safety check

After computing dependence, we check if it is safe to hoist by
identifying if it clobbers any liveIns in the sibling block (NullSucc).
This check is moved to its own function which will be used in the
soon-to-be modified dependence checking algorithm for implicit null
checks pass.

Tests-Run: lit tests on X86/implicit-*
The file was modifiedllvm/lib/CodeGen/ImplicitNullChecks.cpp
Commit addb5148f58d710fcaba04bb2afec8006ae8ac15 by medismail.bennani
[lldb/Target] Add custom interpreter option to `platform shell`

This patch adds the ability to use a custom interpreter with the
`platform shell` command. If the user set the `-s|--shell` option
with the path to a binary, lldb passes it down to the platform's
`RunShellProcess` method and set it as the shell to use in
`ProcessLaunchInfo to run commands.

Note that not all the Platforms support running shell commands with
custom interpreters (i.e. RemoteGDBServer is only expected to use the
default shell).

This patch also makes some refactoring and cleanups, like swapping
CString for StringRef when possible and updating `SBPlatformShellCommand`
with new methods and a new constructor.

rdar://67759256

Differential Revision: https://reviews.llvm.org/D86667

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
The file was modifiedlldb/include/lldb/Target/RemoteAwarePlatform.h
The file was modifiedlldb/source/Commands/CommandObjectPlatform.cpp
The file was modifiedlldb/source/Host/macosx/objcxx/Host.mm
The file was modifiedlldb/test/API/commands/platform/basic/TestPlatformCommand.py
The file was modifiedlldb/source/Host/common/Host.cpp
The file was modifiedlldb/include/lldb/Host/Host.h
The file was modifiedlldb/include/lldb/Target/Platform.h
The file was addedlldb/test/API/commands/platform/basic/myshell.c
The file was modifiedlldb/include/lldb/API/SBPlatform.h
The file was modifiedlldb/source/Target/Platform.cpp
The file was modifiedlldb/source/Target/RemoteAwarePlatform.cpp
The file was modifiedlldb/bindings/interface/SBPlatform.i
The file was modifiedlldb/source/API/SBPlatform.cpp
The file was modifiedlldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
The file was addedlldb/test/API/commands/platform/basic/Makefile
The file was modifiedlldb/source/Commands/Options.td
The file was modifiedlldb/test/API/commands/platform/basic/TestPlatformPython.py
The file was modifiedlldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.h
The file was modifiedlldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
The file was modifiedlldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h