FailedChanges

Summary

  1. [lldb/Host] Add missing proc states (details)
  2. [mlir] Extend BufferAssignmentTypeConverter with result conversion callbacks (details)
  3. [X86][SSE] Fold vselect(pshufb,pshufb) -> or(pshufb,pshufb) (details)
  4. [ms] [llvm-ml] Add support for line continuations in MASM (details)
  5. [IRGen] Fix an assert when __attribute__((used)) is used on an ObjC method (details)
  6. Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin (details)
Commit c5aa63dd560b9cf5825c1e4da2a9ee53dbd772f3 by rupprecht
[lldb/Host] Add missing proc states

The /proc/<pid>/status parsing is missing a few cases:
- Idle
- Parked
- Dead

If we encounter an unknown proc state, this leads to an msan warning. In reality, we only check that the state != Zombie, so it doesn't really matter that we handle all cases, but handle them anyway (current list: [1]). Also explicitly set it to unknown if we encounter an unknown state. There will still be an msan warning if the proc entry has no `State:` line, but that should not happen.

Use a StringSwitch to make the handling of proc states a little more compact.

[1] https://github.com/torvalds/linux/blob/master/fs/proc/array.c

Reviewed By: labath

Differential Revision: https://reviews.llvm.org/D86818
The file was modifiedlldb/source/Host/linux/Host.cpp
Commit 39cf83cc78ff0a017fb9de27d45b87217aa6f558 by ehsan.nadjaran_toosi
[mlir] Extend BufferAssignmentTypeConverter with result conversion callbacks

In this PR, the users of BufferPlacement can configure
BufferAssginmentTypeConverter. These new configurations would give the user more
freedom in the process of converting function signature, and return and call
operation conversions.

These are the new features:
    - Accepting callback functions for decomposing types (i.e. 1 to N type
    conversion such as unpacking tuple types).
    - Defining ResultConversionKind for specifying whether a function result
    with a certain type should be appended to the function arguments list or
    should be kept as function result. (Usage:
    converter.setResultConversionKind<MemRefType>(AppendToArgumentList))
    - Accepting callback functions for composing or decomposing values (i.e. N
    to 1 and 1 to N value conversion).

Differential Revision: https://reviews.llvm.org/D85133
The file was modifiedmlir/test/lib/Transforms/TestBufferPlacement.cpp
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/TensorsToBuffers.cpp
The file was modifiedmlir/test/Transforms/buffer-placement-preparation-allowed-memref-results.mlir
The file was modifiedmlir/include/mlir/Transforms/BufferPlacement.h
The file was modifiedmlir/test/Transforms/buffer-placement-preparation.mlir
The file was modifiedmlir/lib/Transforms/BufferPlacement.cpp
The file was modifiedmlir/test/lib/Dialect/Test/TestOps.td
Commit 888049b97a7495ba669020522bcae6691287bd9a by llvm-dev
[X86][SSE] Fold vselect(pshufb,pshufb) -> or(pshufb,pshufb)

If the PSHUFBs have no other uses, then we can force the unselected elements to zero to OR them instead, avoiding both an extra mask load and a costly variable blend.

Eventually we should try to bring this into shuffle combining, once we can more easily convert between shuffles + select patterns.
The file was modifiedllvm/test/CodeGen/X86/vector-shuffle-combining.ll
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
The file was modifiedllvm/test/CodeGen/X86/vector-shuffle-256-v16.ll
The file was modifiedllvm/test/CodeGen/X86/vector-shuffle-256-v32.ll
Commit ddd48cdba690fdeefc6ad02a912b63bdb66401b4 by epastor
[ms] [llvm-ml] Add support for line continuations in MASM

Add support for line continuations (the "backslash operator") in MASM by modifying the Parser's Lex method.

Reviewed By: thakis

Differential Revision: https://reviews.llvm.org/D83347
The file was modifiedllvm/lib/MC/MCParser/MasmParser.cpp
The file was addedllvm/test/tools/llvm-ml/line_continuations.test
Commit 8ff44e644bb70dfb8decc397a42679df6e6f8ba1 by erik.pilkington
[IRGen] Fix an assert when __attribute__((used)) is used on an ObjC method

This assert doesn't really make sense for functions in general, since they
start life as declarations, and there isn't really any reason to require them
to be defined before attributes are applied to them.

rdar://67895846
The file was addedclang/test/CodeGenObjC/attr-used-on-method.m
The file was modifiedclang/lib/CodeGen/CodeGenModule.cpp
Commit d46f2c51e4c849683434bb5a0fb6164957474b8f by erik.pilkington
Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin

This effectively disables r340386 on Darwin, and provides a command line flag
to opt into/out of this behaviour. This change is needed to compile certain
Apple headers correctly.

rdar://47688592

Differential revision: https://reviews.llvm.org/D86881
The file was modifiedclang/lib/Driver/ToolChains/Darwin.cpp
The file was modifiedclang/include/clang/Basic/LangOptions.def
The file was modifiedclang/lib/AST/Decl.cpp
The file was modifiedclang/lib/Driver/ToolChains/Clang.cpp
The file was modifiedclang/include/clang/Driver/Options.td
The file was modifiedclang/lib/Frontend/CompilerInvocation.cpp
The file was addedclang/test/CodeGenCXX/visibility-inlines-hidden-static-local-var.cpp
The file was modifiedclang/test/Driver/darwin-objc-options.m