FailedChanges

Summary

  1. [StackProtector] Fix crash with vararg due to not checking LocationSize validity. (details)
  2. [debugserver] Fix that debugserver's stop reply packets always return signal code 0 (details)
  3. Fix broken HUGE_VALF macro in llvm-c/DataTypes.h (details)
Commit 2878ecc90f1f22cf0b96c04a4124122db008a2a9 by Amara Emerson
[StackProtector] Fix crash with vararg due to not checking LocationSize validity.

Differential Revision: https://reviews.llvm.org/D87074
The file was addedllvm/test/CodeGen/X86/stack-guard-memloc-vararg.ll
The file was modifiedllvm/lib/CodeGen/StackProtector.cpp
Commit f0699d9109143754088c26604c58f5ab3e9d4678 by Raphael Isemann
[debugserver] Fix that debugserver's stop reply packets always return signal code 0

If our process terminates due to an unhandled signal, we are supposed to get the
signal code via WTERMSIG. However, we instead try to get the exit status via
WEXITSTATUS which just ends up always calculating signal code 0 (at least on the
macOS implementation where it just shifts the signal code bits away and we're
left with only 0 bits).

The exit status calculation on the LLDB side also seems a bit off as it claims
an exit status that is just the signal code (instead of for example 128 + signal
code), but that will be another patch.

Reviewed By: jasonmolenda

Differential Revision: https://reviews.llvm.org/D86336
The file was addedlldb/test/Shell/Process/TestAbortExitCode.test
The file was modifiedlldb/tools/debugserver/source/RNBRemote.cpp
The file was addedlldb/test/Shell/Process/Inputs/abort.c
Commit 9124fa592098d3794d7b31f83a58e40cc469ff0c by Raphael Isemann
Fix broken HUGE_VALF macro in llvm-c/DataTypes.h

Commit 3a29393b4709d15069130119cf1d136af4a92d77 removes the cmath/math.h
includes from the DataTypes.h header to speed up parsing. However the
DataTypes.h header was using this header to get the macro `HUGE_VAL` for its own
`HUGE_VALF` macro definition. Now the macro instead just expands into a plain
`HUGE_VAL` token which leads to compiler errors unless `math.h` was previously
included by the including source file. It also leads to compiler warnings with
enabled module builds which point out this inconsistency.

The correct way to fix this seems to be to just remove HUGE_VALF from the
header. llvm-c is not referencing that macro from what I can see and users
probably should just include the math headers if they need it (or define it on
their own for really old C versions).

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D83761
The file was modifiedllvm/include/llvm-c/DataTypes.h