SuccessChanges

Summary

  1. Thread safety analysis: Document how try-acquire is handled (details)
  2. Set InvalidDecl directly when deserializing a Decl (details)
  3. [MLIR] Remove unused arg from affine tiling validity check (details)
  4. [InstCombine] Add tests for abs intrinsic eq zero (NFC) (details)
  5. [InstCombine] Fold abs intrinsic eq zero (details)
Commit 8544defdcb09bbbbc25c5958e5f5b5762e9b9046 by aaronpuchert
Thread safety analysis: Document how try-acquire is handled

I don't think this is obvious, since try-acquire seemingly contradicts
our usual requirements of "no conditional locking".

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D87065
The file was modifiedclang/docs/ThreadSafetyAnalysis.rst
Commit 16975a638df3cda95c677055120b23e689d96dcd by aaronpuchert
Set InvalidDecl directly when deserializing a Decl

When parsing a C++17 binding declaration, we first create the
BindingDecls in Sema::ActOnDecompositionDeclarator, and then build the
DecompositionDecl in Sema::ActOnVariableDeclarator, so the contained
BindingDecls are never null. But when deserializing, we read the
DecompositionDecl with all properties before filling in the Bindings.
Among other things, reading a declaration reads whether it's invalid,
then calling setInvalidDecl which assumes that all bindings of the
DecompositionDecl are available, but that isn't the case.

Deserialization should just set all properties directly without invoking
subsequent functions, so we just set the flag without using the setter.

Fixes PR34960.

Reviewed By: rsmith

Differential Revision: https://reviews.llvm.org/D86207
The file was modifiedclang/lib/Serialization/ASTReaderDecl.cpp
The file was modifiedclang/test/PCH/cxx1z-decomposition.cpp
Commit 430b47a17d2281bd566fc1aac19de80b99e6f0c6 by uday
[MLIR] Remove unused arg from affine tiling validity check

Drop unused function arg from affine loop tiling validity check.
The file was modifiedmlir/lib/Dialect/Affine/Transforms/LoopTiling.cpp
Commit 94c71d6aa1632170e27c60db4aa63c86e95bd450 by nikita.ppv
[InstCombine] Add tests for abs intrinsic eq zero (NFC)
The file was modifiedllvm/test/Transforms/InstCombine/icmp.ll
Commit ada8a17d945c17c5603e24824f642ca199412adf by nikita.ppv
[InstCombine] Fold abs intrinsic eq zero

Following the same transform for the select version of abs.
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
The file was modifiedllvm/test/Transforms/InstCombine/icmp.ll