FailedChanges

Summary

  1. [Test] Auto-generated checks for some IndVarSimplify tests (details)
  2. [Attributor][FIX] Properly return changed if the IR was modified (details)
  3. [Attributor][NFC] Expand `auto` types (clang-fix-it) (details)
  4. [Attributor][NFC] Clang tidy: no else after continue (details)
  5. [Attributor][NFC] Change variable spelling (details)
  6. [Attributor][NFC] Cleanup internalize test case (details)
  7. [Attributor][FIX] Don't crash on internalizing linkonce_odr hidden functions (details)
  8. [ELF] --symbol-ordering-file: optimize a loop (details)
  9. [LSR] Canonicalize a formula before insert it into the list (details)
  10. [clang] Remove a stray semicolon, fixing pedantic GCC warnings. NFC. (details)
  11. [PowerPC] Add parentheses to silence gcc warning (details)
  12. [AARCH64][RegisterCoalescer] clang miscompiles zero-extension to long long (details)
  13. [PowerPC] Fix getMemOperandWithOffsetWidth (details)
  14. [Test] More tests where IndVars fails to eliminate a range check (details)
  15. [flang] Convert release notes to markdown (details)
Commit 247d02396524649a31bc45541f97457e32b8ef48 by mkazantsev
[Test] Auto-generated checks for some IndVarSimplify tests
The file was modifiedllvm/test/Transforms/IndVarSimplify/canonicalize-cmp.ll
The file was modifiedllvm/test/Transforms/IndVarSimplify/lftr-multi-exit.ll
The file was modifiedllvm/test/Transforms/IndVarSimplify/pr18223.ll
Commit 79651265b2e08e105f3d66d5f75bc9f5fa803e45 by johannes
[Attributor][FIX] Properly return changed if the IR was modified

Deleting or replacing anything is certainly a modification. This caused
a later assertion in IPSCCP when compiling 400.perlbench with the new PM.
I'm not sure how to test this.
The file was modifiedllvm/lib/Transforms/IPO/Attributor.cpp
Commit ff70c25d76561d0789743fa9f718dcd520199a7c by johannes
[Attributor][NFC] Expand `auto` types (clang-fix-it)
The file was modifiedllvm/lib/Transforms/IPO/Attributor.cpp
Commit 8637acac5a3f4688114290b524eb5154a0bcdbdf by johannes
[Attributor][NFC] Clang tidy: no else after continue
The file was modifiedllvm/lib/Transforms/IPO/AttributorAttributes.cpp
Commit e6208849c8d63690ac3489813eb13196df7ed8dc by johannes
[Attributor][NFC] Change variable spelling
The file was modifiedllvm/lib/Transforms/IPO/Attributor.cpp
Commit 53e4ef7fc25903430436ce456909d97aaa0fd6b2 by johannes
[Attributor][NFC] Cleanup internalize test case

One run line was different and probably introduced for the manually
added function attribute & name checks. We can do this with the script
and a check prefix used for the other run lines as well.
The file was modifiedllvm/test/Transforms/Attributor/internalize.ll
Commit 711bf7dcf9546fefe18d32a5772d48e7b5166f08 by johannes
[Attributor][FIX] Don't crash on internalizing linkonce_odr hidden functions

The CloneFunctionInto has implicit requirements with regards to the
linkage and visibility of the function. We now update these after we did
the CloneFunctionInto on the copy with the same linkage and visibility
as the original.
The file was modifiedllvm/lib/Transforms/IPO/Attributor.cpp
The file was modifiedllvm/test/Transforms/Attributor/internalize.ll
Commit e59d9df774ed7d94455b224f0e3f6eaeae707259 by i
[ELF] --symbol-ordering-file: optimize a loop
The file was modifiedlld/ELF/Writer.cpp
Commit 78071fb52456f5da9d044588e58a946c0ad96830 by weiwei64
[LSR] Canonicalize a formula before insert it into the list

In GenerateConstantOffsetsImpl, we may generate non canonical Formula
if BaseRegs of that Formula is updated and includes a recurrent expr reg
related with current loop while its ScaledReg is not.

Patched by: mdchen
Reviewed By: qcolombet

Differential Revision: https://reviews.llvm.org/D86939
The file was modifiedllvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp
The file was addedllvm/test/Transforms/LoopStrengthReduce/AArch64/pr47329.ll
Commit 28b9ace85f6871cdb48f1483314d8342e099b136 by martin
[clang] Remove a stray semicolon, fixing pedantic GCC warnings. NFC.
The file was modifiedclang/include/clang/AST/IgnoreExpr.h
Commit ea795304ec073a63c3c5b4fd0c5579e667201dad by mikael.holmen
[PowerPC] Add parentheses to silence gcc warning

Without gcc 7.4 warns with

../lib/Target/PowerPC/PPCInstrInfo.cpp:2284:25: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
          BaseOp1.isFI() &&
          ~~~~~~~~~~~~~~~^~
              "Only base registers and frame indices are supported.");
              ~
The file was modifiedllvm/lib/Target/PowerPC/PPCInstrInfo.cpp
Commit 8ee1419ab688ee2da2ac2cb0cf19db03f4c4742e by simon.wallis2
[AARCH64][RegisterCoalescer] clang miscompiles zero-extension to long long

Implement AArch64 variant of shouldCoalesce() to detect a known failing case
and prevent the coalescing of a 32-bit copy into a 64-bit sign-extending load.

Do not coalesce in the following case:
COPY where source is bottom 32 bits of a 64-register,
and destination is a 32-bit subregister of a 64-bit register,
ie it causes the rest of the register to be implicitly set to zero.

A mir test has been added.

In the test case, the 32-bit copy implements a 32 to 64 bit zero extension
and relies on the upper 32 bits being zeroed.

Coalescing to the result of the 64-bit load meant overwriting
the upper 32 bits incorrectly when the loaded byte was negative.

Reviewed By: john.brawn

Differential Revision: https://reviews.llvm.org/D85956
The file was modifiedllvm/lib/Target/AArch64/AArch64RegisterInfo.cpp
The file was addedllvm/test/CodeGen/AArch64/zext-reg-coalesce.mir
The file was modifiedllvm/lib/Target/AArch64/AArch64RegisterInfo.h
Commit bb39eb9e7f42ba8d1f86f961d7f887f9d626b733 by qiucofan
[PowerPC] Fix getMemOperandWithOffsetWidth

Commit 3c0b3250 introduced memory cluster under pwr10 target, but a
check for operands was unexpectedly removed. This adds it back to avoid
regression.
The file was modifiedllvm/lib/Target/PowerPC/PPCInstrInfo.cpp
Commit 046f2402025c2ac93c1efc02acd60c5222e052f7 by mkazantsev
[Test] More tests where IndVars fails to eliminate a range check
The file was modifiedllvm/test/Transforms/IndVarSimplify/monotonic_checks.ll
Commit 69230e75f120141979248becac30ceaca4ab2e87 by richard.barton
[flang] Convert release notes to markdown

Switch ReleaseNotes from .rst to .md to match the other docs.

At the same time, fix the version number for master.
The file was removedflang/docs/ReleaseNotes.rst
The file was addedflang/docs/ReleaseNotes.md