FailedChanges

Summary

  1. [lldb] Have the Xcode build run check-lldb instead of just check-lldb-shell (details)
Commit f63e49a069fad6631c55559cc9bdbb8e66dba34c by Jonas Devlieghere
[lldb] Have the Xcode build run check-lldb instead of just check-lldb-shell

For the Xcode generated build we were only running the shell tests to
reduce the test time (and flakiness) of the bot. However, this has
allowed multiple configuration issues to slip in, so I've switched back
to check-lldb.
The file was modifiedzorg/jenkins/monorepo_build.py (diff)

Summary

  1. [Support] Use unique_function rather than std::function for ThreadPool TaskTy. (details)
  2. [NFC] Fix whitespace in lldb-vscode --help (details)
  3. [PGO] Skip if an IndirectBrInst critical edge cannot be split (details)
  4. [compiler-rt] [netbsd] Update generate_netbsd_syscalls.awk (details)
  5. [compiler-rt] [netbsd] Regenerate syscall hooks (details)
  6. [SLPVectorizer][X86][AMDGPU] Remove fcmp+select to fmin/fmax reduction support. (details)
  7. Revert "[Support] Use unique_function rather than std::function for ThreadPool TaskTy." (details)
  8. [WebAssembly] Set unreachable as canonical to permit disassembly (details)
  9. Make struct dialects have the same field name as everything else, 'dialect'. (details)
  10. Allow Dialects to be initialized via nullptr. (details)
  11. [gn build] (semi-manually) port 009cd4e4910 (details)
  12. Fix operator!= for Dialects. (details)
  13. [Hexagon] Split pair-based masked memops (details)
  14. [SVE] Bail from VectorUtils heuristics for scalable vectors (details)
  15. [ImplicitNullChecks] NFC: Remove unused PointerReg arg in dep analysis (details)
  16. [libc][NFC][obvious] Remove a redudant dep of strcmp implementation. (details)
  17. Diable sanitizer options for amdgpu (details)
  18. GlobalISel: Combine fneg(fneg x) to x (details)
Commit d9c8b0256cfc673c2413b13993c9440be598818f by Lang Hames
[Support] Use unique_function rather than std::function for ThreadPool TaskTy.

This will allow non-copyable function objects (e.g. lambdas that capture
unique_ptrs) to be used with ThreadPool.

Differential Revision: https://reviews.llvm.org/D87467
The file was modifiedllvm/unittests/Support/ThreadPool.cpp
The file was modifiedllvm/include/llvm/Support/ThreadPool.h
Commit 6040d525507ba8a2593f0906259d012725b6aed2 by rupprecht
[NFC] Fix whitespace in lldb-vscode --help
The file was modifiedlldb/tools/lldb-vscode/lldb-vscode.cpp
Commit a0ffe2b21a5159f3f8eed8e98e488e723aa7cab3 by i
[PGO] Skip if an IndirectBrInst critical edge cannot be split

PGOInstrumentation runs `SplitIndirectBrCriticalEdges` but some IndirectBrInst
critical edge cannot be split. `getInstrBB` will crash when calling `SplitCriticalEdge`, e.g.

  int foo(char *p) {
    void *targets[2];
    targets[0] = &&indirect;
    targets[1] = &&end;
    for (;; p++)
      if (*p == 7) {
  indirect:
        goto *targets[p[1]]; // the self loop is critical in -O
      }
  end:
    return 0;
  }

Skip such critical edges to prevent a crash.

Reviewed By: davidxl, lebedev.ri

Differential Revision: https://reviews.llvm.org/D87435
The file was modifiedllvm/test/Transforms/PGOProfile/split-indirectbr-critical-edges.ll
The file was modifiedllvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
Commit bba736e5036f3983ca22f08dec277fdf37926115 by n54
[compiler-rt] [netbsd] Update generate_netbsd_syscalls.awk

Sync with NetBSD 9.99.72.
The file was modifiedcompiler-rt/utils/generate_netbsd_syscalls.awk
Commit 00460ae520e284ae8c0cd400c1c75c0c7a0e8fa7 by n54
[compiler-rt] [netbsd] Regenerate syscall hooks

Sync with NetBSD 9.99.72.
The file was modifiedcompiler-rt/include/sanitizer/netbsd_syscall_hooks.h
The file was modifiedcompiler-rt/lib/sanitizer_common/sanitizer_syscalls_netbsd.inc
Commit c195ae2f003261f2c25f569b07ae556dee57f17d by craig.topper
[SLPVectorizer][X86][AMDGPU] Remove fcmp+select to fmin/fmax reduction support.

Previously we could match fcmp+select to a reduction if the fcmp had
the nonans fast math flag. But if the select had the nonans fast
math flag, InstCombine would turn it into a fminnum/fmaxnum intrinsic
before SLP gets to it. Seems fairly likely that if one of the
fcmp+select pair have the fast math flag, they both would.

My plan is to start vectorizing the fmaxnum/fminnum version soon,
but I wanted to get this code out as it had some of the strangest
fast math flag behaviors.
The file was modifiedllvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/horizontal-list.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/AMDGPU/horizontal-store.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/AMDGPU/reduction.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/horizontal-minmax.ll
Commit 54fcea86b1658f5fc70f4f1e7a763f87742d79bc by Lang Hames
Revert "[Support] Use unique_function rather than std::function for ThreadPool TaskTy."

This reverts commit d9c8b0256cfc673c2413b13993c9440be598818f.

Some MSVC std::packaged_task implementations are not compatible with move-only types.
This caused failures on some of the Windows builders (e.g.
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/69412).

Reverting until I can come up with a workaround.
The file was modifiedllvm/unittests/Support/ThreadPool.cpp
The file was modifiedllvm/include/llvm/Support/ThreadPool.h
Commit 4252f3009b169db250559d6a197b399375f89b27 by d.c.ddcc
[WebAssembly] Set unreachable as canonical to permit disassembly

Currently, using llvm-objdump to disassemble a function containing
unreachable will trigger an assertion while decoding the opcode, since both
unreachable and debug_unreachable have the same encoding. To avoid this, set
unreachable as the canonical decoding.

Differential Revision: https://reviews.llvm.org/D87431
The file was modifiedllvm/lib/Target/WebAssembly/WebAssemblyInstrControl.td
Commit a39423084cbbeb59e81002e741190dccf08b5c82 by joker.eph
Make struct dialects have the same field name as everything else, 'dialect'.

Also make the behavior of getting a dialect more forgiving, in the case where
there isn't a dialect associated with an attribute.

Depends On D86807

Reviewed By: mehdi_amini

Differential Revision: https://reviews.llvm.org/D86809
The file was modifiedmlir/lib/TableGen/Attribute.cpp
The file was modifiedmlir/include/mlir/IR/OpBase.td
Commit d867be5de389f18cf3c1a61c8b9cbf8bfda8fe28 by joker.eph
Allow Dialects to be initialized via nullptr.

This allows Dialect to follow the MLIR style of nullable objects, and in fact is expected by `Dialect::operator bool() const` which already tests whether `def == nullptr`. This just wasn't a reachable situation, because the constructor was dereferencing the pointer unconditionally.

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D86807
The file was modifiedmlir/lib/TableGen/Dialect.cpp
Commit 5692497aef08ab4810f125669bc2f6aa79d9ec7e by thakis
[gn build] (semi-manually) port 009cd4e4910
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Target/PowerPC/BUILD.gn
Commit 2141705337989195b448e292955f08884babbcbd by joker.eph
Fix operator!= for Dialects.

Currently the global operator!=(bool, bool) is selected due to the implicit bool
conversion operator. Since this is never the desired semantics, we give it a
standard operator!= and make the bool conversion explicit.

Depends On D86809

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D86810
The file was modifiedmlir/include/mlir/TableGen/Dialect.h
Commit 783e28a50839e045b72ec11946295fba104642fc by kparzysz
[Hexagon] Split pair-based masked memops
The file was modifiedllvm/lib/Target/Hexagon/HexagonISelLoweringHVX.cpp
The file was addedllvm/test/CodeGen/Hexagon/autohvx/isel-split-masked.ll
Commit 7ddfd9b3ebfd3f3db7c6c2e8c72308ff3a3426f2 by ctetreau
[SVE] Bail from VectorUtils heuristics for scalable vectors

Bail from maskIsAllZeroOrUndef and maskIsAllOneOrUndef prior to iterating over the number of
elements for scalable vectors.

Assert that the mask type is not scalable in possiblyDemandedEltsInMask .

Assert that the types are correct in all three functions.

Reviewed By: efriedma

Differential Revision: https://reviews.llvm.org/D87424
The file was modifiedllvm/include/llvm/Analysis/VectorUtils.h
The file was modifiedllvm/lib/Analysis/VectorUtils.cpp
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
The file was addedllvm/test/Transforms/InstCombine/AArch64/VectorUtils_heuristics.ll
Commit b1b9806370196234a62304d308a9f8873759ec28 by anna
[ImplicitNullChecks] NFC: Remove unused PointerReg arg in dep analysis

The PointerReg arg was passed into the dependence function for an
assertion which no longer exists. So, this patch updates the dependence
functions to avoid the PointerReg in the signature.

Tests-Run: make check
The file was modifiedllvm/lib/CodeGen/ImplicitNullChecks.cpp
Commit 878cb5170de9bf03798a40185952bdf50fe4a15e by sivachandra
[libc][NFC][obvious] Remove a redudant dep of strcmp implementation.
The file was modifiedlibc/src/string/CMakeLists.txt
Commit 4934127e627d7c58342be15bc9230a7cbdf5273f by Yaxun.Liu
Diable sanitizer options for amdgpu

Currently AMDGPU does not support sanitizer. Disable
sanitizer options for now until they are supported.

Differential Revision: https://reviews.llvm.org/D87461
The file was modifiedclang/lib/Driver/SanitizerArgs.cpp
The file was addedclang/test/Driver/hip-sanitize-options.hip
Commit d4bf90271fa988101bdad4f2e78b8c3a0b85fc2d by vkeles
GlobalISel: Combine fneg(fneg x) to x

https://reviews.llvm.org/D87473
The file was modifiedllvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h
The file was addedllvm/test/CodeGen/AArch64/GlobalISel/combine-fneg.mir
The file was modifiedllvm/include/llvm/Target/GlobalISel/Combine.td
The file was modifiedllvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp

Summary

  1. [lldb] Have the Xcode build run check-lldb instead of just check-lldb-shell (details)
Commit f63e49a069fad6631c55559cc9bdbb8e66dba34c by Jonas Devlieghere
[lldb] Have the Xcode build run check-lldb instead of just check-lldb-shell

For the Xcode generated build we were only running the shell tests to
reduce the test time (and flakiness) of the bot. However, this has
allowed multiple configuration issues to slip in, so I've switched back
to check-lldb.
The file was modifiedzorg/jenkins/monorepo_build.py