FailedChanges

Summary

  1. [Scalarizer] Avoid changing name of non-instructions (details)
  2. [ARM][MVE] Tail-predication: use unsigned SCEV ranges for tripcount (details)
  3. AliasSetTracker.cpp - remove unnecessary includes. NFCI. (details)
  4. ProvenanceAnalysis.h - remove unnecessary AliasAnalysis.h include. NFCI. (details)
  5. LoopCacheAnalysis.h - remove unnecessary includes. NFCI. (details)
  6. [libc++] Allow building without threads in standalone builds (details)
  7. Restrict UnnecessaryCopyInitialization check to variables initialized from free functions without arguments (details)
  8. [ConstraintSolver] Add isConditionImplied helper. (details)
  9. [Flang] Add GettingInvolved documentation page and sidebar. (details)
  10. [lld][WebAssembly] Fix --export-all when __stack_pointer is present (details)
  11. [gn build] (semi-manually) port 380e746bcca (details)
  12. [ConstraintElimination] Add initial tests. (details)
  13. [libcxx] Disable failing test for no-exceptions build (details)
  14. [InstCombine] improve test names; NFC (details)
  15. [InstCombine] add RUN to show miscompile of pow expansion; NFC (details)
  16. [InstCombine] fix bug in pow expansion (details)
  17. [gn build] Port a8058c6f8d1 (details)
  18. [gn build] Port cd4edf94cd4 (details)
  19. [mlir][Standard] Add canonicalizer for dynamic_tensor_from_elements (details)
  20. [mlir][openacc] Add missing print of vector_length in parallel op (details)
  21. [Utils] isLegalToPromote - Fix missing null check before writing to FailureReason. (details)
  22. AMDGPUPrintfRuntimeBinding.cpp - drop unnecessary casts/dyn_casts. NFCI. (details)
  23. Revert "[SelectionDAG] Remove unused FP constant in getNegatedExpression" (details)
  24. [LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec (details)
  25. [libc] Fix typo in platform_defs.h.inc (details)
  26. [libc] Add missing LibcFPTestHelpers library (details)
  27. [libc] Add missing TableGen dependency (details)
Commit aa8be5aeead7ad894270aa025e7165169c1a54d2 by bjorn.a.pettersson
[Scalarizer] Avoid changing name of non-instructions

The "takeName" logic in ScalarizerVisitor::gather did not consider
that the value vector could refer to non-instructions, such as
global variables. This patch make sure that we avoid changing the
name of a value if it isn't an instruction.

Reviewed By: lebedev.ri

Differential Revision: https://reviews.llvm.org/D87685
The file was addedllvm/test/Transforms/Scalarizer/global-bug-2.ll
The file was modifiedllvm/lib/Transforms/Scalar/Scalarizer.cpp
Commit 635b87511ec3d6d2fa8f65a3ed1876f01367584e by sjoerd.meijer
[ARM][MVE] Tail-predication: use unsigned SCEV ranges for tripcount

Loop tripcount expressions have a positive range, so use unsigned SCEV ranges
for them.

Differential Revision: https://reviews.llvm.org/D87608
The file was modifiedllvm/lib/Target/ARM/MVETailPredication.cpp
Commit 6d40f35c9fa66d34db88542a77b8f185906ae20b by llvm-dev
AliasSetTracker.cpp - remove unnecessary includes. NFCI.

These are all directly included in AliasSetTracker.h
The file was modifiedllvm/lib/Analysis/AliasSetTracker.cpp
Commit 796c80526929e672efbdb2dfae1add1cc66c46b8 by llvm-dev
ProvenanceAnalysis.h - remove unnecessary AliasAnalysis.h include. NFCI.

Forward declare AAResults instead of the (old) AliasAnalysis type.
The file was modifiedllvm/lib/Transforms/ObjCARC/ProvenanceAnalysis.h
Commit 50d2a5d4c747855dc86a8b66a4a228abb66ca08e by llvm-dev
LoopCacheAnalysis.h - remove unnecessary includes. NFCI.

More remaining dependencies down to LoopCacheAnalysis.cpp
The file was modifiedllvm/include/llvm/Analysis/LoopCacheAnalysis.h
The file was modifiedllvm/lib/Analysis/LoopCacheAnalysis.cpp
Commit da104444fafbc8f657f06c2188ab2e8284563e3d by Louis Dionne
[libc++] Allow building without threads in standalone builds

Setting _LIBCPP_HAS_NO_THREADS is needed when building libcxxabi without
threads in standalone mode. This is useful when target WASM. Otherwise,
you get an error like "No thread API" when building libcxxabi.

It would be better to link against a properly-configured libc++ headers
CMake target when building libc++abi instead, but we don't generate such
targets yet.

Thanks to Matthew Bauer for the patch.

Differential Revision: https://reviews.llvm.org/D60743
The file was modifiedlibcxxabi/CMakeLists.txt
Commit 98e07b5596c8692c43770bc4e21a2b19467e35f7 by aaron
Restrict UnnecessaryCopyInitialization check to variables initialized from free functions without arguments

This restriction avoids cases where an alias is returned to an argument and
which could lead to to a false positive change.
The file was modifiedclang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-copy-initialization.cpp
The file was modifiedclang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp
Commit db22e70d010744573df19d69ed3de5b84ea60d1c by flo
[ConstraintSolver] Add isConditionImplied helper.

This patch adds a isConditionImplied function that
takes a constraint and returns true if the constraint
is implied by the current constraints in the system.

Reviewed By: spatel

Differential Revision: https://reviews.llvm.org/D84545
The file was modifiedllvm/unittests/Analysis/ConstraintSystemTest.cpp
The file was modifiedllvm/include/llvm/Analysis/ConstraintSystem.h
The file was modifiedllvm/lib/Analysis/ConstraintSystem.cpp
Commit fe395aecd9e70b815e6490639098d815385f9932 by joshisameeran17
[Flang] Add GettingInvolved documentation page and sidebar.

Adds a new GettingInvolved page to documentation which provides details about
mailing list, chats and calls.

Adds a sidebar page which provides common links on
all documentation pages.
The links include:
-  Getting Started
-  Getting Involved
-  Github Repository
-  Bug Reports
-  Code Review

Depends on https://reviews.llvm.org/D87242

Reviewed By: richard.barton.arm

Differential Revision: https://reviews.llvm.org/D87270
The file was modifiedflang/docs/index.md
The file was addedflang/docs/GettingInvolved.md
The file was addedflang/docs/_templates/indexsidebar.html
The file was modifiedflang/docs/conf.py
The file was addedflang/docs/_templates/layout.html
Commit 3f411e97739ffbdca0077d1c4fdc9c1fc1819019 by sbc
[lld][WebAssembly] Fix --export-all when __stack_pointer is present

With https://reviews.llvm.org/D87537 we made it an error
to import or export a mutable global with the +mutable-globals
feature present.  However the scan was of the entire symbol
table rather than just the imports or exports and the filter
didn't match exaclyt meaning the `__stack_pointer` (a mutable
global) was always triggering with error when the `--export-all`
flag was used.

This also revealed that we didn't have any test coverage for
the `--export-all` flag.

This change fixes the current breakage on the emscripten-releases
roller.

Differential Revision: https://reviews.llvm.org/D87663
The file was addedlld/test/wasm/export-all.s
The file was modifiedlld/wasm/SyntheticSections.h
The file was modifiedlld/wasm/Writer.cpp
Commit 57752b1449440a7d034d2d1781f586c3c664712e by thakis
[gn build] (semi-manually) port 380e746bcca
The file was modifiedllvm/utils/gn/secondary/llvm/unittests/CodeGen/BUILD.gn
Commit 802d21cdf08ea43d5c32924ac29c44b00c4a841f by flo
[ConstraintElimination] Add initial tests.
The file was addedllvm/test/Transforms/ConstraintElimination/loops.ll
The file was addedllvm/test/Transforms/ConstraintElimination/geps.2d.ll
The file was addedllvm/test/Transforms/ConstraintElimination/geps.ll
The file was addedllvm/test/Transforms/ConstraintElimination/ugt-ule.ll
The file was addedllvm/test/Transforms/ConstraintElimination/dom.ll
The file was addedllvm/test/Transforms/ConstraintElimination/mixed.ll
The file was addedllvm/test/Transforms/ConstraintElimination/ule.ll
The file was addedllvm/test/Transforms/ConstraintElimination/i128.ll
The file was addedllvm/test/Transforms/ConstraintElimination/uge.ll
Commit 2744c2e2957221c8e9379e2232790c3e56efd90d by oliver.stannard
[libcxx] Disable failing test for no-exceptions build

This test tries to create a 2 GiB std::string, catching the bad_alloc
exception if the allocation fails. However, for no-exceptions builds
there is no way for the error to be reported, so this crashes with a
null pointer dereference.

Differential revision: https://reviews.llvm.org/D87682
The file was modifiedlibcxx/test/std/input.output/stream.buffers/streambuf/streambuf.protected/streambuf.put.area/pbump2gig.pass.cpp
Commit eb66b04cbecfbc971bf8b8abbb4c58dbd4a7564a by spatel
[InstCombine] improve test names; NFC

This is not a valid transform unless we can prove
that the program does not read errno after the pow
call and before some other function changes it.
The file was modifiedllvm/test/Transforms/InstCombine/pow-1.ll
Commit 7ffc9aa538dfa3facbbb09d3b0d517a59e967d0e by spatel
[InstCombine] add RUN to show miscompile of pow expansion; NFC

The code drops the sqrt op instead of bailing out,
so this is very wrong.
The file was modifiedllvm/test/Transforms/InstCombine/pow-4.ll
Commit aa57c1c967078a8c02e7fc2c837853dbd7cc66f4 by spatel
[InstCombine] fix bug in pow expansion

There at least one other bug related to pow -> sqrt transforms:
http://lists.llvm.org/pipermail/llvm-dev/2020-September/145051.html
...but we probably can't solve that without fixing this first.
The file was modifiedllvm/lib/Transforms/Utils/SimplifyLibCalls.cpp
The file was modifiedllvm/test/Transforms/InstCombine/pow-4.ll
Commit 46dc41e1ef9c38cc4cef0a995528bbf58d616a09 by llvmgnsyncbot
[gn build] Port a8058c6f8d1
The file was modifiedllvm/utils/gn/secondary/llvm/unittests/CodeGen/BUILD.gn
Commit c0809f8d79045941d45c7bd60a12ddd0f6e0811a by llvmgnsyncbot
[gn build] Port cd4edf94cd4
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Analysis/BUILD.gn
The file was modifiedllvm/utils/gn/secondary/llvm/unittests/Analysis/BUILD.gn
Commit c897a7fb3e2a5c200a3e87a92886eab20d9f7fc7 by herhut
[mlir][Standard] Add canonicalizer for dynamic_tensor_from_elements

This add canonicalizer for

- extracting an element from a dynamic_tensor_from_elements
- propagating constant operands to the type of dynamic_tensor_from_elements

Differential Revision: https://reviews.llvm.org/D87525
The file was modifiedmlir/lib/Dialect/StandardOps/IR/Ops.cpp
The file was modifiedmlir/include/mlir/Dialect/StandardOps/IR/Ops.td
The file was modifiedmlir/test/Transforms/canonicalize.mlir
Commit 2d8f0c05dbe76a31060a729928b9b9d7ebbf0c40 by clementval
[mlir][openacc] Add missing print of vector_length in parallel op

This patch adds the missing print for the vector_length in the parallel operation.

Reviewed By: ftynse

Differential Revision: https://reviews.llvm.org/D87630
The file was modifiedmlir/lib/Dialect/OpenACC/IR/OpenACC.cpp
The file was modifiedmlir/test/Dialect/OpenACC/ops.mlir
Commit 65c6ae3b6aceb934a76c5b10b244edeed80e9cac by llvm-dev
[Utils] isLegalToPromote - Fix missing null check before writing to FailureReason.

The FailureReason input parameter maybe null, we check this in all other cases in the method but this one was missed somehow.

Fixes clang-tidy warning.
The file was modifiedllvm/lib/Transforms/Utils/CallPromotionUtils.cpp
Commit 97a23ab28ad91d589e6c0bb5dee6ae78c154da8a by llvm-dev
AMDGPUPrintfRuntimeBinding.cpp - drop unnecessary casts/dyn_casts. NFCI.

GetElementPtrInst::Create returns a GetElementPtrInst* so we don't need to cast. Similarly IntegerType inherits from the Type base class.

Also, I've used auto* in a few places to cleanup the code.

Helps fix some clang-tidy warnings which saw the dyn_casts and warned that these can return null.
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp
Commit e1669843f2aaf1e4929afdd8f125c14536d27664 by qiucofan
Revert "[SelectionDAG] Remove unused FP constant in getNegatedExpression"

2508ef01 doesn't totally fix the issue since we did not handle the case
when unused temporary negated result is the same with the result, which
is found by address sanitizer.
The file was removedllvm/test/CodeGen/X86/pr47517.ll
The file was modifiedllvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
Commit 65f6810d3a4b0ef1fdaad49e808459fbd133bb20 by stefanp
[LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec

Add Thread Local Storage Local Exec support to LLD. This is to support PC Relative addressing of Local Exec.
The patch teaches LLD to handle:
```
paddi r9, r13, x1@tprel
```
The relocation is:
```
R_PPC_TPREL34
```

Reviewed By: NeHuang, MaskRay

Differential Revision: https://reviews.llvm.org/D86608
The file was modifiedlld/ELF/Arch/PPC64.cpp
The file was addedlld/test/ELF/ppc64-tls-pcrel-le.s
Commit 85763e0758fbd238c81f233c6f9510e81c7de177 by gchatelet
[libc] Fix typo in platform_defs.h.inc

Differential Revision: https://reviews.llvm.org/D87687
The file was removedlibc/config/linux/platfrom_defs.h.inc
The file was modifiedlibc/src/__support/CMakeLists.txt
The file was addedlibc/config/linux/platform_defs.h.inc
Commit 00d6e7116c208b06e4c85bb58a40e76412be65a6 by gchatelet
[libc] Add missing LibcFPTestHelpers library

Differential Revision: https://reviews.llvm.org/D87690
The file was modifiedlibc/utils/MPFRWrapper/CMakeLists.txt
Commit e328456a9e6fa8c1ef05e183c1506ed837005847 by gchatelet
[libc] Add missing TableGen dependency

Differential Revision: https://reviews.llvm.org/D87689
The file was modifiedlibc/utils/LibcTableGenUtil/CMakeLists.txt