SuccessChanges

Summary

  1. JSONCompilationDatabase.cpp - cleanup key parsing error checks. NFCI. (details)
  2. [X86] combineX86ShufflesRecursively - fix use after move warning. NFCI. (details)
  3. DWARFYAML::emitDebugSections - fix use after std::move warnings. NFCI. (details)
  4. [X86] Rename getExtendInVec to getEXTEND_VECTOR_INREG. NFCI. (details)
Commit a735d6eae2847b039d12c75d4c794862dad59bc1 by llvm-dev
JSONCompilationDatabase.cpp - cleanup key parsing error checks. NFCI.

Merge the key + sequence/value checks with the key handling code.

Reduces the number of key string comparisons and avoids a number of clang static analyzer null dereference warnings.
The file was modifiedclang/lib/Tooling/JSONCompilationDatabase.cpp
Commit 91720ee561b2da4161df6abaddfd8a677aebb504 by llvm-dev
[X86] combineX86ShufflesRecursively - fix use after move warning. NFCI.

After moving WidenedMask is in an undefined state, so reduce scope of the variable so its reinitialized every iteration - we should still retain any memory allocation savings.
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit 6bb912336804822cc4b09f6849f1fd7d12057132 by llvm-dev
DWARFYAML::emitDebugSections - fix use after std::move warnings. NFCI.

We were using Err after it had been moved into cantFail - avoid this by calling cantFail with Error::success() directly.
The file was modifiedllvm/lib/ObjectYAML/DWARFEmitter.cpp
Commit 2b634a9d0e144a619ba68fc064dab0771f725063 by llvm-dev
[X86] Rename getExtendInVec to getEXTEND_VECTOR_INREG. NFCI.

Make it easier to find the method by naming it after the ops it actually handles. We already do this for lowering/combining.
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp