FailedChanges

Summary

  1. [InstCombine] Add basic vector test coverage for icmp_eq/ne zero combines (details)
  2. [flang] SAVE statement should not apply to nested scoping units (details)
  3. Thread safety analysis: Improve documentation for ASSERT_CAPABILITY (details)
  4. [X86] Add 64-bit target tests (details)
Commit 98c5eebcf786ee970c57a752ac3dfededa90501a by llvm-dev
[InstCombine] Add basic vector test coverage for icmp_eq/ne zero combines
The file was modifiedllvm/test/Transforms/InstCombine/onehot_merge.ll
Commit c2921d148e7b4e61794fa5498746ec0840861cf8 by tkeith
[flang] SAVE statement should not apply to nested scoping units

SAVE statement, according to 8.6.14, must apply to the same scoping
unit, that excludes nested scoping units. For example, if the SAVE
statement is found in a MODULE, the functions contained in that module
should not inherit the SAVE attribute. I think that the code was doing
this, failing the following source:

```
MODULE pippo
SAVE

CONTAINS
PURE FUNCTION fft_stick_index( )
   IMPLICIT NONE
   INTEGER :: fft_stick_index
   INTEGER :: mc  !error: A pure subprogram may not have a variable with the SAVE attribute
END FUNCTION

END MODULE
```

Differential Revision: https://reviews.llvm.org/D88279
The file was addedflang/test/Semantics/save01.f90
The file was modifiedflang/lib/Evaluate/tools.cpp
Commit f702a6fa7c9e4c0e2871b3d6657ce4dfa525ce52 by aaronpuchert
Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

Previous description didn't actually state the effect the attribute has on
thread safety analysis (causing analysis to assume the capability is held).

Previous description was also ambiguous about (or slightly overstated) the
noreturn assumption made by thread safety analysis, implying the assumption had
to be true about the function's behavior in general, and not just its behavior
in places where it's used. Stating the assumption specifically should avoid a
perceived need to disable thread safety analysis in places where only asserting
that a specific capability is held would be better.

Reviewed By: aaronpuchert, vasild

Differential Revision: https://reviews.llvm.org/D87629
The file was modifiedclang/docs/ThreadSafetyAnalysis.rst
Commit 6d374cf78c8a80a0bbfc7ce9bc80b3f183f44c80 by llvm-dev
[X86] Add 64-bit target tests
The file was modifiedllvm/test/CodeGen/X86/2012-07-10-extload64.ll