FailedChanges

Summary

  1. [lldb][NFC] Minor cleanup in CxxModuleHandler::tryInstantiateStdTemplate (details)
  2. [clangd] Add a tweak for filling in enumerators of a switch statement. (details)
  3. [gn build] Port 018066d9475 (details)
  4. [X86] Simplify broadcast mask detection with isUndefOrEqual helper. (details)
  5. [X86] Flip isShuffleEquivalent argument order to match isTargetShuffleEquivalent (details)
  6. [AArch64] Generate .note.gnu.property based on module flags. (details)
  7. [SCEV] Also use info from assumes in applyLoopGuards. (details)
  8. [InstCombine] matchRotate - allow undef in uniform constant rotation amounts (PR46895) (details)
  9. [ARM][MVE] Enable tail-predication by default (details)
  10. [clang] Don't emit "no member" diagnostic if the lookup fails on an invalid record decl. (details)
  11. [clang-tidy] IncludeInserter: allow <> in header name (details)
Commit 0b44bb8d40af9c634203a778fe34a9a4459d288f by Raphael Isemann
[lldb][NFC] Minor cleanup in CxxModuleHandler::tryInstantiateStdTemplate

Using llvm::None and `contains` instead of `find`.
The file was modifiedlldb/source/Plugins/ExpressionParser/Clang/CxxModuleHandler.cpp
Commit 018066d9475dac8d4b7a91bf967ea9231ff4b3f1 by sam.mccall
[clangd] Add a tweak for filling in enumerators of a switch statement.

Add a tweak that populates an empty switch statement of an enumeration type with all of the enumerators of that type.

Before:
```
enum Color { RED, GREEN, BLUE };
void f(Color color) {
  switch (color) {}
}
```

After:
```
enum Color { RED, GREEN, BLUE };
void f(Color color) {
  switch (color) {
  case RED:
  case GREEN:
  case BLUE:
    break;
  }
}
```

Reviewed By: sammccall

Differential Revision: https://reviews.llvm.org/D88383
The file was addedclang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp
The file was modifiedclang-tools-extra/clangd/refactor/tweaks/CMakeLists.txt
The file was modifiedclang-tools-extra/clangd/unittests/TweakTests.cpp
Commit 31b3f32104db1293aec74ce865f7891ec8019090 by llvmgnsyncbot
[gn build] Port 018066d9475
The file was modifiedllvm/utils/gn/secondary/clang-tools-extra/clangd/refactor/tweaks/BUILD.gn
Commit 6b5198f06b585e1fa3be530be2fbc76dd2d442c1 by llvm-dev
[X86] Simplify broadcast mask detection with isUndefOrEqual helper.

Add an additional isUndefOrEqual variant that matches an entire mask, not just a single value.
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit e0820d87e3cd135a88ece609bef18a0401a85718 by llvm-dev
[X86] Flip isShuffleEquivalent argument order to match isTargetShuffleEquivalent

A while ago, we converted isShuffleEquivalent/isTargetShuffleEquivalent to both use IsElementEquivalent internally.

This allows us to make the shuffle args optional like isTargetShuffleEquivalent and update foldShuffleOfHorizOp to use isShuffleEquivalent (which it should as its using a ISD::VECTOR_SHUFFLE mask).
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit a48f6079f288619fcc7656e89e8aa7cd0aac1281 by daniel.kiss
[AArch64] Generate .note.gnu.property based on module flags.

Flags of the module derived exclusively from the compiler flag `-mbranch-protection`.
The note is generated based on the module flags accordingly.
After this change in case of compile unit without function won't have
the .note.gnu.property if the compiler flag is not present [1].

[1] https://bugs.llvm.org/show_bug.cgi?id=46480

Reviewed By: chill

Differential Revision: https://reviews.llvm.org/D80791
The file was modifiedllvm/test/CodeGen/AArch64/note-gnu-property-pac-bti-1.ll
The file was modifiedllvm/test/CodeGen/AArch64/note-gnu-property-pac-bti-2.ll
The file was modifiedllvm/test/CodeGen/AArch64/note-gnu-property-pac-bti-3.ll
The file was removedllvm/test/CodeGen/AArch64/note-gnu-property-pac-bti-5.ll
The file was removedllvm/test/CodeGen/AArch64/note-gnu-property-pac-bti-8.ll
The file was modifiedllvm/test/CodeGen/AArch64/note-gnu-property-pac-bti-0.ll
The file was removedllvm/test/CodeGen/AArch64/note-gnu-property-pac-bti-6.ll
The file was removedllvm/test/CodeGen/AArch64/note-gnu-property-pac-bti-7.ll
The file was modifiedllvm/lib/Target/AArch64/AArch64AsmPrinter.cpp
The file was modifiedllvm/test/CodeGen/AArch64/note-gnu-property-pac-bti-4.ll
Commit 0ad793f321ed8714870cacf0421e60cf9a3b7468 by flo
[SCEV] Also use info from assumes in applyLoopGuards.

Similar to collecting information from branches guarding a loop, we can
also collect information from assumes dominating the loop header.

Fixes PR47247.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D87854
The file was modifiedllvm/test/Analysis/ScalarEvolution/max-backedge-taken-count-guard-info.ll
The file was modifiedllvm/lib/Analysis/ScalarEvolution.cpp
Commit dabb14cadd356d3628b4f935c735b163a0f68f38 by llvm-dev
[InstCombine] matchRotate - allow undef in uniform constant rotation amounts (PR46895)

An extension to D87452, we can safely permit undefs in the uniform/splat detection

https://alive2.llvm.org/ce/z/nT-ptN

Differential Revision: https://reviews.llvm.org/D88402
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
The file was modifiedllvm/test/Transforms/InstCombine/rotate.ll
Commit 1696dd27fb619fbf6d28cf6aa0d74cf8ef883723 by sjoerd.meijer
[ARM][MVE] Enable tail-predication by default

We have been running tests/benchmarks downstream with tail-predication enabled
for some time now and this behaves as expected: we are not aware of any
correctness issues, and this performs better across the board than with
tail-predication disabled. Time to flip the switch!

Differential Revision: https://reviews.llvm.org/D88093
The file was modifiedllvm/lib/Target/ARM/MVETailPredication.cpp
The file was modifiedllvm/test/Transforms/LoopVectorize/ARM/mve-reduction-types.ll
The file was modifiedllvm/test/Transforms/LoopVectorize/ARM/pointer_iv.ll
The file was modifiedllvm/test/Transforms/LoopVectorize/ARM/tail-folding-reduces-vf.ll
Commit bf890dcb0f5eb05b1a98cbd1cdd24c0c4ece8f8d by hokein.wu
[clang] Don't emit "no member" diagnostic if the lookup fails on an invalid record decl.

The "no member" diagnostic is likely bogus.

Reviewed By: sammccall, #libc

Differential Revision: https://reviews.llvm.org/D86765
The file was modifiedclang/lib/Sema/SemaExpr.cpp
The file was modifiedlibcxx/test/libcxx/utilities/memory/util.smartptr/util.smartptr.shared/function_type_default_deleter.fail.cpp
The file was modifiedclang/test/SemaCXX/access-base-class.cpp
Commit fdfe324da195ebd9b9c691f006b0d6ccc64365e1 by alexfh
[clang-tidy] IncludeInserter: allow <> in header name

This adds a pair of overloads for create(MainFile)?IncludeInsertion methods that
use the presence of the <> in the file name to control whether the #include
directive will use angle brackets or quotes. Motivating examples:
https://reviews.llvm.org/D82089#inline-789412 and
https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp#L433

The overloads with the IsAngled parameter can be removed after the users are
updated.

Update usages of createIncludeInsertion.

Update (almost all) usages of createMainFileIncludeInsertion.

Reviewed By: hokein

Differential Revision: https://reviews.llvm.org/D85666
The file was modifiedclang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-init-variables.rst
The file was modifiedclang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp
The file was modifiedclang-tools-extra/clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp
The file was modifiedclang-tools-extra/clang-tidy/abseil/StringFindStartswithCheck.cpp
The file was modifiedclang-tools-extra/clang-tidy/utils/IncludeInserter.h
The file was modifiedclang-tools-extra/unittests/clang-tidy/IncludeInserterTest.cpp
The file was modifiedclang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.cpp
The file was modifiedclang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp
The file was modifiedclang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp
The file was modifiedclang-tools-extra/clang-tidy/utils/IncludeInserter.cpp
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/modernize-make-unique.rst
The file was modifiedclang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp
The file was modifiedclang-tools-extra/clang-tidy/modernize/ReplaceAutoPtrCheck.cpp
The file was modifiedclang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-init-variables.cpp
The file was modifiedclang-tools-extra/docs/ReleaseNotes.rst