AbortedChanges

Summary

  1. Allow to specify macro names for android-comparison-in-temp-failure-retry (details)
  2. [flang] Fix INQUIRE of access and formatting possibilities (details)
  3. [libc++] Don't re-export new/delete from libc++abi when they are defined in libc++ (details)
  4. [flang] Fix WRITE after BACKSPACE (details)
  5. Reland No.3: Add new hidden option -print-changed which only reports changes to IR (details)
  6. [libc++] NFC: Add missing SHA to ABI Changelog (details)
  7. [DSE] Look through memory PHI arguments when removing noop stores in MSSA. (details)
  8. [InstCombine] auto-generate complete test checks; NFC (details)
  9. [AST] do not error on APFloat invalidOp in default mode (details)
Commit 9d40fb808fd0fbd33eb3b50c20d7f402de5db91e by George Burgess IV
Allow to specify macro names for android-comparison-in-temp-failure-retry

Some projects do not use the TEMP_FAILURE_RETRY macro but define their
own one, as not to depend on glibc / Bionic details. By allowing the
user to override the list of macros, these projects can also benefit
from this check.

Differential Revision: https://reviews.llvm.org/D83144
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/android-comparison-in-temp-failure-retry.rst
The file was modifiedclang-tools-extra/clang-tidy/android/ComparisonInTempFailureRetryCheck.cpp
The file was modifiedclang-tools-extra/clang-tidy/android/ComparisonInTempFailureRetryCheck.h
The file was addedclang-tools-extra/test/clang-tidy/checkers/android-comparison-in-temp-failure-retry-custom-macro.c
Commit df6de2222c66c5a1c62da0b10c35de432ddc270a by pklausler
[flang] Fix INQUIRE of access and formatting possibilities

Don't give false positives from INQUIRE about possible
access mode changes on connected units.  DIRECT and SEQUENTIAL
cannot be intermixed, apart from allowing DIRECT on a SEQUENTIAL
file with fixed-size records and positioning.  Nor can
FORMATTED and UNFORMATTED be interchanged.  On unconnected
files, the best that we can do is "UNKNOWN".

Differential revision: https://reviews.llvm.org/D88673
The file was modifiedflang/runtime/io-stmt.cpp
Commit 8654a0f8bbf3e28eb210c75c8c70c739de637226 by Louis Dionne
[libc++] Don't re-export new/delete from libc++abi when they are defined in libc++

This is a temporary workaround until the new/delete situation is made
better (i.e. we don't include new/delete in both libc++ and libc++abi
by default).
The file was modifiedlibcxx/src/CMakeLists.txt
The file was modifiedlibcxxabi/src/CMakeLists.txt
Commit e29c9d77f128e7ef9b2b5f8f09fb06b01a9dad3a by pklausler
[flang] Fix WRITE after BACKSPACE

A WRITE to an unformatted sequential variable-length unit after
a BACKSPACE needs to forget its previous knowledge of the length
of the record that's about to be overwritten, and a BACKSPACE
after an ENDFILE or at the start of the file needs to be a no-op.

Differential revision: https://reviews.llvm.org/D88675
The file was modifiedflang/runtime/unit.cpp
The file was modifiedflang/runtime/io-api.cpp
Commit 71124a9dbdcc76cd5efec8c148001a3f808bd769 by anhtuyen
Reland No.3: Add new hidden option -print-changed which only reports changes to IR

A new hidden option -print-changed is added along with code to support
printing the IR as it passes through the opt pipeline in the new pass
manager. Only those passes that change the IR are reported, with others
only having the banner reported, indicating that they did not change the
IR, were filtered out or ignored. Filtering of output via the
-filter-print-funcs is supported and a new supporting hidden option
-filter-passes is added. The latter takes a comma separated list of pass
names and filters the output to only show those passes in the list that
change the IR. The output can also be modified via the -print-module-scope
function.

The code introduces an abstract template base class that generalizes the
comparison of IRs that takes an IR representation as template parameter.
Derived classes provide overrides that provide an event based API
for generalized reporting of IRs as they are changed in the opt pipeline
through the new pass manager.

The first of several instantiations is provided that prints the IR
in a form similar to that produced by -print-after-all with the above
mentioned filtering capabilities. This version, and the others to
follow will be introduced at the upcoming developer's conference.

Reviewed By: aeubanks (Arthur Eubanks), yrouban (Yevgeny Rouban), ychen (Yuanfang Chen), MaskRay (Fangrui Song)

Differential Revision: https://reviews.llvm.org/D86360
The file was modifiedllvm/lib/IR/LegacyPassManager.cpp
The file was modifiedllvm/lib/Passes/StandardInstrumentations.cpp
The file was addedllvm/test/Other/change-printer.ll
The file was modifiedllvm/include/llvm/Passes/StandardInstrumentations.h
Commit a0119e56751c16e3104d6bd760bb1c114a79bce7 by Louis Dionne
[libc++] NFC: Add missing SHA to ABI Changelog
The file was modifiedlibcxx/lib/abi/CHANGELOG.TXT
Commit 6c25816d7b68e794a04ba0d7659178ab17252637 by zoecarver
[DSE] Look through memory PHI arguments when removing noop stores in MSSA.

Summary:
Adds support for "following" memory through MSSA PHI arguments. This will help catch more noop stores that exist between blocks.

Originally part of D79391.

Reviewers: fhahn, jfb, asbirlea

Differential Revision: https://reviews.llvm.org/D82588
The file was modifiedllvm/test/Transforms/DeadStoreElimination/MSSA/noop-stores.ll
The file was modifiedllvm/lib/Transforms/Scalar/DeadStoreElimination.cpp
The file was removedllvm/test/Transforms/DeadStoreElimination/MSSA/simple-todo.ll
Commit 114e964dce9f18e8f3c25a3a4136e59ead9ae50c by spatel
[InstCombine] auto-generate complete test checks; NFC
The file was modifiedllvm/test/Transforms/InstCombine/bitreverse-known-bits.ll
Commit 686eb0d8ded9159b090c3ef7b33a422e1f05166e by spatel
[AST] do not error on APFloat invalidOp in default mode

If FP exceptions are ignored, we should not error out of compilation
just because APFloat indicated an exception.
This is required as a preliminary step for D88238
which changes APFloat behavior for signaling NaN convert() to set
the opInvalidOp exception status.

Currently, there is no way to trigger this error because convert()
never sets opInvalidOp. FP binops that set opInvalidOp also create
a NaN, so the path to checkFloatingPointResult() is blocked by a
different diagnostic:

  // [expr.pre]p4:
  //   If during the evaluation of an expression, the result is not
  //   mathematically defined [...], the behavior is undefined.
  // FIXME: C++ rules require us to not conform to IEEE 754 here.
  if (LHS.isNaN()) {
    Info.CCEDiag(E, diag::note_constexpr_float_arithmetic) << LHS.isNaN();
    return Info.noteUndefinedBehavior();
  }
  return checkFloatingPointResult(Info, E, St);

Differential Revision: https://reviews.llvm.org/D88664
The file was modifiedclang/lib/AST/ExprConstant.cpp