SuccessChanges

Changes from Git (git http://labmaster3.local/git/llvm-project.git)

Summary

  1. [lldb] Don't defend against internal LLVM errors in IRInterpreter (details)
  2. [mlir] Fix -Wunused (details)
  3. [AMDGPU] Fix getInstrLatency() always returning 1 (details)
  4. [lldb][NFC] Rewrite python_api/rdar-12481949 test (details)
  5. [libcxx] [test] Add casts to avoid signed/unsigned mismatch warnings on (details)
  6. [AMDGPU] Model distance to instruction in bundle (details)
  7. [llvm-readobj][test] - Fix grammar in comments. (details)
  8. [clang-tidy] Ignore implicit casts in modernize-use-default-member-init (details)
Commit f18370fe0e7576fb9947e49d66f7a6962c6822ce by Raphael Isemann
[lldb] Don't defend against internal LLVM errors in IRInterpreter
Summary: Whenever we cast an LLVM instruction to one of its subclasses,
we do a double check if the RTTI enum value actually allows us to cast
the class. I don't see a way this can ever happen as even when LLVM's
RTTI system has some corrupt internal state (which we probably should
not test in the first place) we just reuse LLVM RTTI to do the second
check.
This also means that if we ever make an actual programming error in this
function (e.g., have a enum value and then cast it to a different
subclass), we just silently fall back to the JIT in our tests.
We also can't test this code in any reasonable way.
This removes the checks and uses `llvm::cast` instead which will raise a
fatal error when casting fails.
Reviewers: labath, mib
Reviewed By: labath
Subscribers: abidh, JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D72596
The file was modifiedlldb/source/Expression/IRInterpreter.cpp
Commit 547abdd921e45fd65a2fa60f21715facb4af31b2 by sam.mccall
[mlir] Fix -Wunused
The file was modifiedmlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
Commit eca44745871bc46728903aaa262abc6344d4f959 by Stanislav.Mekhanoshin
[AMDGPU] Fix getInstrLatency() always returning 1
We do not have InstrItinerary so generic getInstLatency() was always
defaulting to return 1 cycle. We need to use TargetSchedModel instead to
compute an instruction's latency.
Differential Revision: https://reviews.llvm.org/D72655
The file was modifiedllvm/lib/Target/AMDGPU/SIInstrInfo.h
The file was modifiedllvm/lib/Target/AMDGPU/SIInstrInfo.cpp
The file was modifiedllvm/test/CodeGen/AMDGPU/max.i16.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/scheduler-handle-move-bundle.mir
Commit d8ffd601d523fa0c0a55e25e62af9ffaa618629d by Raphael Isemann
[lldb][NFC] Rewrite python_api/rdar-12481949 test
Summary: This renames the test `rdar-12481949` to `get-value-32bit-int`
as it just tests that we return the correct result get calling
GetValueAsSigned/GetValueAsUnsigned on 32-bit integers.
It also deletes all the strange things going on in this test including
resetting the data formatters (which are to my knowledge not used to
calculate scalar values) and testing Python's long integers (let's just
assume that our Python distribution works correctly). Also modernises
the setup code.
Reviewers: labath, aprantl
Reviewed By: aprantl
Subscribers: JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D72593
The file was addedlldb/packages/Python/lldbsuite/test/python_api/get-value-32bit-int/Makefile
The file was removedlldb/packages/Python/lldbsuite/test/python_api/rdar-12481949/Test-rdar-12481949.py
The file was addedlldb/packages/Python/lldbsuite/test/python_api/get-value-32bit-int/main.cpp
The file was addedlldb/packages/Python/lldbsuite/test/python_api/get-value-32bit-int/TestGetValue32BitInt.py
The file was removedlldb/packages/Python/lldbsuite/test/python_api/rdar-12481949/main.cpp
The file was removedlldb/packages/Python/lldbsuite/test/python_api/rdar-12481949/Makefile
Commit 6d8abe424a77f736fbed114eeac574b9bfe6b0c1 by bion
[libcxx] [test] Add casts to avoid signed/unsigned mismatch warnings on
MSVC++
A bug was filed that these warnings should not be emitted as
DevCom-883961. (
https://developercommunity.visualstudio.com/content/problem/883961/c4389-signedunsigned-mismatch-should-not-be-emitte.html
)
The file was modifiedlibcxx/test/std/algorithms/alg.modifying.operations/alg.remove/remove_copy.pass.cpp
The file was modifiedlibcxx/test/std/algorithms/alg.modifying.operations/alg.reverse/reverse_copy.pass.cpp
The file was modifiedlibcxx/test/std/algorithms/alg.modifying.operations/alg.remove/remove_copy_if.pass.cpp
Commit ad741853c38880dff99cd5b5035b8965c5a73011 by Stanislav.Mekhanoshin
[AMDGPU] Model distance to instruction in bundle
This change allows to model the height of the instruction within a
bundle for latency adjustment purposes.
Differential Revision: https://reviews.llvm.org/D72669
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp
The file was addedllvm/test/CodeGen/AMDGPU/bundle-latency.mir
Commit ec6579fc047f9ac18588b833dfde0b69064e013a by grimar
[llvm-readobj][test] - Fix grammar in comments.
This addresses post commit review comments for D71766.
The file was modifiedllvm/test/tools/llvm-readobj/ELF/file-header-abi-version.test
The file was modifiedllvm/test/tools/llvm-readobj/ELF/file-header-os-abi.test
Commit 45924eb4671692b3fa9fd52fe39c81ec0647a848 by malcolm.parsons
[clang-tidy] Ignore implicit casts in modernize-use-default-member-init
Summary: Initialising a pointer from nullptr involves an implicit cast.
Ignore it after getting initialiser from InitListExpr.
Fixes: PR44440
Reviewers: aaron.ballman, alexfh, JonasToth
Reviewed By: JonasToth
Subscribers: xazax.hun, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72630
The file was modifiedclang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
The file was modifiedclang-tools-extra/test/clang-tidy/checkers/modernize-use-default-member-init.cpp