SuccessChanges

Summary

  1. [MLIR][SPIRVToLLVM] Indentation and style fix in tests (details)
  2. [InstSimplify] add tests for compare of min/max; NFC (details)
  3. [test] Fix another realpath->abspath. (details)
  4. [clang] improve diagnostics for misaligned and large atomics (details)
  5. Revert "[HotColdSplit] Add test case for unlikely attribute in outlined function" (details)
Commit b9266f81bc0a2b53406a84e6ef0c4989d5f7e296 by georgemitenk0v
[MLIR][SPIRVToLLVM] Indentation and style fix in tests

Second patch with test fixes. Redundant `%{{.*}} = `
removed, label checks added, tabs converted to spaces and
some namings are changed to match the convention.

Fixed tests:
- constant-op-to-llvm
- func-ops-to-llvm (renamed)
- memory-ops-to-llvm
- misc-ops-to-llvm
- module-ops-to-llvm
- shift-ops-to-llvm (renamed)
- spirv-types-to-llvm-invalid (renamed)

Reviewed By: ftynse, rriddle

Differential Revision: https://reviews.llvm.org/D85206
The file was removedmlir/test/Conversion/SPIRVToLLVM/spirv-types-to-llvm.invalid.mlir
The file was addedmlir/test/Conversion/SPIRVToLLVM/shift-ops-to-llvm.mlir
The file was addedmlir/test/Conversion/SPIRVToLLVM/func-ops-to-llvm.mlir
The file was modifiedmlir/test/Conversion/SPIRVToLLVM/memory-ops-to-llvm.mlir
The file was modifiedmlir/test/Conversion/SPIRVToLLVM/constant-op-to-llvm.mlir
The file was removedmlir/test/Conversion/SPIRVToLLVM/shifts-to-llvm.mlir
The file was addedmlir/test/Conversion/SPIRVToLLVM/spirv-types-to-llvm-invalid.mlir
The file was modifiedmlir/test/Conversion/SPIRVToLLVM/misc-ops-to-llvm.mlir
The file was removedmlir/test/Conversion/SPIRVToLLVM/func-to-llvm.mlir
Commit 960cef75f4d289e01b338c2f98c5dca2520ee8ff by spatel
[InstSimplify] add tests for compare of min/max; NFC

The test are adapted from the existing tests for cmp/select idioms.
The file was modifiedllvm/test/Transforms/InstSimplify/maxmin_intrinsics.ll
Commit 31ec6e969d601eb4fbee7bd4be3d03d23b5b3c11 by rupprecht
[test] Fix another realpath->abspath.

This is a followup to 817b3a6fe3a4452eb61a2503c8beaa7267ca0351: in `builder_base` we should use abspath, not realpath, because the name is significant.
This is used by test cases that use `@skipIf(compiler="clang", compiler_version=['<', <version>])`
The file was modifiedlldb/packages/Python/lldbsuite/test/plugins/builder_base.py
Commit e18c6ef6b41a59af73bf5c3d7d52a8c53a471e5d by JF Bastien
[clang] improve diagnostics for misaligned and large atomics

"Listing the alignment and access size (== expected alignment) in the warning
seems like a good idea."

solves PR 46947

  struct Foo {
    struct Bar {
      void * a;
      void * b;
    };
    Bar bar;
  };

  struct ThirtyTwo {
    struct Large {
      void * a;
      void * b;
      void * c;
      void * d;
    };
    Large bar;
  };

  void braz(Foo *foo, ThirtyTwo *braz) {
    Foo::Bar bar;
    __atomic_load(&foo->bar, &bar, __ATOMIC_RELAXED);

    ThirtyTwo::Large foobar;
    __atomic_load(&braz->bar, &foobar, __ATOMIC_RELAXED);
  }

repro.cpp:21:3: warning: misaligned atomic operation may incur significant performance penalty; the expected (16 bytes) exceeds the actual alignment (8 bytes) [-Watomic-alignment]
  __atomic_load(&foo->bar, &bar, __ATOMIC_RELAXED);
  ^
repro.cpp:24:3: warning: misaligned atomic operation may incur significant performance penalty; the expected (32 bytes) exceeds the actual alignment (8 bytes) [-Watomic-alignment]
  __atomic_load(&braz->bar, &foobar, __ATOMIC_RELAXED);
  ^
repro.cpp:24:3: warning: large atomic operation may incur significant performance penalty; the access size (32 bytes) exceeds the max lock-free size (16  bytes) [-Watomic-alignment]
3 warnings generated.

Differential Revision: https://reviews.llvm.org/D85102
The file was modifiedclang/include/clang/Basic/DiagnosticGroups.td
The file was modifiedclang/include/clang/Basic/DiagnosticFrontendKinds.td
The file was modifiedclang/lib/CodeGen/CGAtomic.cpp
The file was modifiedclang/test/CodeGen/atomics-sema-alignment.c
Commit f8cc94a61afe48a4b77f111a8ad313fc3b9417de by 1894981+hiraditya
Revert "[HotColdSplit] Add test case for unlikely attribute in outlined function"

This reverts commit aa1f905890fbbfedf396530f1e14409875ece13c.

The flag -codegenprepare maybe causing failures. Reverting this
to investigate the root cause.
The file was modifiedllvm/test/Transforms/HotColdSplit/coldentrycount.ll