FailedChanges

Changes from Git (git http://labmaster3.local/git/llvm-project.git)

Summary

  1. [mlir][GPUToSPIRV] Modify the lowering of gpu.block_dim to be consistent (details)
  2. [ELF][test] Use llvm-readelf -l instead of llvm-readobj -l for some (details)
  3. Support -fstack-clash-protection for x86 (details)
  4. Revert "Support -fstack-clash-protection for x86" (details)
  5. Support -fstack-clash-protection for x86 (details)
  6. [AggressiveInstCombine] Add test with baseline CHECKs for aggressive (details)
  7. [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass (details)
  8. [X86] Recognise ROTLI/ROTRI rotations as faux shuffles (details)
  9. Fix signed/unsigned warning. (details)
  10. [lldb] [testsuite] TestGdbRemoteLibrariesSvr4Support: Fix symlinked (details)
  11. [LLDB] [doc] Update the current status of pkgsrc (NetBSD) building (details)
  12. [LLDB] [doc] Remove note about libpanel(3) and NetBSD (details)
  13. [lldb] [doc] Testing: Fix typos (details)
  14. [lldb] [doc] Status: Debugserver (remote debugging) is OK now (details)
  15. [VectorCombine] new IR transform pass for partial vector ops (details)
  16. [gn build] Port a17f03bd939 (details)
  17. [LLDB] [doc] Document NetBSD status and sort OSs alphabetically (details)
Commit aaddca1efd1d5a66d014023b9649cb273a84a7ae by ravishankarm
[mlir][GPUToSPIRV] Modify the lowering of gpu.block_dim to be consistent
with Vulkan SPEC
The existing lowering of gpu.block_dim added a global variable with the
WorkGroupSize decoration. This raises an error within Vulkan/SPIR-V
validation since Vulkan requires this to have a constant initializer.
This is not yet supported in SPIR-V dialect. Changing the lowering to
return the workgroup size as a constant value instead, obtained from
spv.entry_point_abi attribute gets around the issue for now. The
validation goes through since the workgroup size is specified using
spv.execution_mode operation.
The file was modifiedmlir/test/Conversion/GPUToSPIRV/load-store.mlir
The file was modifiedmlir/lib/Conversion/GPUToSPIRV/ConvertGPUToSPIRV.cpp
The file was modifiedmlir/test/Conversion/GPUToSPIRV/builtins.mlir
Commit 1732f50ee06f6ac3fc21046f4c486108e86d3a49 by maskray
[ELF][test] Use llvm-readelf -l instead of llvm-readobj -l for some
memory region tests
The file was modifiedlld/test/ELF/linkerscript/at2.test
The file was modifiedlld/test/ELF/linkerscript/memory-at.test
The file was modifiedlld/test/ELF/linkerscript/at4.s
The file was modifiedlld/test/ELF/linkerscript/at.s
Commit 0fd51a4554f5f4f90342f40afd35b077f6d88213 by sguelton
Support -fstack-clash-protection for x86
Implement protection against the stack clash attack [0] through inline
stack probing.
Probe stack allocation every PAGE_SIZE during frame lowering or dynamic
allocation to make sure the page guard, if any, is touched when touching
the stack, in a similar manner to GCC[1].
This extends the existing `probe-stack' mechanism with a special value
`inline-asm'. Technically the former uses function call before stack
allocation while this patch provides inlined stack probes and chunk
allocation.
Only implemented for x86.
[0] https://www.qualys.com/2017/06/19/stack-clash/stack-clash.txt
[1] https://gcc.gnu.org/ml/gcc-patches/2017-07/msg00556.html
This a recommit of 39f50da2a357a8f685b3540246c5d762734e035f with proper
LiveIn declaration, better option handling and more portable testing.
Differential Revision: https://reviews.llvm.org/D68720
The file was modifiedllvm/lib/Target/X86/X86FrameLowering.h
The file was addedllvm/test/CodeGen/X86/stack-clash-medium.ll
The file was modifiedclang/lib/Driver/ToolChains/Clang.cpp
The file was modifiedclang/include/clang/Basic/TargetInfo.h
The file was addedllvm/test/CodeGen/X86/stack-clash-dynamic-alloca.ll
The file was modifiedclang/lib/CodeGen/CGStmt.cpp
The file was modifiedllvm/lib/Target/X86/X86InstrCompiler.td
The file was modifiedclang/include/clang/Driver/Options.td
The file was modifiedclang/docs/ClangCommandLineReference.rst
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.h
The file was addedllvm/test/CodeGen/X86/stack-clash-medium-natural-probes.ll
The file was modifiedllvm/lib/Target/X86/X86FrameLowering.cpp
The file was addedllvm/test/CodeGen/X86/stack-clash-large.ll
The file was addedclang/test/Driver/stack-clash-protection.c
The file was modifiedllvm/lib/Target/X86/X86CallFrameOptimization.cpp
The file was modifiedclang/include/clang/Basic/DiagnosticCommonKinds.td
The file was modifiedclang/lib/CodeGen/CodeGenModule.cpp
The file was addedllvm/test/CodeGen/X86/stack-clash-unknown-call.ll
The file was modifiedclang/include/clang/Basic/CodeGenOptions.def
The file was modifiedclang/docs/ReleaseNotes.rst
The file was modifiedllvm/docs/ReleaseNotes.rst
The file was addedclang/test/CodeGen/stack-clash-protection.c
The file was modifiedclang/lib/Basic/Targets/X86.h
The file was addedllvm/test/CodeGen/X86/stack-clash-small.ll
The file was modifiedllvm/include/llvm/CodeGen/TargetLowering.h
The file was modifiedclang/lib/Frontend/CompilerInvocation.cpp
The file was addedllvm/test/CodeGen/X86/stack-clash-medium-natural-probes-mutliple-objects.ll
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
The file was modifiedllvm/lib/Target/X86/X86InstrInfo.td
The file was addedllvm/test/CodeGen/X86/stack-clash-no-free-probe.ll
Commit 454621160066c067c97edb0a094553d8d0339c9b by sguelton
Revert "Support -fstack-clash-protection for x86"
This reverts commit 0fd51a4554f5f4f90342f40afd35b077f6d88213.
Failures:
http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4354
The file was modifiedllvm/docs/ReleaseNotes.rst
The file was modifiedclang/docs/ReleaseNotes.rst
The file was modifiedclang/include/clang/Basic/TargetInfo.h
The file was modifiedllvm/include/llvm/CodeGen/TargetLowering.h
The file was modifiedclang/lib/Frontend/CompilerInvocation.cpp
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.h
The file was removedllvm/test/CodeGen/X86/stack-clash-medium-natural-probes-mutliple-objects.ll
The file was removedclang/test/Driver/stack-clash-protection.c
The file was modifiedclang/lib/CodeGen/CodeGenModule.cpp
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
The file was removedllvm/test/CodeGen/X86/stack-clash-medium-natural-probes.ll
The file was removedllvm/test/CodeGen/X86/stack-clash-no-free-probe.ll
The file was removedllvm/test/CodeGen/X86/stack-clash-small.ll
The file was modifiedclang/include/clang/Driver/Options.td
The file was modifiedclang/lib/CodeGen/CGStmt.cpp
The file was removedclang/test/CodeGen/stack-clash-protection.c
The file was modifiedllvm/lib/Target/X86/X86InstrInfo.td
The file was removedllvm/test/CodeGen/X86/stack-clash-large.ll
The file was modifiedllvm/lib/Target/X86/X86CallFrameOptimization.cpp
The file was modifiedclang/include/clang/Basic/DiagnosticCommonKinds.td
The file was removedllvm/test/CodeGen/X86/stack-clash-medium.ll
The file was modifiedllvm/lib/Target/X86/X86InstrCompiler.td
The file was modifiedllvm/lib/Target/X86/X86FrameLowering.cpp
The file was modifiedclang/lib/Basic/Targets/X86.h
The file was modifiedllvm/lib/Target/X86/X86FrameLowering.h
The file was removedllvm/test/CodeGen/X86/stack-clash-unknown-call.ll
The file was modifiedclang/docs/ClangCommandLineReference.rst
The file was modifiedclang/include/clang/Basic/CodeGenOptions.def
The file was modifiedclang/lib/Driver/ToolChains/Clang.cpp
The file was removedllvm/test/CodeGen/X86/stack-clash-dynamic-alloca.ll
Commit e67cbac81211d40332a79d98c9d5953624cc1202 by sguelton
Support -fstack-clash-protection for x86
Implement protection against the stack clash attack [0] through inline
stack probing.
Probe stack allocation every PAGE_SIZE during frame lowering or dynamic
allocation to make sure the page guard, if any, is touched when touching
the stack, in a similar manner to GCC[1].
This extends the existing `probe-stack' mechanism with a special value
`inline-asm'. Technically the former uses function call before stack
allocation while this patch provides inlined stack probes and chunk
allocation.
Only implemented for x86.
[0] https://www.qualys.com/2017/06/19/stack-clash/stack-clash.txt
[1] https://gcc.gnu.org/ml/gcc-patches/2017-07/msg00556.html
This a recommit of 39f50da2a357a8f685b3540246c5d762734e035f with proper
LiveIn declaration, better option handling and more portable testing.
Differential Revision: https://reviews.llvm.org/D68720
The file was modifiedllvm/lib/Target/X86/X86FrameLowering.cpp
The file was addedllvm/test/CodeGen/X86/stack-clash-large.ll
The file was modifiedllvm/include/llvm/CodeGen/TargetLowering.h
The file was addedllvm/test/CodeGen/X86/stack-clash-no-free-probe.ll
The file was addedllvm/test/CodeGen/X86/stack-clash-medium-natural-probes.ll
The file was addedclang/test/CodeGen/stack-clash-protection.c
The file was modifiedclang/docs/ReleaseNotes.rst
The file was addedllvm/test/CodeGen/X86/stack-clash-unknown-call.ll
The file was addedllvm/test/CodeGen/X86/stack-clash-medium.ll
The file was modifiedclang/include/clang/Basic/TargetInfo.h
The file was modifiedclang/lib/Frontend/CompilerInvocation.cpp
The file was addedllvm/test/CodeGen/X86/stack-clash-medium-natural-probes-mutliple-objects.ll
The file was modifiedclang/lib/CodeGen/CodeGenModule.cpp
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
The file was modifiedclang/docs/ClangCommandLineReference.rst
The file was modifiedllvm/lib/Target/X86/X86CallFrameOptimization.cpp
The file was addedllvm/test/CodeGen/X86/stack-clash-small.ll
The file was addedclang/test/Driver/stack-clash-protection.c
The file was modifiedclang/include/clang/Basic/CodeGenOptions.def
The file was modifiedclang/lib/Driver/ToolChains/Clang.cpp
The file was modifiedllvm/lib/Target/X86/X86InstrInfo.td
The file was modifiedclang/lib/Basic/Targets/X86.h
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.h
The file was modifiedclang/include/clang/Driver/Options.td
The file was modifiedllvm/lib/Target/X86/X86FrameLowering.h
The file was modifiedclang/include/clang/Basic/DiagnosticCommonKinds.td
The file was modifiedllvm/docs/ReleaseNotes.rst
The file was modifiedllvm/lib/Target/X86/X86InstrCompiler.td
The file was addedllvm/test/CodeGen/X86/stack-clash-dynamic-alloca.ll
The file was modifiedclang/lib/CodeGen/CGStmt.cpp
Commit 10c7b7708b32960c82ad295484ae94ffb5b02333 by ayman.musa
[AggressiveInstCombine] Add test with baseline CHECKs for aggressive
inst combine for SELECT.
The file was addedllvm/test/Transforms/AggressiveInstCombine/trunc_select.ll
Commit 3b70ee27a5032a52fc9502541c70b5e0e6b29dfa by ehudkatz
[LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass
The LoopExtractor created new functions (by definition), which violates
the restrictions of a LoopPass. The correct implementation of this pass
should be as a ModulePass. Includes reverting rL82990 implications on
the LoopExtractor.
Fixes PR3082 and PR8929.
Differential Revision: https://reviews.llvm.org/D69069
The file was addedllvm/test/Transforms/CodeExtractor/LoopExtractor.ll
The file was addedllvm/test/Transforms/CodeExtractor/LoopExtractor_min_wrapper.ll
The file was addedllvm/test/Transforms/CodeExtractor/LoopExtractor_crash.ll
The file was modifiedllvm/lib/Transforms/IPO/LoopExtractor.cpp
The file was addedllvm/test/Transforms/CodeExtractor/LoopExtractor_infinite.ll
The file was modifiedllvm/test/Feature/optnone-opt.ll
Commit 644d56b432bf6f50faa9638ec1b75e9d7ed3d6d4 by llvm-dev
[X86] Recognise ROTLI/ROTRI rotations as faux shuffles
Allows us to combine rotations with shuffles.
One of many things necessary to fix PR44379 (lowering shuffles to
rotations)
The file was modifiedllvm/test/CodeGen/X86/vector-shuffle-combining-xop.ll
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
The file was modifiedllvm/test/CodeGen/X86/vector-shuffle-combining-avx512bwvl.ll
Commit 3ec6de07e91989145e32489a8a6dfa9f9afbb242 by llvm-dev
Fix signed/unsigned warning.
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit 420a51806850a20ebf4144699457de84513f6abc by jan.kratochvil
[lldb] [testsuite] TestGdbRemoteLibrariesSvr4Support: Fix symlinked
builddir
When I have symlinked builddir on Fedora 31 x86_64 I get:
FAIL: test_libraries_svr4_libs_present
(TestGdbRemoteLibrariesSvr4Support.TestGdbRemoteLibrariesSvr4Support)
----------------------------------------------------------------------
...
  File
"lldb/packages/Python/lldbsuite/test/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py",
line 106, in
libraries_svr4_libs_present
    self.assertIn(self.getBuildDir() + "/" + lib, libraries_svr4_names)
AssertionError:
'/home/jkratoch/redhat/llvm-monorepo-clangassertsymlink/lldb-test-build.noindex/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.test_libraries_svr4_libs_present/libsvr4lib_a.so'
not found in
['/home/jkratoch/redhat/llvm-monorepo/lldb/packages/Python/lldbsuite/test/tools/lldb-server/libraries-svr4/linux-vdso.so.1',
'/quad/home/jkratoch/redhat/llvm-monorepo-clangassertsymlink/lldb-test-build.noindex/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.test_libraries_svr4_libs_present/libsvr4lib_a.so',
'/quad/home/jkratoch/redhat/llvm-monorepo-clangassertsymlink/lldb-test-build.noindex/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.test_libraries_svr4_libs_present/libsvr4lib_b".so',
'/usr/lib64/libdl-2.30.so', '/usr/lib64/libstdc++.so.6.0.27',
'/usr/lib64/libm-2.30.so', '/usr/lib64/libgcc_s-9-20190827.so.1',
'/usr/lib64/libc-2.30.so', '/usr/lib64/ld-2.30.so']
Config=x86_64-/quad/home/jkratoch/redhat/llvm-monorepo-clangassertsymlink/bin/clang-11
----------------------------------------------------------------------
Differential Revision: https://reviews.llvm.org/D74295
The file was modifiedlldb/packages/Python/lldbsuite/test/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py
Commit 0ea4d18a288bf2a4010632f841b421e1bdc5072a by n54
[LLDB] [doc] Update the current status of pkgsrc (NetBSD) building
The file was modifiedlldb/docs/status/releases.rst
Commit 5a285f207e109221572a0aabc83f2bce521322bd by n54
[LLDB] [doc] Remove note about libpanel(3) and NetBSD
libpanel(3) is now supported in all supported versions of NetBSD.
The file was modifiedlldb/docs/resources/build.rst
Commit 8b37e1e5ac090a498eb4940be3264e9d5ba8c97c by jan.kratochvil
[lldb] [doc] Testing: Fix typos
The file was modifiedlldb/docs/resources/test.rst
Commit 74857b4260ec9db8d688c2d377a5f370efc150b4 by jan.kratochvil
[lldb] [doc] Status: Debugserver (remote debugging) is OK now
The file was modifiedlldb/docs/status/status.rst
Commit a17f03bd93939cf30bfbb829321437bd0aaa4ef0 by spatel
[VectorCombine] new IR transform pass for partial vector ops
We have several bug reports that could be characterized as "reducing
scalarization", and this topic was also raised on llvm-dev recently:
http://lists.llvm.org/pipermail/llvm-dev/2020-January/138157.html
...so I'm proposing that we deal with these patterns in a new,
lightweight IR vector pass that runs before/after other vectorization
passes.
There are 4 alternate options that I can think of to deal with this kind
of problem
(and we've seen various attempts at all of these), but they all have
flaws:
    InstCombine - can't happen without TTI, but we don't want
target-specific
                 folds there.
   SDAG - too late to assist other vectorization passes; TLI is not
equipped
          for these kind of cost queries; limited to a single basic
block.
   CGP - too late to assist other vectorization passes; would need to
re-implement
         basic cleanups like CSE/instcombine.
   SLP - doesn't fit with existing transforms; limited to a single basic
block.
This initial patch/transform is based on existing code in
AggressiveInstCombine: we walk backwards through the function looking
for a pattern match. But we diverge from that cost-independent IR
canonicalization pass by using TTI to decide if the vector alternative
is profitable.
We probably have at least 10 similar bug reports/patterns (binops,
constants, inserts, cheap shuffles, etc) that would fit in this pass as
follow-up enhancements. It's possible that we could iterate on a
worklist to fix-point like InstCombine does, but it's safer to start
with a most basic case and evolve from there, so I didn't try to do
anything fancy with this initial implementation.
Differential Revision: https://reviews.llvm.org/D73480
The file was modifiedllvm/test/Other/opt-O2-pipeline.ll
The file was modifiedllvm/test/Other/new-pm-thinlto-postlink-samplepgo-defaults.ll
The file was modifiedllvm/test/Other/opt-O3-pipeline.ll
The file was addedllvm/test/Transforms/VectorCombine/X86/extract-cmp.ll
The file was modifiedllvm/lib/Transforms/IPO/PassManagerBuilder.cpp
The file was modifiedllvm/lib/Passes/PassRegistry.def
The file was addedllvm/include/llvm/Transforms/Vectorize/VectorCombine.h
The file was modifiedllvm/test/Other/new-pm-thinlto-defaults.ll
The file was addedllvm/lib/Transforms/Vectorize/VectorCombine.cpp
The file was modifiedllvm/lib/Transforms/Vectorize/Vectorize.cpp
The file was modifiedllvm/test/Other/new-pm-thinlto-postlink-pgo-defaults.ll
The file was modifiedllvm/test/Other/opt-Os-pipeline.ll
The file was modifiedllvm/include/llvm/InitializePasses.h
The file was modifiedllvm/include/llvm/LinkAllPasses.h
The file was modifiedllvm/lib/Transforms/Vectorize/CMakeLists.txt
The file was modifiedllvm/lib/Passes/PassBuilder.cpp
The file was modifiedllvm/test/Other/new-pm-defaults.ll
The file was modifiedllvm/include/llvm/Transforms/Vectorize.h
The file was addedllvm/test/Transforms/VectorCombine/X86/lit.local.cfg
Commit 628462e30a77da531c82112e4d489d6d7ef96300 by llvmgnsyncbot
[gn build] Port a17f03bd939
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Transforms/Vectorize/BUILD.gn
Commit 273f638384d69f71838978001bf2f542d472b5f9 by n54
[LLDB] [doc] Document NetBSD status and sort OSs alphabetically
The file was modifiedlldb/docs/status/status.rst